An open source design system that's fully customizable and agent ready
TypeScript
test(Selector, MultiSelector): wait for the on-demand sheet module before the first open (#8642)
Christopher Chedeauf77252d11e57
diff --git a/packages/core/src/MultiSelector/MultiSelector.test.tsx b/packages/core/src/MultiSelector/MultiSelector.test.tsxindex 0a0c2a0a25..b4bf70c0f2 100644--- a/packages/core/src/MultiSelector/MultiSelector.test.tsx+++ b/packages/core/src/MultiSelector/MultiSelector.test.tsx@@ -145,6 +145,13 @@ function expectSilentBusySpinner() {expect(screen.queryByRole('status', {name: 'Loading'})).toBeNull();}+// The bottom sheet is loaded on demand (SelectorBottomSheet's lazy import).+// Loading its module is not part of an open, so the file waits for it once+// here, and each test's open waits only for the open.+beforeAll(async () => {+ await import('../BottomSheet/BottomSheet');+});+describe('MultiSelector', () => {const defaultOptions = ['Apple', 'Banana', 'Orange'];diff --git a/packages/core/src/MultiSelector/__tests__/MultiSelector.listbox.a11y.test.tsx b/packages/core/src/MultiSelector/__tests__/MultiSelector.listbox.a11y.test.tsxindex 5d26a0b86d..03bb9ce4de 100644--- a/packages/core/src/MultiSelector/__tests__/MultiSelector.listbox.a11y.test.tsx+++ b/packages/core/src/MultiSelector/__tests__/MultiSelector.listbox.a11y.test.tsx@@ -9,7 +9,7 @@import {cleanup, render, screen, within} from '@testing-library/react';import userEvent from '@testing-library/user-event';-import {describe, expect, it} from 'vitest';+import {beforeAll, describe, expect, it} from 'vitest';import {expectAccessibilitySpec,LISTBOX_PATTERN,@@ -23,6 +23,13 @@ import {installListboxDialogStubs} from '../../Selector/__tests__/Listbox.a11y.dinstallListboxDialogStubs();+// The bottom sheet is loaded on demand (SelectorBottomSheet's lazy import).+// Loading its module is not part of an open, so the file waits for it once+// here, and each scenario's open waits only for the open.+beforeAll(async () => {+ await import('../../BottomSheet/BottomSheet');+});+const scenarios = LISTBOX_SCENARIOS.filter(scenario => scenario.component === 'MultiSelector',);diff --git a/packages/core/src/Selector/Selector.test.tsx b/packages/core/src/Selector/Selector.test.tsxindex 0edf56ab80..f1f1d99448 100644--- a/packages/core/src/Selector/Selector.test.tsx+++ b/packages/core/src/Selector/Selector.test.tsx@@ -293,6 +293,13 @@ function expectSilentBusySpinner() {expect(screen.queryByRole('status', {name: 'Loading'})).toBeNull();}+// The bottom sheet is loaded on demand (SelectorBottomSheet's lazy import).+// Loading its module is not part of an open, so the file waits for it once+// here, and each test's open waits only for the open.+beforeAll(async () => {+ await import('../BottomSheet/BottomSheet');+});+describe('Selector', () => {it('uses a bottom sheet and closes after a selection when requested', async () => {const user = userEvent.setup();diff --git a/packages/core/src/Selector/__tests__/Selector.combobox.a11y.test.tsx b/packages/core/src/Selector/__tests__/Selector.combobox.a11y.test.tsxindex f6d1e5845b..e841ffbdc8 100644--- a/packages/core/src/Selector/__tests__/Selector.combobox.a11y.test.tsx+++ b/packages/core/src/Selector/__tests__/Selector.combobox.a11y.test.tsx@@ -4,7 +4,7 @@import {cleanup, render, screen, waitFor, within} from '@testing-library/react';import userEvent from '@testing-library/user-event';-import {describe, expect, it} from 'vitest';+import {beforeAll, describe, expect, it} from 'vitest';import {COMBOBOX_PATTERN,expectAccessibilitySpec,@@ -20,6 +20,13 @@ import {SELECTOR_COMBOBOX_KNOWN_FAILURES} from './Combobox.a11y.known-failures';installListboxDialogStubs();+// The bottom sheet is loaded on demand (SelectorBottomSheet's lazy import).+// Loading its module is not part of an open, so the file waits for it once+// here, and each scenario's open waits only for the open.+beforeAll(async () => {+ await import('../../BottomSheet/BottomSheet');+});+const hidden = {hidden: true} as const;function subjectFor(scenario: SelectorComboboxScenario): HTMLElement {diff --git a/packages/core/src/Selector/__tests__/Selector.listbox.a11y.test.tsx b/packages/core/src/Selector/__tests__/Selector.listbox.a11y.test.tsxindex f20cacc82d..97a0de2233 100644--- a/packages/core/src/Selector/__tests__/Selector.listbox.a11y.test.tsx+++ b/packages/core/src/Selector/__tests__/Selector.listbox.a11y.test.tsx@@ -9,7 +9,7 @@import {cleanup, render, screen, within} from '@testing-library/react';import userEvent from '@testing-library/user-event';-import {describe, expect, it} from 'vitest';+import {beforeAll, describe, expect, it} from 'vitest';import {expectAccessibilitySpec,LISTBOX_PATTERN,@@ -20,6 +20,13 @@ import {installListboxDialogStubs} from './Listbox.a11y.dom';installListboxDialogStubs();+// The bottom sheet is loaded on demand (SelectorBottomSheet's lazy import).+// Loading its module is not part of an open, so the file waits for it once+// here, and each scenario's open waits only for the open.+beforeAll(async () => {+ await import('../../BottomSheet/BottomSheet');+});+const scenarios = LISTBOX_SCENARIOS.filter(scenario => scenario.component === 'Selector',);