An open source design system that's fully customizable and agent ready
TypeScript
fix(core): component audit — DateTimeInput a11y, HoverCard style escape hatches (#2415)
Cindy Zhangfa184f6849ac
diff --git a/packages/core/src/DateTimeInput/XDSDateTimeInput.tsx b/packages/core/src/DateTimeInput/XDSDateTimeInput.tsxindex 0c4cf1be3e..b22074bfda 100644--- a/packages/core/src/DateTimeInput/XDSDateTimeInput.tsx+++ b/packages/core/src/DateTimeInput/XDSDateTimeInput.tsx@@ -887,6 +887,8 @@ export function XDSDateTimeInput({placeholder={timePlaceholder}disabled={isEffectivelyDisabled}aria-label="Time"+ aria-required={isRequired === true ? 'true' : undefined}+ aria-invalid={status?.type === 'error' ? 'true' : undefined}{...stylex.props(styles.input,isEffectivelyDisabled && styles.inputDisabled,diff --git a/packages/core/src/HoverCard/XDSHoverCard.tsx b/packages/core/src/HoverCard/XDSHoverCard.tsxindex aae88d1381..92daa2b5fc 100644--- a/packages/core/src/HoverCard/XDSHoverCard.tsx+++ b/packages/core/src/HoverCard/XDSHoverCard.tsx@@ -26,6 +26,7 @@ import {useIsomorphicLayoutEffect} from '../hooks/useIsomorphicLayoutEffect';import * as stylex from '@stylexjs/stylex';import {useXDSHoverCard, type HoverCardFocusTrigger} from './useXDSHoverCard';import type {LayerAlignment, LayerPlacement} from '../Layer/useXDSLayer';+import type {XDSBaseProps} from '../XDSBaseProps';import {colorVars, spacingVars} from '../theme/tokens.stylex';export type {HoverCardFocusTrigger} from './useXDSHoverCard';@@ -45,7 +46,10 @@ const styles = stylex.create({},});-export interface XDSHoverCardProps {+export interface XDSHoverCardProps extends Pick<+ XDSBaseProps,+ 'xstyle' | 'className' | 'style'+> {/*** The trigger element(s). Children refs are preserved.*/@@ -172,6 +176,9 @@ export function XDSHoverCard({hasHoverIndication = 'auto',isOpen,isDefaultOpen,+ xstyle,+ className,+ style,}: XDSHoverCardProps): ReactElement {const wrapperRef = useRef<HTMLSpanElement>(null);const textOnly = isTextOnly(children);@@ -240,7 +247,10 @@ export function XDSHoverCard({const renderedHoverCard =typeof document !== 'undefined'- ? createPortal(hoverCard.renderHoverCard(content), document.body)+ ? createPortal(+ hoverCard.renderHoverCard(content, {xstyle, className, style}),+ document.body,+ ): null;// For text-only children: use inline span with ref on wrapper