Building AI agents, atomically
Set temperature parameter priority
Michael Crawford3aa75dffd5b9
diff --git a/atomic-agents/atomic_agents/agents/base_agent.py b/atomic-agents/atomic_agents/agents/base_agent.pyindex f0fce0d..4a72885 100644--- a/atomic-agents/atomic_agents/agents/base_agent.py+++ b/atomic-agents/atomic_agents/agents/base_agent.py@@ -121,7 +121,7 @@ class BaseAgent:self.initial_memory = self.memory.copy()self.current_user_input = Noneself.model_api_parameters = config.model_api_parameters or {}- if config.temperature is not None:+ if config.temperature is not None and "temperature" not in self.model_api_parameters:self.model_api_parameters["temperature"] = config.temperatureif config.max_tokens is not None:self.model_api_parameters["max_tokens"] = config.max_tokensdiff --git a/atomic-agents/tests/agents/test_base_agent.py b/atomic-agents/tests/agents/test_base_agent.pyindex d18cece..6ffabb1 100644--- a/atomic-agents/tests/agents/test_base_agent.py+++ b/atomic-agents/tests/agents/test_base_agent.py@@ -67,6 +67,20 @@ def test_initialization(agent, mock_instructor, mock_memory, mock_system_prompt_assert "max_tokens" not in agent.model_api_parameters+# model_api_parameters should have priority over the deprecated temperature parameter if both are provided.+def test_initialization_temperature_priority(mock_instructor, mock_memory, mock_system_prompt_generator):+ config = BaseAgentConfig(+ client=mock_instructor,+ model="gpt-4o-mini",+ memory=mock_memory,+ system_prompt_generator=mock_system_prompt_generator,+ temperature=0.5,+ model_api_parameters={"temperature": 1.0},+ )+ agent = BaseAgent(config)+ assert agent.model_api_parameters["temperature"] == 1.0++def test_reset_memory(agent, mock_memory):initial_memory = agent.initial_memoryagent.reset_memory()