Skip to content

Building AI agents, atomically

fix(forge): count elapsed time across DST in DateTimeTool diff (#315)

Darsh Joshi4aea1fa2b6a6
diff --git a/atomic-forge/tools/datetime_tool/tests/test_datetime_tool.py b/atomic-forge/tools/datetime_tool/tests/test_datetime_tool.py
index 1b98c2e..e5dc87b 100644
--- a/atomic-forge/tools/datetime_tool/tests/test_datetime_tool.py
+++ b/atomic-forge/tools/datetime_tool/tests/test_datetime_tool.py
@@ -101,6 +101,32 @@ def test_diff_negative_keeps_sign():
assert out.diff_human.startswith("-")
+def test_diff_counts_elapsed_time_across_a_dst_change():
+ tool = DateTimeTool()
+ # Clocks in New York go forward an hour on 2026-03-08, and in Brussels back an hour on 2026-10-25.
+ spring = tool.run(
+ DateTimeToolInputSchema(
+ operation="diff",
+ input="2026-03-08T00:00:00",
+ input_2="2026-03-09T00:00:00",
+ timezone="America/New_York",
+ )
+ )
+ autumn = tool.run(
+ DateTimeToolInputSchema(
+ operation="diff",
+ input="2026-10-25T00:00:00",
+ input_2="2026-10-26T00:00:00",
+ timezone="Europe/Brussels",
+ )
+ )
+ assert spring.error is None and autumn.error is None
+ assert spring.diff_seconds == 23 * 3600
+ assert spring.diff_human == "23 hours"
+ assert autumn.diff_seconds == 25 * 3600
+ assert autumn.diff_human == "1 day, 1 hour"
+
+
def test_unknown_timezone_returns_error():
tool = DateTimeTool()
out = tool.run(DateTimeToolInputSchema(operation="now", timezone="Mars/Olympus"))
diff --git a/atomic-forge/tools/datetime_tool/tool/datetime_tool.py b/atomic-forge/tools/datetime_tool/tool/datetime_tool.py
index 03de138..ab012e7 100644
--- a/atomic-forge/tools/datetime_tool/tool/datetime_tool.py
+++ b/atomic-forge/tools/datetime_tool/tool/datetime_tool.py
@@ -189,8 +189,10 @@ class DateTimeTool(BaseTool[DateTimeToolInputSchema, DateTimeToolOutputSchema]):
if params.operation == "diff":
if not params.input or not params.input_2:
raise ValueError("'diff' operation requires `input` and `input_2`.")
- a = self._parse(params.input, params.timezone)
- b = self._parse(params.input_2, params.timezone)
+ # Subtract in UTC: Python subtracts datetimes that share a tzinfo by wall clock,
+ # which ignores a DST change between them.
+ a = self._parse(params.input, params.timezone).astimezone(timezone.utc)
+ b = self._parse(params.input_2, params.timezone).astimezone(timezone.utc)
delta = b - a
return DateTimeToolOutputSchema(
operation="diff",