Skip to content

A full-featured CRM built with React, shadcn/ui, and Supabase.

fix: Rename tag deletion migration and ignore unknown tag ids in FakeRest

erwanMarmelab0a9ffba6fcb9
diff --git a/src/components/atomic-crm/providers/fakerest/dataProvider.test.ts b/src/components/atomic-crm/providers/fakerest/dataProvider.test.ts
index 1def8843..84c3897b 100644
--- a/src/components/atomic-crm/providers/fakerest/dataProvider.test.ts
+++ b/src/components/atomic-crm/providers/fakerest/dataProvider.test.ts
@@ -29,4 +29,16 @@ describe("fakerest dataProvider", () => {
expect(contacts.map((c) => c.tags)).toEqual([[2], [2]]);
expect(contacts.map((c) => c.last_seen)).toEqual([lastSeen, lastSeen]);
});
+
+ it("ignores unknown ids when getting many tags", async () => {
+ const dataProvider = createDataProvider({
+ db: { tags: [{ id: 2, name: "lead", color: "#000" }] } as unknown as Db,
+ latency: 0,
+ silent: true,
+ });
+
+ const { data: tags } = await dataProvider.getMany("tags", { ids: [1, 2] });
+
+ expect(tags.map((tag) => tag.id)).toEqual([2]);
+ });
});
diff --git a/src/components/atomic-crm/providers/fakerest/dataProvider.ts b/src/components/atomic-crm/providers/fakerest/dataProvider.ts
index 55e41c5c..5d7bc807 100644
--- a/src/components/atomic-crm/providers/fakerest/dataProvider.ts
+++ b/src/components/atomic-crm/providers/fakerest/dataProvider.ts
@@ -170,6 +170,18 @@ export const createDataProvider = ({
const dataProviderWithCustomMethod: CrmDataProvider = {
...baseDataProvider,
+ async getMany(resource: string, params: any) {
+ if (resource === "tags") {
+ // like PostgREST, ignore unknown ids (a deleted tag may still be in cached contacts)
+ const { data } = await baseDataProvider.getList(resource, {
+ filter: { id_eq_any: params.ids },
+ pagination: { page: 1, perPage: params.ids.length },
+ sort: { field: "id", order: "ASC" },
+ });
+ return { data };
+ }
+ return baseDataProvider.getMany(resource, params);
+ },
async getList(resource: string, params: any) {
if (resource === "activity_log") {
const { filter = {}, pagination } = params;
diff --git a/supabase/migrations/20260924120000_remove_deleted_tag_from_contacts.sql b/supabase/migrations/20260929120000_remove_deleted_tag_from_contacts.sql
similarity index 100%
rename from supabase/migrations/20260924120000_remove_deleted_tag_from_contacts.sql
rename to supabase/migrations/20260929120000_remove_deleted_tag_from_contacts.sql