Skip to content

A full-featured CRM built with React, shadcn/ui, and Supabase.

Turn integration test into unit test

fzaninotto17ca10e325dd
diff --git a/src/components/atomic-crm/contacts/ContactListMobile.stories.tsx b/src/components/atomic-crm/contacts/ContactList.mobile.stories.tsx
similarity index 97%
rename from src/components/atomic-crm/contacts/ContactListMobile.stories.tsx
rename to src/components/atomic-crm/contacts/ContactList.mobile.stories.tsx
index 797aa915..e515220f 100644
--- a/src/components/atomic-crm/contacts/ContactListMobile.stories.tsx
+++ b/src/components/atomic-crm/contacts/ContactList.mobile.stories.tsx
@@ -9,7 +9,7 @@ import {
} from "@/test/browser/atomic-crm/crmUiHarness";
const meta = {
- title: "Atomic CRM/Contacts/Contact List Mobile",
+ title: "Atomic CRM/Contacts/Contact List",
parameters: {
layout: "fullscreen",
},
diff --git a/src/components/atomic-crm/contacts/ContactShow.integration.test.tsx b/src/components/atomic-crm/contacts/ContactShow.integration.test.tsx
deleted file mode 100644
index 004edfb8..00000000
--- a/src/components/atomic-crm/contacts/ContactShow.integration.test.tsx
+++ /dev/null
@@ -1,53 +0,0 @@
-import { describe, expect, it, vi } from "vitest";
-import { render } from "vitest-browser-react";
-
-import {
- buildContact,
- createCrmDb,
- createCrmScenario,
- CrmTestProvider,
- MobileContactShowHarness,
-} from "@/test/browser/atomic-crm/crmUiHarness";
-
-vi.mock("@/hooks/use-mobile", () => ({
- useIsMobile: () => true,
-}));
-
-describe("Contact show integration", () => {
- it("renders a safe zero-task label before nb_tasks is available", async () => {
- const scenario = createCrmScenario({
- db: createCrmDb({
- contacts: [
- buildContact({
- first_name: "Jane",
- id: 8,
- last_name: "Smith",
- nb_tasks: undefined,
- }),
- ] as any,
- }),
- });
-
- const screen = await render(
- <CrmTestProvider
- initialEntries={["/contacts/8/show"]}
- resource="contacts"
- scenario={scenario}
- >
- <MobileContactShowHarness />
- </CrmTestProvider>,
- );
-
- await expect
- .element(screen.getByRole("tab", { name: "0 tasks" }))
- .toBeVisible();
- await expect
- .poll(
- () => screen.container.textContent?.includes("%{smart_count}") ?? false,
- )
- .toBe(false);
- await expect
- .poll(() => screen.container.textContent?.includes("||||") ?? false)
- .toBe(false);
- });
-});
diff --git a/src/components/atomic-crm/contacts/ContactShow.mobile.stories.tsx b/src/components/atomic-crm/contacts/ContactShow.mobile.stories.tsx
new file mode 100644
index 00000000..772d8599
--- /dev/null
+++ b/src/components/atomic-crm/contacts/ContactShow.mobile.stories.tsx
@@ -0,0 +1,42 @@
+import type { Meta } from "@storybook/react-vite";
+import { ResourceContextProvider } from "ra-core";
+
+import { ContactShow } from "./ContactShow";
+
+import {
+ StoryWrapper,
+ buildContact,
+} from "@/test/browser/atomic-crm/crmUiHarness";
+
+const meta = {
+ title: "Atomic CRM/Contacts/Contact Show",
+ parameters: {
+ layout: "fullscreen",
+ },
+ globals: {
+ viewport: { value: "mobile1", isRotated: false },
+ },
+} satisfies Meta;
+
+export default meta;
+
+const successContacts = [
+ buildContact({
+ first_name: "Ada",
+ id: 1,
+ last_name: "Lovelace",
+ last_seen: "2025-01-05T10:00:00.000Z",
+ title: "CTO",
+ }),
+];
+
+export const MobileSuccess = () => (
+ <StoryWrapper
+ initialEntries={["/contacts/1/show"]}
+ data={{ contacts: successContacts }}
+ >
+ <ResourceContextProvider value="contacts">
+ <ContactShow />
+ </ResourceContextProvider>
+ </StoryWrapper>
+);
diff --git a/src/components/atomic-crm/contacts/ContactShow.stories.tsx b/src/components/atomic-crm/contacts/ContactShow.stories.tsx
new file mode 100644
index 00000000..9e3da388
--- /dev/null
+++ b/src/components/atomic-crm/contacts/ContactShow.stories.tsx
@@ -0,0 +1,39 @@
+import type { Meta } from "@storybook/react-vite";
+import { ResourceContextProvider } from "ra-core";
+
+import { ContactShow } from "./ContactShow";
+
+import {
+ StoryWrapper,
+ buildContact,
+} from "@/test/browser/atomic-crm/crmUiHarness";
+
+const meta = {
+ title: "Atomic CRM/Contacts/Contact Show",
+ parameters: {
+ layout: "fullscreen",
+ },
+} satisfies Meta;
+
+export default meta;
+
+const successContacts = [
+ buildContact({
+ first_name: "Ada",
+ id: 1,
+ last_name: "Lovelace",
+ last_seen: "2025-01-05T10:00:00.000Z",
+ title: "CTO",
+ }),
+];
+
+export const DesktopSuccess = () => (
+ <StoryWrapper
+ initialEntries={["/contacts/1/show"]}
+ data={{ contacts: successContacts }}
+ >
+ <ResourceContextProvider value="contacts">
+ <ContactShow />
+ </ResourceContextProvider>
+ </StoryWrapper>
+);
diff --git a/src/components/atomic-crm/contacts/ContactShow.test.tsx b/src/components/atomic-crm/contacts/ContactShow.test.tsx
new file mode 100644
index 00000000..00b571da
--- /dev/null
+++ b/src/components/atomic-crm/contacts/ContactShow.test.tsx
@@ -0,0 +1,25 @@
+import { describe, expect, it, vi } from "vitest";
+import { render } from "vitest-browser-react";
+import { MobileSuccess } from "./ContactShow.mobile.stories";
+
+vi.mock("@/hooks/use-mobile", () => ({
+ useIsMobile: () => true,
+}));
+
+describe("ContactShow", () => {
+ it("renders a safe zero-task label before nb_tasks is available", async () => {
+ const screen = await render(<MobileSuccess />);
+
+ await expect
+ .element(screen.getByRole("tab", { name: "0 tasks" }))
+ .toBeVisible();
+ await expect
+ .poll(
+ () => screen.container.textContent?.includes("%{smart_count}") ?? false,
+ )
+ .toBe(false);
+ await expect
+ .poll(() => screen.container.textContent?.includes("||||") ?? false)
+ .toBe(false);
+ });
+});
diff --git a/src/test/browser/atomic-crm/crmUiHarness.tsx b/src/test/browser/atomic-crm/crmUiHarness.tsx
index 7e56a583..c69a8e81 100644
--- a/src/test/browser/atomic-crm/crmUiHarness.tsx
+++ b/src/test/browser/atomic-crm/crmUiHarness.tsx
@@ -298,28 +298,32 @@ export const StoryWrapper = ({
children,
data,
dataProvider,
+ initialEntries,
}: {
children: ReactNode;
data?: Partial<Db>;
dataProvider?: Partial<ReturnType<typeof createDataProvider>>;
+ initialEntries?: string[];
}) => (
- <CRM
- authProvider={createTestAuthProvider()}
- dataProvider={{
- ...createDataProvider({ db: createCrmDb({ ...data }) }),
- ...dataProvider,
- }}
- i18nProvider={testI18nProvider}
- dashboard={() => <>{children}</>}
- store={memoryStore()}
- disableTelemetry
- layout={({ children }) => (
- <>
- {children}
- <Notification />
- </>
- )}
- />
+ <MemoryRouter initialEntries={initialEntries}>
+ <CRM
+ authProvider={createTestAuthProvider()}
+ dataProvider={{
+ ...createDataProvider({ db: createCrmDb({ ...data }) }),
+ ...dataProvider,
+ }}
+ i18nProvider={testI18nProvider}
+ dashboard={() => <>{children}</>}
+ store={memoryStore()}
+ disableTelemetry
+ layout={({ children }) => (
+ <>
+ {children}
+ <Notification />
+ </>
+ )}
+ />
+ </MemoryRouter>
);
export const DesktopContactListHarness = () => <ContactList />;
@@ -354,9 +358,3 @@ export const OpenTaskCreateSheetHarness = () => {
return <TaskCreateSheet open={open} onOpenChange={setOpen} />;
};
-
-export const MobileContactShowHarness = () => (
- <Routes>
- <Route path="/contacts/:id/show" element={<ContactShow />} />
- </Routes>
-);