Skip to content

A full-featured CRM built with React, shadcn/ui, and Supabase.

Feat: add docker in docker support for dev containers

Jonathan ARNAULT71882daaffb6
diff --git a/.claude/hooks/block-docker-containers.mjs b/.claude/hooks/block-docker-containers.mjs
new file mode 100755
index 00000000..66f91fe3
--- /dev/null
+++ b/.claude/hooks/block-docker-containers.mjs
@@ -0,0 +1,38 @@
+#!/usr/bin/env node
+// PreToolUse(Bash) — any caller. This dev container runs docker-in-docker; the
+// agent must not launch arbitrary containers. Block commands that create/run/start
+// a container (`docker run|create|start`, `docker compose up`, `docker-compose up`)
+// UNLESS they reference Supabase — the one stack the dev workflow is allowed to spin
+// up. Inspection/management verbs (ps, logs, stop, rm, exec, …) are never blocked.
+
+import { readFileSync } from "node:fs";
+import { createHookContext } from "./lib/context.mjs";
+
+const input = JSON.parse(readFileSync(0, "utf8"));
+const ctx = createHookContext(input, "block-docker-containers");
+
+const cmd = input.tool_input?.command || "";
+if (!cmd) process.exit(0);
+
+// A command that brings a container up: `docker [container] run|create|start`,
+// or compose `up` (both `docker compose up` and legacy `docker-compose up`).
+const launchesContainer = (c) =>
+ /\bdocker\s+(container\s+)?(run|create|start)\b/.test(c) ||
+ /\bdocker(-compose|\s+compose)\b[^\n]*\bup\b/.test(c);
+
+// The single allowed stack. Supabase's own CLI (`npx supabase start`) drives the
+// Docker daemon directly and never shells out `docker run`, so it is unaffected;
+// this exception covers the rare case of operating Supabase's containers by hand.
+const referencesSupabase = (c) => /supabase/i.test(c);
+
+if (launchesContainer(cmd) && !referencesSupabase(cmd)) {
+ ctx.block({
+ reason:
+ "Docker container launch blocked: this dev container only permits Supabase containers. " +
+ "`docker run|create|start` and `docker compose up` are disabled for non-Supabase images. " +
+ "Use `npx supabase start` / `make start` for the local stack.",
+ log: `cmd=${cmd.slice(0, 120)}`,
+ });
+}
+
+process.exit(0);
diff --git a/.claude/hooks/test/block-docker-containers.test.mjs b/.claude/hooks/test/block-docker-containers.test.mjs
new file mode 100644
index 00000000..574fdeb6
--- /dev/null
+++ b/.claude/hooks/test/block-docker-containers.test.mjs
@@ -0,0 +1,95 @@
+// Tests for block-docker-containers.mjs — blocks container launches (run/create/
+// start, compose up) for any caller including the main session, except when the
+// command references Supabase. Blocks are decision JSON on stdout with exit 0;
+// allowed commands produce no decision.
+
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
+import { spawnSync } from "node:child_process";
+import { afterAll, describe, test, expect } from "vitest";
+
+const HERE = dirname(fileURLToPath(import.meta.url));
+const HOOK = join(HERE, "..", "block-docker-containers.mjs");
+
+const tmpRoot = mkdtempSync(join(tmpdir(), "block-docker-tmp-"));
+
+afterAll(() => {
+ rmSync(tmpRoot, { recursive: true, force: true });
+});
+
+const runHook = (agent, command) => {
+ const env = { ...process.env, CRM_TMP_ROOT: tmpRoot };
+ delete env.CLAUDE_AGENT_NAME;
+ const input = JSON.stringify({
+ tool_name: "Bash",
+ agent_type: agent,
+ session_id: "test-1234",
+ tool_input: { command },
+ });
+ return spawnSync("node", [HOOK], { input, env, encoding: "utf8" });
+};
+
+const isBlocked = (r) => r.stdout.includes('"decision":"block"');
+
+describe("block-docker-containers hook", () => {
+ describe("container launches → blocked (any caller, incl. main session)", () => {
+ const blocked = [
+ ["", "docker run -it ubuntu bash"],
+ ["", "docker run -v /home:/host alpine"],
+ ["", "docker create nginx"],
+ ["", "docker start my-stopped-container"],
+ ["", "docker container run redis"],
+ ["", "docker compose up -d"],
+ ["", "docker-compose up"],
+ ["developer", "docker run hello-world"],
+ ["", "echo hi && docker run busybox"],
+ ];
+
+ test.each(blocked)("%s running '%s' → blocked", (agent, command) => {
+ const r = runHook(agent, command);
+ expect(r.status).toBe(0);
+ expect(isBlocked(r)).toBe(true);
+ });
+ });
+
+ describe("Supabase containers → allowed", () => {
+ const allowed = [
+ ["", "docker run supabase/postgres:15"],
+ ["", "docker start supabase_db_atomic-crm"],
+ ["", "docker compose -f supabase/docker-compose.yml up -d"],
+ ["", "npx supabase start"],
+ ["", "make start"],
+ ];
+
+ test.each(allowed)("%s running '%s' → allowed", (agent, command) => {
+ const r = runHook(agent, command);
+ expect(r.status).toBe(0);
+ expect(isBlocked(r)).toBe(false);
+ });
+ });
+
+ describe("non-launch docker verbs → allowed", () => {
+ const allowed = [
+ "docker ps",
+ "docker logs my-container",
+ "docker stop my-container",
+ "docker rm my-container",
+ "docker exec my-container ls",
+ "docker images",
+ "docker version",
+ ];
+
+ test.each(allowed)("'%s' → allowed", (command) => {
+ const r = runHook("", command);
+ expect(isBlocked(r)).toBe(false);
+ });
+ });
+
+ test("empty command → allowed", () => {
+ const r = runHook("", "");
+ expect(r.status).toBe(0);
+ expect(isBlocked(r)).toBe(false);
+ });
+});
diff --git a/.claude/settings.json b/.claude/settings.json
index 7338f9b7..f839084a 100644
--- a/.claude/settings.json
+++ b/.claude/settings.json
@@ -30,6 +30,10 @@
"type": "command",
"command": "$CLAUDE_PROJECT_DIR/.claude/hooks/bash-guard.mjs"
},
+ {
+ "type": "command",
+ "command": "$CLAUDE_PROJECT_DIR/.claude/hooks/block-docker-containers.mjs"
+ },
{
"type": "command",
"command": "$CLAUDE_PROJECT_DIR/.claude/hooks/circuit-breaker.mjs"
diff --git a/.devcontainer/claude-code/devcontainer-feature.json b/.devcontainer/claude-code/devcontainer-feature.json
index bfe2bf69..69dd8165 100644
--- a/.devcontainer/claude-code/devcontainer-feature.json
+++ b/.devcontainer/claude-code/devcontainer-feature.json
@@ -12,6 +12,11 @@
"type": "bind",
"source": "${localEnv:HOME}/.claude",
"target": "/home/node/.claude"
+ },
+ {
+ "type": "volume",
+ "source": "claude-plugins",
+ "target": "/home/node/.claude/plugins"
}
],
"customizations": {
diff --git a/.devcontainer/claude-code/install.sh b/.devcontainer/claude-code/install.sh
index 4ca54cab..b9224113 100755
--- a/.devcontainer/claude-code/install.sh
+++ b/.devcontainer/claude-code/install.sh
@@ -2,11 +2,18 @@
set -e
+CLAUDE_PATH="/home/${_CONTAINER_USER}/.claude"
+CLAUDE_PLUGINS_PATH="${CLAUDE_PATH}/plugins"
+
+mkdir -p "$CLAUDE_PLUGINS_PATH" && chown -R $_CONTAINER_USER:$_CONTAINER_USER "$CLAUDE_PATH"
+
su - "$_CONTAINER_USER" <<'EOL'
cd /tmp
curl -fsSL https://claude.ai/install.sh -o claude-install.sh
chmod +x claude-install.sh
./claude-install.sh
rm -f claude-install.sh
-echo 'export PATH="$HOME/.local/bin:$PATH"' >> /home/node/.bashrc
+echo 'export PATH="$HOME/.local/bin:$PATH"' >> ~/.bashrc
+
EOL
+
diff --git a/.devcontainer/devcontainer-lock.json b/.devcontainer/devcontainer-lock.json
index 26c6657b..1947ab79 100644
--- a/.devcontainer/devcontainer-lock.json
+++ b/.devcontainer/devcontainer-lock.json
@@ -1,5 +1,10 @@
{
"features": {
+ "ghcr.io/devcontainers/features/docker-in-docker:3": {
+ "version": "3.1.0",
+ "resolved": "ghcr.io/devcontainers/features/docker-in-docker@sha256:62e04ec83d944da4fd2830f68a677d1f5466c0654aea1e4baa30232d16029ac1",
+ "integrity": "sha256:62e04ec83d944da4fd2830f68a677d1f5466c0654aea1e4baa30232d16029ac1"
+ },
"ghcr.io/postfinance/devcontainer-features/playwright-deps:1": {
"version": "1.0.0",
"resolved": "ghcr.io/postfinance/devcontainer-features/playwright-deps@sha256:1fbd235678d55637ddfb93c800249e48ae72af36cb382297ff3a22bab8945acb",
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 064217fa..6f23248b 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -6,13 +6,17 @@
},
"workspaceFolder": "/workspaces/atomic-crm",
"workspaceMount": "source=${localWorkspaceFolder},target=${containerWorkspaceFolder},type=bind,consistency=cached",
+ "postCreateCommand": "bash .devcontainer/post-create.sh",
"remoteUser": "node",
"features": {
"./claude-code": {},
"./npm": {
"workspaceFolder": "${containerWorkspaceFolder}"
},
- "./playwright": {}
+ "./playwright": {},
+ "ghcr.io/devcontainers/features/docker-in-docker:3": {
+ "moby": false
+ }
},
"customizations": {
"vscode": {
diff --git a/.devcontainer/npm/devcontainer-feature.json b/.devcontainer/npm/devcontainer-feature.json
index 0d73c3b6..00940da5 100644
--- a/.devcontainer/npm/devcontainer-feature.json
+++ b/.devcontainer/npm/devcontainer-feature.json
@@ -15,6 +15,11 @@
"type": "volume",
"source": "${devcontainerId}-node-modules",
"target": "${containerWorkspaceFolder}/node_modules"
+ },
+ {
+ "type": "volume",
+ "source": "${devcontainerId}-global-node-modules",
+ "target": "/usr/local/lib/node_modules"
}
]
}
diff --git a/.devcontainer/npm/install.sh b/.devcontainer/npm/install.sh
index 453e6428..c9a01f92 100755
--- a/.devcontainer/npm/install.sh
+++ b/.devcontainer/npm/install.sh
@@ -12,3 +12,4 @@ fi
NODE_MODULES_PATH="${WORKSPACE_FOLDER}/node_modules"
mkdir -p "$NODE_MODULES_PATH" && chown -R $_CONTAINER_USER:$_CONTAINER_USER "$NODE_MODULES_PATH"
+mkdir -p "/usr/local/lib/node_modules"
diff --git a/.devcontainer/post-create.sh b/.devcontainer/post-create.sh
new file mode 100755
index 00000000..cf7fefbb
--- /dev/null
+++ b/.devcontainer/post-create.sh
@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+sudo npm install -g supabase