A full-featured CRM built with React, shadcn/ui, and Supabase.
Add unit test for the validateItemsInUse test
fzaninotto7d8b004c2292
diff --git a/src/components/atomic-crm/settings/SettingsPage.test.ts b/src/components/atomic-crm/settings/SettingsPage.test.tsnew file mode 100644index 00000000..93578f09--- /dev/null+++ b/src/components/atomic-crm/settings/SettingsPage.test.ts@@ -0,0 +1,94 @@+import { describe, it, expect } from "vitest";+import type { RaRecord } from "ra-core";+import { validateItemsInUse } from "./SettingsPage";++describe("validateItemsInUse", () => {+ const deals: RaRecord[] = [+ { id: 1, stage: "won", category: "ui-design" },+ { id: 2, stage: "lost", category: "copywriting" },+ { id: 3, stage: "opportunity", category: "ui-design" },+ ];++ it("returns undefined when items is undefined", () => {+ expect(validateItemsInUse(undefined, deals, "stage", "stages")).toBe(+ undefined,+ );+ });++ it("returns undefined when all in-use values are present", () => {+ const items = [+ { value: "won", label: "Won" },+ { value: "lost", label: "Lost" },+ { value: "opportunity", label: "Opportunity" },+ ];+ expect(validateItemsInUse(items, deals, "stage", "stages")).toBe(+ undefined,+ );+ });++ it("returns an error when an in-use value is removed", () => {+ const items = [+ { value: "won", label: "Won" },+ { value: "opportunity", label: "Opportunity" },+ ];+ expect(validateItemsInUse(items, deals, "stage", "stages")).toBe(+ "Cannot remove stages that are still used by deals: lost",+ );+ });++ it("lists all missing in-use values", () => {+ const items = [{ value: "opportunity", label: "Opportunity" }];+ const result = validateItemsInUse(items, deals, "stage", "stages");+ expect(result).toContain("won");+ expect(result).toContain("lost");+ });++ it("returns an error when there are duplicate slugs", () => {+ const items = [+ { value: "won", label: "Won" },+ { value: "won", label: "Won again" },+ { value: "lost", label: "Lost" },+ { value: "opportunity", label: "Opportunity" },+ ];+ expect(validateItemsInUse(items, deals, "stage", "stages")).toBe(+ "Duplicate stages: won",+ );+ });++ it("detects duplicates via slug fallback when value is empty", () => {+ const items = [+ { value: "", label: "Won" },+ { value: "won", label: "Already won" },+ { value: "lost", label: "Lost" },+ { value: "opportunity", label: "Opportunity" },+ ];+ expect(validateItemsInUse(items, deals, "stage", "stages")).toBe(+ "Duplicate stages: won",+ );+ });++ it("returns 'Validating…' when deals have not loaded yet", () => {+ const items = [{ value: "won", label: "Won" }];+ expect(validateItemsInUse(items, undefined, "stage", "stages")).toBe(+ "Validating…",+ );+ });++ it("ignores deals with a falsy value for the checked field", () => {+ const dealsWithEmpty: RaRecord[] = [+ { id: 1, stage: "won", category: "" },+ { id: 2, stage: "won", category: null },+ ];+ const items = [{ value: "other", label: "Other" }];+ expect(+ validateItemsInUse(items, dealsWithEmpty, "category", "categories"),+ ).toBe(undefined);+ });++ it("works with the category field", () => {+ const items = [{ value: "ui-design", label: "UI Design" }];+ expect(+ validateItemsInUse(items, deals, "category", "categories"),+ ).toContain("copywriting");+ });+});diff --git a/src/components/atomic-crm/settings/SettingsPage.tsx b/src/components/atomic-crm/settings/SettingsPage.tsxindex b00fa223..fde8a761 100644--- a/src/components/atomic-crm/settings/SettingsPage.tsx+++ b/src/components/atomic-crm/settings/SettingsPage.tsx@@ -36,7 +36,7 @@ const ensureValues = (items: { value?: string; label: string }[] | undefined) =>* Also rejects duplicate slug values.* Returns undefined if valid, or an error message string.*/-const validateItemsInUse = (+export const validateItemsInUse = (items: { value: string; label: string }[] | undefined,deals: RaRecord[] | undefined,fieldName: string,