Skip to content

A full-featured CRM built with React, shadcn/ui, and Supabase.

code review

ThieryMichel87568cb42518
diff --git a/src/components/atomic-crm/contacts/ContactCreate.integration.test.tsx b/src/components/atomic-crm/contacts/ContactCreate.integration.test.tsx
index 8c289118..1b7a93dd 100644
--- a/src/components/atomic-crm/contacts/ContactCreate.integration.test.tsx
+++ b/src/components/atomic-crm/contacts/ContactCreate.integration.test.tsx
@@ -1,11 +1,16 @@
import { render } from "vitest-browser-react";
import {
- ContactCreateHarness,
createCrmDb,
createCrmScenario,
CrmTestProvider,
} from "@/test/browser/atomic-crm/crmUiHarness";
+import { ContactCreate } from "./ContactCreate";
+
+// We use pessimistic mode to avoid the 5s undoable delay in tests.
+export const ContactCreateHarness = () => (
+ <ContactCreate mutationMode="pessimistic" />
+);
/**
* Create a scenario whose dataProvider.create is wrapped in a vi.fn(),
diff --git a/src/components/atomic-crm/contacts/ContactEdit.integration.test.tsx b/src/components/atomic-crm/contacts/ContactEdit.integration.test.tsx
index c7671bce..44ec5ddc 100644
--- a/src/components/atomic-crm/contacts/ContactEdit.integration.test.tsx
+++ b/src/components/atomic-crm/contacts/ContactEdit.integration.test.tsx
@@ -2,11 +2,23 @@ import { render } from "vitest-browser-react";
import {
buildContact,
- ContactEditHarness,
createCrmDb,
createCrmScenario,
CrmTestProvider,
} from "@/test/browser/atomic-crm/crmUiHarness";
+import { Route, Routes } from "react-router";
+import { ContactEdit } from "./ContactEdit";
+
+// EditBase reads the record id from the route params, so we mount a Route.
+// We use pessimistic mode to avoid the 5s undoable delay in tests.
+export const ContactEditHarness = () => (
+ <Routes>
+ <Route
+ path="/contacts/:id"
+ element={<ContactEdit mutationMode="pessimistic" />}
+ />
+ </Routes>
+);
/**
* Create a scenario whose dataProvider.update is wrapped in a vi.fn(),