Skip to content

A full-featured CRM built with React, shadcn/ui, and Supabase.

fix the last e2e test

erwanMarmelab8f5fa04d9c8d
diff --git a/e2e/adminAccountManagerFilter.spec.ts b/e2e/adminAccountManagerFilter.spec.ts
index 092013d7..22ce164b 100644
--- a/e2e/adminAccountManagerFilter.spec.ts
+++ b/e2e/adminAccountManagerFilter.spec.ts
@@ -49,7 +49,7 @@ test.describe("admin filtering by account manager", () => {
await page.getByLabel("Password").fill("password");
await page.getByRole("button", { name: "Sign in" }).click();
- await menu.goToContacts({ isMobile });
+ await menu.goToContacts();
await expect(page.getByText("Ada Lovelace")).toBeVisible();
await expect(page.getByText("Grace Hopper")).toBeVisible();
@@ -86,7 +86,7 @@ test.describe("admin filtering by account manager", () => {
await page.getByLabel("Password").fill("password");
await page.getByRole("button", { name: "Sign in" }).click();
- await menu.goToContacts({ isMobile });
+ await menu.goToContacts();
await expect(page.getByText("Grace Hopper")).toBeVisible();
if (isMobile) {
diff --git a/e2e/bulkContactTags.spec.ts b/e2e/bulkContactTags.spec.ts
index a3aeac12..02c5c934 100644
--- a/e2e/bulkContactTags.spec.ts
+++ b/e2e/bulkContactTags.spec.ts
@@ -39,7 +39,7 @@ test("user adds a tag to several contacts", async ({
await expect(page).toHaveTitle(/Atomic CRM/);
await expect(page.getByRole("link", { name: "Contacts" })).toBeVisible();
- await menu.goToContacts({ isMobile });
+ await menu.goToContacts();
await expect(page.getByText("Ada Lovelace")).toBeVisible();
await expect(page.getByText("Grace Hopper")).toBeVisible();
diff --git a/e2e/fixtures.ts b/e2e/fixtures.ts
index b6e580fa..4197b69e 100644
--- a/e2e/fixtures.ts
+++ b/e2e/fixtures.ts
@@ -195,12 +195,20 @@ async function createContact({
return data;
}
-const getMenuMethod = ({ page }: { page: Page; isMobile: boolean }) => ({
+const getMenuMethod = ({
+ page,
+ isMobile,
+}: {
+ page: Page;
+ isMobile: boolean;
+}) => ({
goToDashboard: async () => {
- await page.getByRole("link", { name: "Dashboard" }).click();
+ await page
+ .getByRole(isMobile ? "button" : "link", { name: "Dashboard" })
+ .click();
await page.waitForLoadState("networkidle");
},
- goToContacts: async ({ isMobile }: { isMobile: boolean }) => {
+ goToContacts: async () => {
await page
.getByRole(isMobile ? "button" : "link", { name: "Contacts" })
.click();
diff --git a/e2e/userAddingATask.spec.ts b/e2e/userAddingATask.spec.ts
index f3f2737f..70a9ff86 100644
--- a/e2e/userAddingATask.spec.ts
+++ b/e2e/userAddingATask.spec.ts
@@ -48,7 +48,7 @@ test.describe("user adding a task", () => {
await expect(page).toHaveTitle(/Atomic CRM/);
await expect(page.getByText("Latest Activity")).toBeVisible();
- await menu.goToContacts({ isMobile });
+ await menu.goToContacts();
await page.waitForLoadState("networkidle");
await page.getByText("Jane Smith").click();
diff --git a/src/components/atomic-crm/misc/CreateSheet.tsx b/src/components/atomic-crm/misc/CreateSheet.tsx
index 58e1bc2e..4f64669b 100644
--- a/src/components/atomic-crm/misc/CreateSheet.tsx
+++ b/src/components/atomic-crm/misc/CreateSheet.tsx
@@ -126,7 +126,7 @@ export const CreateSheet = ({
<Sheet open={open} onOpenChange={onOpenChange}>
<SheetContent
side="bottom"
- className="h-dvh flex flex-col"
+ className="data-[side=bottom]:h-dvh flex flex-col"
aria-describedby={undefined}
>
<CreateBase
diff --git a/src/components/atomic-crm/misc/EditSheet.tsx b/src/components/atomic-crm/misc/EditSheet.tsx
index d990ecf6..307ad8b2 100644
--- a/src/components/atomic-crm/misc/EditSheet.tsx
+++ b/src/components/atomic-crm/misc/EditSheet.tsx
@@ -129,7 +129,7 @@ export const EditSheet = ({
<Sheet open={open} onOpenChange={onOpenChange}>
<SheetContent
side="bottom"
- className="h-dvh flex flex-col"
+ className="data-[side=bottom]:h-dvh flex flex-col"
aria-describedby={undefined}
>
<EditBase
diff --git a/src/components/atomic-crm/misc/ResponsiveFilters.tsx b/src/components/atomic-crm/misc/ResponsiveFilters.tsx
index bf833617..32b9686c 100644
--- a/src/components/atomic-crm/misc/ResponsiveFilters.tsx
+++ b/src/components/atomic-crm/misc/ResponsiveFilters.tsx
@@ -77,7 +77,10 @@ export const ResponsiveFilters = ({
</Badge>
)}
</SheetTrigger>
- <SheetContent side="bottom" className="h-dvh p-4 flex flex-col">
+ <SheetContent
+ side="bottom"
+ className="data-[side=bottom]:h-dvh p-4 flex flex-col"
+ >
<SheetHeader className="-p-4">
<SheetTitle>
<h1 className="text-xl font-semibold">