Skip to content

A full-featured CRM built with React, shadcn/ui, and Supabase.

refactor: rename contactId prop to filterByContact in TasksListFilter component

Jean-Baptiste Kaiserdccbfbf88b16
diff --git a/src/components/atomic-crm/contacts/ContactTasksList.tsx b/src/components/atomic-crm/contacts/ContactTasksList.tsx
index f24aed7d..63531f94 100644
--- a/src/components/atomic-crm/contacts/ContactTasksList.tsx
+++ b/src/components/atomic-crm/contacts/ContactTasksList.tsx
@@ -47,29 +47,29 @@ export const ContactTasksList = () => {
<TasksListFilter
title="Overdue"
filter={taskFilters.overdue}
- contactId={record.id}
+ filterByContact={record.id}
/>
<TasksListFilter
title="Today"
filter={taskFilters.today}
- contactId={record.id}
+ filterByContact={record.id}
/>
<TasksListFilter
title="Tomorrow"
filter={taskFilters.tomorrow}
- contactId={record.id}
+ filterByContact={record.id}
/>
{isBeforeFriday && (
<TasksListFilter
title="This week"
filter={taskFilters.thisWeek}
- contactId={record.id}
+ filterByContact={record.id}
/>
)}
<TasksListFilter
title="Later"
filter={taskFilters.later}
- contactId={record.id}
+ filterByContact={record.id}
/>
</div>
);
diff --git a/src/components/atomic-crm/dashboard/TasksListFilter.tsx b/src/components/atomic-crm/dashboard/TasksListFilter.tsx
index 219fa046..838a67aa 100644
--- a/src/components/atomic-crm/dashboard/TasksListFilter.tsx
+++ b/src/components/atomic-crm/dashboard/TasksListFilter.tsx
@@ -12,11 +12,11 @@ import { TasksIterator } from "../tasks/TasksIterator";
export const TasksListFilter = ({
title,
filter,
- contactId,
+ filterByContact,
}: {
title: string;
filter: any;
- contactId?: Identifier;
+ filterByContact?: Identifier;
}) => {
const { identity } = useGetIdentity();
@@ -31,12 +31,12 @@ export const TasksListFilter = ({
sort: { field: "due_date", order: "ASC" },
filter: {
...filter,
- ...(contactId != null
- ? { contact_id: contactId }
+ ...(filterByContact != null
+ ? { contact_id: filterByContact }
: { sales_id: identity?.id }),
},
},
- { enabled: contactId != null ? true : !!identity },
+ { enabled: filterByContact != null ? true : !!identity },
);
const listContext = useList({
@@ -55,7 +55,7 @@ export const TasksListFilter = ({
</p>
<ResourceContextProvider value="tasks">
<ListContextProvider value={listContext}>
- <TasksIterator showContact={contactId == null} />
+ <TasksIterator showContact={filterByContact == null} />
</ListContextProvider>
</ResourceContextProvider>
{total > listContext.perPage && (