Skip to content

A full-featured CRM built with React, shadcn/ui, and Supabase.

add integration tests on ContactCreate

ThieryMichelef52fda83db7
diff --git a/src/components/atomic-crm/contacts/ContactCreate.integration.test.tsx b/src/components/atomic-crm/contacts/ContactCreate.integration.test.tsx
new file mode 100644
index 00000000..8c289118
--- /dev/null
+++ b/src/components/atomic-crm/contacts/ContactCreate.integration.test.tsx
@@ -0,0 +1,152 @@
+import { render } from "vitest-browser-react";
+
+import {
+ ContactCreateHarness,
+ createCrmDb,
+ createCrmScenario,
+ CrmTestProvider,
+} from "@/test/browser/atomic-crm/crmUiHarness";
+
+/**
+ * Create a scenario whose dataProvider.create is wrapped in a vi.fn(),
+ * so we can assert on what data the transform sends to the backend.
+ */
+const createScenarioWithCreateMock = (
+ ...args: Parameters<typeof createCrmScenario>
+) => {
+ const scenario = createCrmScenario(...args);
+ const originalCreate = scenario.dataProvider.create;
+ const createMock = vi.fn(
+ async (...createArgs: Parameters<typeof originalCreate>) =>
+ originalCreate(...createArgs),
+ );
+ scenario.dataProvider = { ...scenario.dataProvider, create: createMock };
+ return { scenario, createMock };
+};
+
+describe("ContactCreate integration", () => {
+ it("shows empty email and phone placeholder inputs", async () => {
+ const scenario = createCrmScenario({ db: createCrmDb() });
+
+ const screen = await render(
+ <CrmTestProvider
+ scenario={scenario}
+ resource="contacts"
+ initialEntries={["/contacts/create"]}
+ >
+ <ContactCreateHarness />
+ </CrmTestProvider>,
+ );
+
+ await expect.element(screen.getByPlaceholder("Email")).toBeInTheDocument();
+ await expect
+ .element(screen.getByPlaceholder("Phone number"))
+ .toBeInTheDocument();
+ });
+
+ it("does not submit empty email and phone entries", async () => {
+ const { scenario, createMock } = createScenarioWithCreateMock({
+ db: createCrmDb(),
+ });
+
+ const screen = await render(
+ <CrmTestProvider
+ scenario={scenario}
+ resource="contacts"
+ initialEntries={["/contacts/create"]}
+ >
+ <ContactCreateHarness />
+ </CrmTestProvider>,
+ );
+
+ await expect.element(screen.getByPlaceholder("Email")).toBeInTheDocument();
+
+ // Fill required fields only
+ await screen.getByLabelText(/first name/i).fill("Ada");
+ await screen.getByLabelText(/last name/i).fill("Lovelace");
+
+ await screen.getByRole("button", { name: /^save$/i }).click();
+
+ await expect.poll(() => createMock.mock.calls.length).toBe(1);
+
+ const createData = createMock.mock.calls[0][1].data;
+ expect(createData.email_jsonb).toBeNull();
+ expect(createData.phone_jsonb).toBeNull();
+ expect(createData.first_seen).toBeDefined();
+ expect(createData.last_seen).toBeDefined();
+ expect(createData.tags).toEqual([]);
+ });
+
+ it("submits only filled email and phone entries, stripping empty ones", async () => {
+ const { scenario, createMock } = createScenarioWithCreateMock({
+ db: createCrmDb(),
+ });
+
+ const screen = await render(
+ <CrmTestProvider
+ scenario={scenario}
+ resource="contacts"
+ initialEntries={["/contacts/create"]}
+ >
+ <ContactCreateHarness />
+ </CrmTestProvider>,
+ );
+
+ await expect.element(screen.getByPlaceholder("Email")).toBeInTheDocument();
+
+ // Fill required fields
+ await screen.getByLabelText(/first name/i).fill("Ada");
+ await screen.getByLabelText(/last name/i).fill("Lovelace");
+
+ // Fill email but leave phone empty
+ await screen.getByPlaceholder("Email").fill("[email protected]");
+
+ await screen.getByRole("button", { name: /^save$/i }).click();
+
+ await expect.poll(() => createMock.mock.calls.length).toBe(1);
+
+ const createData = createMock.mock.calls[0][1].data;
+ expect(createData.email_jsonb).toEqual([
+ { email: "[email protected]", type: "Work" },
+ ]);
+ expect(createData.phone_jsonb).toBeNull();
+ });
+
+ it("submits both email and phone when filled", async () => {
+ const { scenario, createMock } = createScenarioWithCreateMock({
+ db: createCrmDb(),
+ });
+
+ const screen = await render(
+ <CrmTestProvider
+ scenario={scenario}
+ resource="contacts"
+ initialEntries={["/contacts/create"]}
+ >
+ <ContactCreateHarness />
+ </CrmTestProvider>,
+ );
+
+ await expect.element(screen.getByPlaceholder("Email")).toBeInTheDocument();
+
+ // Fill required fields
+ await screen.getByLabelText(/first name/i).fill("Ada");
+ await screen.getByLabelText(/last name/i).fill("Lovelace");
+
+ // Fill both email and phone
+ await screen.getByPlaceholder("Email").fill("[email protected]");
+ await screen.getByPlaceholder("Phone number").fill("+1234567890");
+
+ await screen.getByRole("button", { name: /^save$/i }).click();
+
+ await expect.poll(() => createMock.mock.calls.length).toBe(1);
+
+ const createData = createMock.mock.calls[0][1].data;
+ expect(createData.email_jsonb).toEqual([
+ { email: "[email protected]", type: "Work" },
+ ]);
+ expect(createData.phone_jsonb).toEqual([
+ { number: "+1234567890", type: "Work" },
+ ]);
+ });
+});
diff --git a/src/components/atomic-crm/contacts/ContactCreate.tsx b/src/components/atomic-crm/contacts/ContactCreate.tsx
index 056aab71..cdc8e1a4 100644
--- a/src/components/atomic-crm/contacts/ContactCreate.tsx
+++ b/src/components/atomic-crm/contacts/ContactCreate.tsx
@@ -1,22 +1,34 @@
-import { CreateBase, Form, useGetIdentity } from "ra-core";
+import { CreateBase, Form, useGetIdentity, type MutationMode } from "ra-core";
import { Card, CardContent } from "@/components/ui/card";
import { ContactInputs } from "./ContactInputs";
import { FormToolbar } from "../layout/FormToolbar";
-import { cleanupContactForCreate, defaultEmailJsonb } from "./cleanupContact";
+import {
+ cleanupContactForCreate,
+ defaultEmailJsonb,
+ defaultPhoneJsonb,
+} from "./cleanupContact";
-export const ContactCreate = () => {
+export const ContactCreate = ({
+ mutationMode,
+}: {
+ mutationMode?: MutationMode;
+}) => {
const { identity } = useGetIdentity();
return (
- <CreateBase redirect="show" transform={cleanupContactForCreate}>
+ <CreateBase
+ redirect="show"
+ transform={cleanupContactForCreate}
+ mutationMode={mutationMode}
+ >
<div className="mt-2 flex lg:mr-72">
<div className="flex-1">
<Form
defaultValues={{
sales_id: identity?.id,
email_jsonb: defaultEmailJsonb,
- phone_jsonb: defaultEmailJsonb,
+ phone_jsonb: defaultPhoneJsonb,
}}
>
<Card>