A programming framework for agentic AI
Add missing model context attribute (#4848)
Leon De Andrade23dbb6a63223
diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.pyindex 9be3adcdc..3b92a4a51 100644--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py+++ b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py@@ -296,7 +296,9 @@ class AssistantAgent(BaseChatAgent):raise ValueError(f"Handoff names must be unique from tool names. Handoff names: {handoff_tool_names}; tool names: {tool_names}")- if not model_context:+ if model_context is not None:+ self._model_context = model_context+ else:self._model_context = UnboundedChatCompletionContext()self._reflect_on_tool_use = reflect_on_tool_useself._tool_call_summary_format = tool_call_summary_formatdiff --git a/python/packages/autogen-agentchat/tests/test_assistant_agent.py b/python/packages/autogen-agentchat/tests/test_assistant_agent.pyindex 9065d5139..48f51c471 100644--- a/python/packages/autogen-agentchat/tests/test_assistant_agent.py+++ b/python/packages/autogen-agentchat/tests/test_assistant_agent.py@@ -17,6 +17,8 @@ from autogen_agentchat.messages import (ToolCallSummaryMessage,)from autogen_core import Image+from autogen_core.model_context import BufferedChatCompletionContext+from autogen_core.models import LLMMessagefrom autogen_core.tools import FunctionToolfrom autogen_ext.models.openai import OpenAIChatCompletionClientfrom openai.resources.chat.completions import AsyncCompletions@@ -39,10 +41,12 @@ class _MockChatCompletion:def __init__(self, chat_completions: List[ChatCompletion]) -> None:self._saved_chat_completions = chat_completionsself.curr_index = 0+ self.calls: List[List[LLMMessage]] = []async def mock_create(self, *args: Any, **kwargs: Any) -> ChatCompletion | AsyncGenerator[ChatCompletionChunk, None]:+ self.calls.append(kwargs["messages"]) # Save the callawait asyncio.sleep(0.1)completion = self._saved_chat_completions[self.curr_index]self.curr_index += 1@@ -468,3 +472,43 @@ async def test_list_chat_messages(monkeypatch: pytest.MonkeyPatch) -> None:else:assert message == result.messages[index]index += 1+++async def test_model_context(monkeypatch: pytest.MonkeyPatch) -> None:+ model = "gpt-4o-2024-05-13"+ chat_completions = [+ ChatCompletion(+ id="id1",+ choices=[+ Choice(+ finish_reason="stop",+ index=0,+ message=ChatCompletionMessage(content="Response to message 3", role="assistant"),+ )+ ],+ created=0,+ model=model,+ object="chat.completion",+ usage=CompletionUsage(prompt_tokens=10, completion_tokens=5, total_tokens=15),+ ),+ ]+ mock = _MockChatCompletion(chat_completions)+ monkeypatch.setattr(AsyncCompletions, "create", mock.mock_create)+ model_context = BufferedChatCompletionContext(buffer_size=2)+ agent = AssistantAgent(+ "test_agent",+ model_client=OpenAIChatCompletionClient(model=model, api_key=""),+ model_context=model_context,+ )++ messages = [+ TextMessage(content="Message 1", source="user"),+ TextMessage(content="Message 2", source="user"),+ TextMessage(content="Message 3", source="user"),+ ]+ await agent.run(task=messages)++ # Check if the mock client is called with only the last two messages.+ assert len(mock.calls) == 1+ assert len(mock.calls[0]) == 3 # 2 message from the context + 1 system message