Skip to content

A programming framework for agentic AI

Fix typos and optimize OrTerminationCondition (#5980)

湛露先生770bf2357a97
diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.py
index ccd57ed21..870a620c4 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.py
+++ b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.py
@@ -152,7 +152,7 @@ class CodeExecutorAgent(BaseChatAgent, Component[CodeExecutorAgentConfig]):
)
async def on_reset(self, cancellation_token: CancellationToken) -> None:
- """It it's a no-op as the code executor agent has no mutable state."""
+ """Its a no-op as the code executor agent has no mutable state."""
pass
def _extract_markdown_code_blocks(self, markdown_text: str) -> List[CodeBlock]:
diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/base/_termination.py b/python/packages/autogen-agentchat/src/autogen_agentchat/base/_termination.py
index a0187d355..5dd720c51 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/base/_termination.py
+++ b/python/packages/autogen-agentchat/src/autogen_agentchat/base/_termination.py
@@ -157,9 +157,10 @@ class OrTerminationCondition(TerminationCondition, Component[OrTerminationCondit
if self.terminated:
raise RuntimeError("Termination condition has already been reached")
stop_messages = await asyncio.gather(*[condition(messages) for condition in self._conditions])
- if any(stop_message is not None for stop_message in stop_messages):
- content = ", ".join(stop_message.content for stop_message in stop_messages if stop_message is not None)
- source = ", ".join(stop_message.source for stop_message in stop_messages if stop_message is not None)
+ stop_messages_filter = [stop_message for stop_message in stop_messages if stop_message is not None]
+ if len(stop_messages_filter) > 0:
+ content = ", ".join(stop_message.content for stop_message in stop_messages_filter)
+ source = ", ".join(stop_message.source for stop_message in stop_messages_filter)
return StopMessage(content=content, source=source)
return None