Make your computer a home for your AI partner. Avibe is the local-first Agent OS: Vibey, its built-in AI partner, works out of the box, and Claude Code, Codex & OpenCode run unchanged beside it — reach them from your browser, phone, or any chat app.
Python agentagent-osaiai-agentsai-partnerchatopsclaudeclaude-codecodexdevtoolsdiscord-botlark-botllmlocal-firstlong-term-memoryopencodeslack-botvibe-codingvibeywechat
test(guidance): pin the rewritten PR delivery skill's durable contracts (#2788)
Call White04b844338547
diff --git a/tests/test_harness_skill_guidance.py b/tests/test_harness_skill_guidance.pyindex d8d12e77e..a650e47f4 100644--- a/tests/test_harness_skill_guidance.py+++ b/tests/test_harness_skill_guidance.py@@ -244,30 +244,21 @@ def test_pr_delivery_loop_keeps_optional_references_out_of_routine_loading() ->directory = ROOT / ".agents/skills/pr-delivery-loop"body = (directory / "SKILL.md").read_text()flat = " ".join(body.split())- references = re.findall(r"\]\((references/[^)]+\.md)\)", body)-- assert references == ["references/rationale.md", "references/local-regression.md"]- assert {path.relative_to(directory).as_posix() for path in directory.rglob("*.md")} == {- "SKILL.md", *references,- }- assert "are optional reading" in flat and "do not load them routinely" in flat- assert "They introduce no additional delivery gates." in flat- assert "sync the **whole maintained package**, including references, byte-for-byte" in flat- assert "Keep exact head-bound evidence in the internal gate record" in flat- assert "residual issues (or none known)" in flat- assert "gate-state dumps belong in the evidence" in flat- assert "offer Merge with the PR link" in flat- assert "persist the target PR and exact offered head" in flat- assert "visible report may omit the SHA" in flat+ named = re.findall(r"references/[\w.-]+\.md", body)++ # A reference is read only at the step that names it: local regression after the+ # user picks a regression update, never in the routine delivery loop.+ assert named == ["references/local-regression.md"]+ assert (directory / named[0]).is_file()+ assert "After the user chooses one, read `references/local-regression.md` before acting." in flat+ assert "synchronize the entire maintained package, including `references/`, byte-for-byte" in flatskill = parse_skill_file(directory / "SKILL.md", priority=(1, 0, 1))assert skill is not Nonerendered = render_skill_content(skill)- assert "## 4. Complete delivery" in rendered- assert "### Authorized local regression updates" in rendered- for reference_path in references:- reference = (directory / reference_path).read_text()- assert reference not in rendered+ assert "## Keep one Watch on the PR" in rendered+ for reference in (directory / "references").glob("*.md"):+ assert reference.read_text() not in rendereddef test_quick_replies_are_action_driven_not_mandatory() -> None:diff --git a/tests/test_repository_guidance.py b/tests/test_repository_guidance.pyindex d46a88de8..57275ee5d 100644--- a/tests/test_repository_guidance.py+++ b/tests/test_repository_guidance.py@@ -15,41 +15,29 @@ def test_pr_delivery_loop_delegates_waiters_to_background_watch_skill() -> None:flat = " ".join(body.split())agents = (ROOT / "AGENTS.md").read_text()- assert "`background-watch-hook` owns managed waits, waiter scripts, cursor mechanics" in flat- assert "Load that skill before a managed wait." in flat- assert "do not vendor or reimplement it in a repository" in flat+ # `background-watch-hook` owns the Watch's mechanics; this skill keeps only the principle.+ assert "The `background-watch-hook` skill owns Watch mechanics" in flat+ assert "Load it before a managed wait." in flatassert ".agents/skills/pr-delivery-loop/scripts/" not in bodyassert not (ROOT / ".agents/skills/pr-delivery-loop/scripts").exists()assert not (ROOT / ".agents/skills/pr-delivery-loop/tests").exists()+ assert (ROOT / "skills/background-watch-hook/scripts/wait_pr.py").is_file()+ assert (ROOT / "skills/background-watch-hook/scripts/wait_action.py").is_file()+ # One Watch per PR and owner lives through delivery, and its cursor is never reset.+ assert "one persistent Watch per PR and owner" in flat+ assert "Do not rebuild it or reset its cursor between rounds" in flatassert "the `pr-delivery-loop` skill for every implementation task" in agentsassert "use the `background-watch-hook` skill" in agentsassert "one durable `--forever` combined PR/CI Watch" in agents- assert "one durable combined PR + CI Watch per owner/concern" in flat- assert "`wait_pr.py`, `--forever`, required `--workflow` names" in flat- assert "no fixed `--sha` during a normal delivery loop" in flat- assert "Set `--timeout 0` on both supervisor and waiter; do not impose a lifetime cap." in flatassert "disable the Watch's per-cycle timeout" in agents- assert "Never reseed, rotate, or replace the cursor between rounds." in flat- assert "never use `--forever`" not in body- # Gate on captured head-bound evidence, not the reaction's persistent level.- assert "A Codex `+1` **on the PR body** is a pass only when the original durable Watch" in flat- assert "captured it as new after the current head epoch began" in flat- assert "the prior-head review was already terminal, and the head is unchanged" in flat- assert "If the timeline cannot bind it, trigger review on the unchanged head" in flat- assert "require a SHA-bearing verdict" in flat- assert "`Codex Review: Didn't find any major issues` and name the current reviewed SHA" in flat- assert "`Reviewed commit` alone is not a pass; findings reviews use it too." in flat- # The bot quotes `@codex review` in its own boilerplate, so a body-text search- # for the trigger matches the verdicts it is supposed to be distinguished from.- assert "Save the trigger comment ID returned by your own write and read it back." in flat- assert "Never select the last comment or search bodies for the trigger text." in flat- # Only the *passing* auto-review is reaction-only. Broadening that to every- # auto-review tells an agent to ignore a findings review and keep waiting on- # a reaction that will never describe it.- assert "Act on auto-review findings as inline reviews." in flat- assert "A clean auto-review may pass only through the PR-body reaction" in flat- assert "trigger review when a SHA-bearing pass comment is needed" in flat- assert "rather than waiting for one to appear automatically" in flat- assert (ROOT / "skills/background-watch-hook/scripts/wait_pr.py").is_file()- assert (ROOT / "skills/background-watch-hook/scripts/wait_action.py").is_file()+ # The skill owns the procedure but cannot weaken the root baseline, merge authority included.+ assert "cannot weaken the baseline below" in " ".join(agents.split())+ assert "never merge without explicit owner instruction" in " ".join(agents.split())++ # A Codex pass binds to the current head: a comment naming its SHA, or a PR-body+ # `+1` the Watch saw arrive after it was pushed. `Reviewed commit` is on findings too.+ assert "`Codex Review: Didn't find any major issues` and naming the current SHA" in flat+ assert "a `+1` reaction on the PR body that the Watch definitely observed as new after this head was pushed" in flat+ assert "require a SHA-bearing conclusion" in flat+ assert "also contains `Reviewed commit`; that alone is not a pass" in flat