Make your computer a home for your AI partner. Avibe is the local-first Agent OS: Vibey, its built-in AI partner, works out of the box, and Claude Code, Codex & OpenCode run unchanged beside it — reach them from your browser, phone, or any chat app.
Python agentagent-osaiai-agentsai-partnerchatopsclaudeclaude-codecodexdevtoolsdiscord-botlark-botllmlocal-firstlong-term-memoryopencodeslack-botvibe-codingvibeywechat
fix(show-runtime): preserve desktop node paths (#2597)
Max1b6c1d754548
diff --git a/core/show_runtime.py b/core/show_runtime.pyindex 8def23223..8f57c7d55 100644--- a/core/show_runtime.py+++ b/core/show_runtime.py@@ -4676,7 +4676,8 @@ def _resolve_node_command() -> list[str] | None:configured = os.environ.get("VIBE_SHOW_RUNTIME_NODE_BIN")try:if configured:- return _resolve_command(configured)+ resolved = _resolve_executable_path(Path(configured))+ return [resolved] if resolved else Nonereturn _resolve_command("node")except (OSError, ValueError):return Nonediff --git a/docs/plans/desktop-executable-paths.md b/docs/plans/desktop-executable-paths.mdnew file mode 100644index 000000000..517d2c805--- /dev/null+++ b/docs/plans/desktop-executable-paths.md@@ -0,0 +1,87 @@+# Desktop executable path handling++Owner: production delivery session `sesmcz3kd4ew2`.+Base: `origin/master` at `3f1c551b4` (2026-10-14).+Classification: small production-safe fix; one serial implementation lane.++## Outcome and contract++A desktop-provided executable path reaches subprocess execution intact, including+spaces and Windows backslashes. Show Pages must resolve the bundled Node executable+under macOS Application Support without a shim. Preserve established command-with-+arguments behavior only where repository callers/documentation establish it.++Audit launcher and runtime-bundle environment producers and Python consumers,+including Node, npm CLI, runtime/backends roots, other executable environment values,+and command parsing helpers. Fix demonstrated defects at their shared owning boundary;+do not rewrite unrelated backend command infrastructure. Invalid configured paths+must not accidentally execute a valid space-delimited prefix. Keep existing fallback+semantics unless the audit establishes a necessary change. A more precise diagnostic+is optional if it stays small and compatible.++## Audit++- `desktop/runtime-host/src/launcher.rs` and+ `desktop/scripts/build-runtime-bundle.py` publish Node, npm, Runtime, and backend+ locations as raw filesystem paths. `vibe/restart_supervisor.py` carries those+ values through a desktop restart without parsing them.+- `vibe/desktop_runtime.py` already consumes all four values as `Path` objects,+ confines immutable files to the Runtime root, verifies Node is executable, and+ keeps the mutable backend root outside the Runtime root. `vibe/desktop_backends.py`+ launches Node and the npm CLI as separate argv entries, so spaces and backslashes+ remain data.+- Runtime and backend roots are directory values and never enter command parsing.+ The npm CLI is a script path passed after the separately validated Node executable.+ These paths need no code change.+- `core/show_runtime.py` is the only defective consumer: it sends the+ launcher-supplied `VIBE_SHOW_RUNTIME_NODE_BIN` path through `_resolve_command`,+ whose `shlex.split` is correct for command strings but corrupts unquoted paths.+- `_resolve_command` must retain command-with-arguments behavior. Explicit Show+ Runtime configuration uses it, runtime repair reconstructs such commands with+ `shlex.join`, and npm discovery uses its PATH lookup. The desktop Node override has+ no command-with-arguments producer or documented caller, so its path-specific+ resolver is the narrow owning boundary for the fix.++## Scope and evidence++Expected edits: `core/show_runtime.py`, relevant existing shared path helper if needed,+`vibe/desktop_runtime.py` only if audit demonstrates a defect, focused existing tests,+and this brief / existing directly relevant documentation. Launcher and bundle sources+are read-only unless the consumer-side solution proves incomplete; report any needed+scope expansion. No schema, dependency, UI, service, packaging or release changes.++Use test-owned filesystem/env state only. Regression coverage must fail on the old+resolver and prove intact argv through a real executable path containing spaces.+Cover native backslash preservation without pretending a Linux/macOS test is Windows+execution. Audit npm/root paths and relevant command compatibility. Run focused tests+and Ruff on all changed Python files. Manager independently inspects the actual diff+and exercises the changed path before reporting completion.++Pre-fix regression evidence on macOS:++- an executable reached through an `Application Support` path resolved as missing;+- a missing full path whose first whitespace-delimited prefix was executable resolved+ to that prefix plus a synthetic argument;+- a Windows path with spaces and backslashes never reached native path validation.++Post-fix focused coverage executes a test-owned interpreter through an+`Application Support` symlink, rejects the valid-prefix case, preserves a Windows+path byte-for-byte up to native path validation, and pins command-with-arguments+behavior for the generic resolver. Existing desktop Runtime confinement,+runtime-bundle probe environment, and all three backend npm argv contracts remain+covered.++Deliver a non-draft PR to `master`, exact-head Codex review, all expected CI green,+and zero unresolved threads. Record audit findings and residual platform acceptance+here and in the PR. The fix needs a new Desktop rc/runtime bundle to reach installed+Desktop users; creating that release is not authorized in this task.++Native installed-Desktop acceptance remains for the next macOS and Windows rc:+macOS must render a Show Page from its normal Application Support Runtime without a+shim, and Windows must launch the bundled Node path from the installed package.++## Safety and close-out++Never restart local vibe/Desktop, touch the owner shim at+`/Users/max/Library/Application`, mutate user state, or use the shim in tests.+Do not merge, deploy, tag, or release without explicit owner instruction.diff --git a/tests/test_ui_show_pages.py b/tests/test_ui_show_pages.pyindex 34c932f7f..58008b063 100644--- a/tests/test_ui_show_pages.py+++ b/tests/test_ui_show_pages.py@@ -8799,6 +8799,73 @@ def test_explicit_runtime_ignores_unrelated_malformed_node_override(monkeypatch,assert result.runtime_reason != "runtime_start_node_command_invalid"[email protected](os.name == "nt", reason="native Windows path semantics are covered separately")+def test_configured_node_path_with_spaces_executes_intact(monkeypatch, tmp_path):+ node = tmp_path / "Application Support" / "node"+ node.parent.mkdir(parents=True)+ node.symlink_to(Path(sys.executable).resolve())+ monkeypatch.setenv("VIBE_SHOW_RUNTIME_NODE_BIN", str(node))++ command = show_runtime._resolve_node_command()++ assert command == [str(node)]+ result = subprocess.run(+ [+ *command,+ "-c",+ "import sys; print(sys.argv[1])",+ "desktop-node-path-intact",+ ],+ check=True,+ capture_output=True,+ text=True,+ )+ assert result.stdout.strip() == "desktop-node-path-intact"+++def test_invalid_configured_node_path_does_not_resolve_valid_split_prefix(+ monkeypatch,+ tmp_path,+):+ valid_prefix = tmp_path / ("node.exe" if os.name == "nt" else "node")+ if os.name == "nt":+ shutil.copy2(sys.executable, valid_prefix)+ else:+ valid_prefix.symlink_to(Path(sys.executable).resolve())+ configured = f"{valid_prefix} missing"+ assert not Path(configured).exists()+ monkeypatch.setenv("VIBE_SHOW_RUNTIME_NODE_BIN", configured)++ assert show_runtime._resolve_node_command() is None+++def test_configured_windows_node_path_reaches_native_path_validation_intact(+ monkeypatch,+):+ configured = r"C:\Program Files\Avibe Runtime\tools\node.exe"+ observed = []+ monkeypatch.setenv("VIBE_SHOW_RUNTIME_NODE_BIN", configured)++ def resolve(path):+ observed.append(str(path))+ return str(path)++ monkeypatch.setattr(show_runtime, "_resolve_executable_path", resolve)++ assert show_runtime._resolve_node_command() == [configured]+ assert observed == [configured]+++def test_generic_command_resolver_preserves_command_arguments(monkeypatch):+ monkeypatch.setattr(show_runtime.shutil, "which", lambda executable: f"/resolved/{executable}")++ assert show_runtime._resolve_command("runtime-cli --port 4321") == [+ "/resolved/runtime-cli",+ "--port",+ "4321",+ ]++def test_managed_runtime_normalizes_malformed_node_override(monkeypatch, tmp_path):monkeypatch.setenv("VIBE_SHOW_RUNTIME_NODE_BIN", "'unterminated")manager = ShowRuntimeManager(