Skip to content

armgit / avibe

Public Imported from GitHub
0

Make your computer a home for your AI partner. Avibe is the local-first Agent OS: Vibey, its built-in AI partner, works out of the box, and Claude Code, Codex & OpenCode run unchanged beside it — reach them from your browser, phone, or any chat app.

fix(merge): retire Vibey's MCP-prompt exclusion now that Computer Use is a CLI

cyh76d10115b532
diff --git a/docs/plans/avibe-agent-core.md b/docs/plans/avibe-agent-core.md
index cea70363a..da6963f8c 100644
--- a/docs/plans/avibe-agent-core.md
+++ b/docs/plans/avibe-agent-core.md
@@ -393,7 +393,7 @@ contracts and checked against the implementing lane's code before they are close
| Steer receipt fencing in the shared Turn owner | `core/session_turns.py` (`_finish_steer`) | **Done in PR #2345** (orchestrator-authorized cross-lane fix): a negative receipt settles only a current attempt whose Deliveries are still steering or reconciling, and a caller that knows the attempt passes `expected_attempt_id`, so a late or duplicate receipt can no longer pull a Delivery out of a Turn that claimed it. Regression: `test_a_late_negative_steer_receipt_never_moves_a_delivery_its_attempt_no_longer_owns`. |
| Fork as the runtime's base primitive | `core/agent_core/harness`, `core/agent_core/agent`, `storage/agent_transcript.py`, `core/services/session_fork.py` | Contract [`agent-core-contracts/fork.md`](agent-core-contracts/fork.md) (C-10, frozen 2026-10-10 by owner decision): one fork point with two carriers, the side turn and the fork Session. Phase 1a wires Vibey's existing session fork to the fork point (a user's fork cuts at the end of the previous ended Turn; arbitrary settled points are internal only, with no product surface); Phase 1b rebuilds C-9's checkpoint turn on the side turn. Native backends keep their existing fork logic (owner decision, 2026-10-10). Teams are a later design; native point-in-time fork and a self-fork bound are not planned. |
| Hooks with context management | `core/agent_core/agent/` (C-3, C-9) | In v1, an Agent with a `ContextConfig` takes no user hooks: `before_model` rewrites and `before_tool`/`after_tool` decisions each changed what C-9 owns (the route, the projected prefix, artifacts, the checkpoint budget). A post-v1 design defines which hook outputs C-9 accepts and how it accounts for them before the two are combined (owner decision, PR #2360 round 5). |
-| MCP via the MCP Hub (CLI-first): no per-backend MCP client | Avibe MCP Hub (master) | Owner decision, 2026-10-11: Avibe is CLI-first. Installed MCP servers sit behind an Avibe MCP Hub; Agents get a Hub skill and use MCP through `vibe` commands, so Vibey gets no MCP client, the engine takes no `mcp` dependency, and every backend reaches the same servers the same way. Computer Use becomes a standalone `vibe` subcommand, owned on master. |
+| MCP via the MCP Hub (CLI-first): no per-backend MCP client | Avibe MCP Hub (master) | Owner decision, 2026-10-11: Avibe is CLI-first. Installed MCP servers sit behind an Avibe MCP Hub; Agents get a Hub skill and use MCP through `vibe` commands, so Vibey gets no MCP client, the engine takes no `mcp` dependency, and every backend reaches the same servers the same way. Computer Use is the standalone `vibe computer` subcommand plus the built-in `computer-use` Skill (#2442, owned on master); Vibey reaches it from `bash` with its Turn's `AVIBE_SESSION_ID`, as every backend does. |
| Permissions through the question UI | deferred, not v1 | No backend prompts per action today: Claude Code runs with `bypassPermissions`, Codex with approvals and sandbox bypassed, and Vibey with no approval hooks. A cross-backend design comes later, if ever. It would need the controller IPC path: pending questions live in the controller process while Workbench answers arrive through `vibe/ui_server.py`, so the in-memory `QuestionUIHandler` alone is not enough. C-10 `fork.md` §6 already fixes how approvals order against policy and forks. |
| Call-instance identity for job files | `core/agent_core/tools/` (`ToolContext`, job `meta.json`), the adapter | **Done.** A tool call's identity is its instance: the owning response plus the call id, because providers reuse ids. The loop gives every executed call its instance (`ToolContext.call`: the response's row id and `context_seq`), and the job's `meta.json` records it. T2's job lookup (`find_job`), J5's settled check, and the hand-over's owning Turn match on the whole instance in context order; the clock fallback, which assumed a non-decreasing wall clock between a response's commit and its job's start, is gone. |
diff --git a/tests/test_vibey_agent.py b/tests/test_vibey_agent.py
index 7b9d921d4..ba047e870 100644
--- a/tests/test_vibey_agent.py
+++ b/tests/test_vibey_agent.py
@@ -1743,20 +1743,6 @@ async def test_another_agent_on_the_backend_is_not_told_it_is_vibey(engine, sess
assert "You are Rex, a careful code reviewer." in system and f"- {CONCURRENT_CALLS_RULE}" in system
-async def test_the_system_prompt_offers_no_computer_use_it_cannot_call(
- engine, session, tmp_path, published, monkeypatch
-) -> None:
- import core.computer_use as computer_use
-
- # The desktop has Computer Use on: the MCP backends get the avibe_computer server, Vibey has no MCP client.
- monkeypatch.setattr(computer_use, "managed_mcp_server_spec", lambda **_kwargs: object())
- harness = _Harness(engine, tmp_path, "avibe", [[Done(assistant("ok"))]])
-
- await harness.agent.handle_message(harness.request("click the Save button in Preview"))
-
- assert "avibe_computer" not in harness.provider.requests[0].system
-
-
async def test_an_idle_session_holds_no_adapter_state(engine, session, tmp_path, published) -> None:
harness = _Harness(engine, tmp_path, "avibe", _tool_turn() + [[Done(assistant("again"))]])