Skip to content

armgit / avibe

Public Imported from GitHub
0

Make your computer a home for your AI partner. Avibe is the local-first Agent OS: Vibey, its built-in AI partner, works out of the box, and Claude Code, Codex & OpenCode run unchanged beside it — reach them from your browser, phone, or any chat app.

docs(skill): close out direct user delivery in one turn (#2197)

Call Whitebf15cc224ef0
diff --git a/.agents/skills/pr-delivery-loop/SKILL.md b/.agents/skills/pr-delivery-loop/SKILL.md
index 9a38ac260..37ea7c215 100644
--- a/.agents/skills/pr-delivery-loop/SKILL.md
+++ b/.agents/skills/pr-delivery-loop/SKILL.md
@@ -82,11 +82,11 @@ do not load them routinely. They introduce no additional delivery gates.
seed/arm before any subsequent push or explicit trigger. Never reseed, rotate,
or replace the cursor between rounds. Recovery from an actual Watch failure
is separate from routine delivery; retain evidence and follow the dependency.
-- Keep that Watch live while pushing, replying, and resolving. At each round's
- end, use management commands to verify exactly one live Watch for this owner,
- PR, and concern, not merely a remembered ID. An independent orchestrator gate
- Watch is required for delegated work and has its own state; it is not a
- duplicate lane Watch. Verify the lane's observation is live too.
+- Keep that Watch live while pushing, replying, and resolving. During review,
+ use management commands at each round's end to verify exactly one live Watch
+ for this owner, PR, and concern, not merely a remembered ID. An independent
+ orchestrator gate Watch is required for delegated work and has its own state;
+ it is not a duplicate lane Watch. Verify the lane's observation is live too.
- Match every distinct Actions run ID for each required workflow at the current
head and branch. Another matching run still pending or failed blocks CI, even
if one run succeeded. Verify workflow names against actual runs. `DIRTY` plus
@@ -144,9 +144,9 @@ do not load them routinely. They introduce no additional delivery gates.
- Internal round reports identify PR/head, findings addressed, and remaining
gates in one or two lines. Do not add redundant round-summary PR comments.
-## 4. Deliver, then close out
+## 4. Complete delivery
-All close-out gates must hold together:
+Before closing out, verify all review gates together:
1. A valid current-head Codex pass with no real findings.
2. Unless the repository explicitly defines no CI, the full expected check set
@@ -154,19 +154,22 @@ All close-out gates must hold together:
Missing, pending, failed, cancelled, timed-out, action-required, or unreadable
evidence blocks the gate.
3. Zero unresolved threads across the entire PR, including older/outdated heads.
-4. A delivered final report naming repository, PR URL, reviewed head, changes,
- validation layers, and residual manual/E2E work.
+
+The final report names the repository, PR URL, reviewed head, changes,
+validation layers, and residual manual/E2E work.
+
+In a user-started orchestrator session, close out in the current turn: verify
+the gates, remove the Watch, then send the final report to the user. Do not
+create a follow-up solely to sequence report delivery and cleanup.
Delegated run finals are callback reports with a stable PR/head or Run ID, not
scratch text. A watch-triggered lane must explicitly deliver its report or
escalation to the orchestrator using `vibe agent run --session-id <orchestrator>
--message-file <report> --no-callback` and verify the send. The orchestrator also
sends circuit-breaker decisions back explicitly; a GitHub Watch cannot observe
-Session decisions. In a user-started orchestrator session, deliver to the user.
-
-Keep the Watch until the report is delivered, then remove it. This order also
-applies when the gates were already green when the turn started. If delivery
-fails, observation remains available for recovery.
+Session decisions. Keep a delegated lane's Watch until its report is delivered
+to the orchestrator, then remove it. If delivery fails, keep observation
+available for recovery.
**Do not merge without explicit user/orchestrator authorization.** Such an
instruction is final review authority, not permission to skip mechanical gates
diff --git a/tests/test_harness_skill_guidance.py b/tests/test_harness_skill_guidance.py
index 57854ab6d..2f112fb30 100644
--- a/tests/test_harness_skill_guidance.py
+++ b/tests/test_harness_skill_guidance.py
@@ -295,7 +295,7 @@ def test_pr_delivery_loop_keeps_one_optional_reference_out_of_routine_loading()
skill = parse_skill_file(directory / "SKILL.md", priority=(1, 0, 1))
assert skill is not None
rendered = render_skill_content(skill)
- assert "## 4. Deliver, then close out" in rendered
+ assert "## 4. Complete delivery" in rendered
assert "### Authorized local regression updates" in rendered
reference = (directory / references[0]).read_text()
assert reference.startswith("# Delivery Rationale and Examples")