Make your computer a home for your AI partner. Avibe is the local-first Agent OS: Vibey, its built-in AI partner, works out of the box, and Claude Code, Codex & OpenCode run unchanged beside it — reach them from your browser, phone, or any chat app.
Python agentagent-osaiai-agentsai-partnerchatopsclaudeclaude-codecodexdevtoolsdiscord-botlark-botllmlocal-firstlong-term-memoryopencodeslack-botvibe-codingvibeywechat
docs(pr-delivery): a Codex pass is the review state that names the current head (#2797)
Call Whitedcf7eb4d11c4
diff --git a/.agents/skills/pr-delivery-loop/SKILL.md b/.agents/skills/pr-delivery-loop/SKILL.mdindex ef7ec278c..04d5d19a0 100644--- a/.agents/skills/pr-delivery-loop/SKILL.md+++ b/.agents/skills/pr-delivery-loop/SKILL.md@@ -34,7 +34,7 @@ The `background-watch-hook` skill owns Watch mechanics: scripts, cursors, filterCodex signals are easy to misread:- Review usually starts within a few minutes after a push, shown by Codex `eyes` on the PR. If there is no sign, comment `@codex review`, record the ID of that comment, and check whether that exact comment receives Codex `eyes`. The `eyes` disappear after review; their later absence does not mean Codex never accepted the job.-- Accept conclusions only from `chatgpt-codex-connector` (often displayed as `[bot]`). A pass has one of two forms: a comment saying `Codex Review: Didn't find any major issues` and naming the current SHA; or a `+1` reaction on the PR body that the Watch definitely observed as new after this head was pushed, and only if no earlier head's review was still running when this head was pushed (otherwise the earlier review's late `+1` looks the same). If it cannot be bound to the current head, trigger another review and require a SHA-bearing conclusion. A finding review also contains `Reviewed commit`; that alone is not a pass.+- Accept conclusions only from `chatgpt-codex-connector` (often displayed as `[bot]`). A pass must name the current head's SHA, in one of two forms: the bot's review summary comment, whose `<!-- codex-review-state:v1 … -->` line shows the current head's full `commit_sha` in `code_review` with `"status":"completed"` and `"has_any_findings":false` (the bot edits this one comment in place, so read its current body); or a comment saying `Codex Review: Didn't find any major issues` and naming the current SHA. A `+1` reaction on the PR body means some review finished with no findings, but it names no commit; treat it as a prompt to read the summary state, never as a pass on its own. If no SHA-bearing conclusion exists for the current head, trigger another review. A finding review also contains `Reviewed commit`; that alone is not a pass.- Do not push a new head while review is running: that wastes the round and binds the conclusion to the wrong head. Use the time for acceptance checks and close-out preparation.## Findings and review threadsdiff --git a/.agents/skills/pr-delivery-loop/references/rationale.md b/.agents/skills/pr-delivery-loop/references/rationale.mdindex 4f3cf2937..5b7cdd2af 100644--- a/.agents/skills/pr-delivery-loop/references/rationale.md+++ b/.agents/skills/pr-delivery-loop/references/rationale.md@@ -31,12 +31,15 @@ can quietly become a stale deployment source.never picked up.- A `+1` carries no commit. Suppose head A is under review and you push head B.When A's review finishes with no findings, its `+1` arrives after B was pushed- and looks exactly like a pass for B. That is why a `+1` counts only when no- earlier head's review was still running at the push. Otherwise, require a- SHA-bearing conclusion for the current head.-- The Watch can bind a new `+1` to a head only through its original cursor and- the head timeline. Rebuilding the Watch or resetting its cursor after a push- can consume evidence that already arrived, so a finished review looks silent.+ and looks exactly like a pass for B. The bot's review summary comment does+ name the commit: its `codex-review-state` line records the full `commit_sha`,+ the status and whether there were findings. So the pass is read from that+ state, matched to the current head, and the `+1` only says it is worth reading.+- The summary comment is edited in place as each review starts and finishes.+ Read its current body, not a copy seen earlier.+- Rebuilding the Watch or resetting its cursor after a push can consume events+ that already arrived, so a finished review looks silent until you read the+ live state.- A lane Run marked `succeeded` proves only that the invocation ended. It doesnot prove that the current head's review started, that the Watch is alive, orthat the orchestrator received the report.diff --git a/tests/test_repository_guidance.py b/tests/test_repository_guidance.pyindex ba282bbc3..43cb67e73 100644--- a/tests/test_repository_guidance.py+++ b/tests/test_repository_guidance.py@@ -40,11 +40,12 @@ def test_pr_delivery_loop_delegates_waiters_to_background_watch_skill() -> None:assert "you may merge on your own judgment only when all of these hold" in flatassert "touches no release or tag, database migration, or security boundary" in flat- # A Codex pass binds to the current head: a comment naming its SHA, or a PR-body- # `+1` the Watch saw arrive after it was pushed while no earlier head's review was- # still running (that review's late `+1` looks the same). `Reviewed commit` is on findings too.+ # A Codex pass names the current head's SHA: the summary comment's review state, or a+ # pass comment naming it. A PR-body `+1` names no commit, so it is never a pass alone.+ # `Reviewed commit` is on findings too.+ assert "A pass must name the current head's SHA" in flat+ assert '`"status":"completed"` and `"has_any_findings":false`' in flatassert "`Codex Review: Didn't find any major issues` and naming the current SHA" in flat- assert "a `+1` reaction on the PR body that the Watch definitely observed as new after this head was pushed" in flat- assert "only if no earlier head's review was still running when this head was pushed" in flat- assert "require a SHA-bearing conclusion" in flat+ assert "never as a pass on its own" in flat+ assert "If no SHA-bearing conclusion exists for the current head, trigger another review." in flatassert "also contains `Reviewed commit`; that alone is not a pass" in flat