Skip to content

armgit / ax

Public Imported from GitHub
0

Agent Executor (AX) is Google's open agentic orchestration runtime

Go

gemini: wire planner Temperature through to GenerateContent (#295)

JoyceLiu23b3c0662015
diff --git a/internal/cliutil/cliutil.go b/internal/cliutil/cliutil.go
index 50fa39c..d8ff379 100644
--- a/internal/cliutil/cliutil.go
+++ b/internal/cliutil/cliutil.go
@@ -58,6 +58,7 @@ func NewControllerFromConfig(ctx context.Context, cfg *config.Config) (*controll
GeminiConfig: &config.GeminiConfig{
Model: cfg.Planner.Gemini.Model,
MaxTokens: cfg.Planner.Gemini.MaxTokens,
+ Temperature: cfg.Planner.Gemini.Temperature,
Timeout: timeout,
SystemPrompt: cfg.Planner.Gemini.SystemPrompt,
},
diff --git a/internal/config/config.go b/internal/config/config.go
index f741527..2a202f9 100644
--- a/internal/config/config.go
+++ b/internal/config/config.go
@@ -106,6 +106,7 @@ type GeminiConfig struct {
Model string `json:"model,omitempty" yaml:"model,omitempty"`
SystemPrompt string `json:"system_prompt,omitempty" yaml:"system_prompt,omitempty"`
MaxTokens int32 `json:"max_tokens,omitempty" yaml:"max_tokens,omitempty"`
+ Temperature float32 `json:"temperature,omitempty" yaml:"temperature,omitempty"` // 0 means use model default
Timeout time.Duration `json:"timeout,omitempty" yaml:"timeout,omitempty"`
Tools []string `json:"tools,omitempty" yaml:"tools,omitempty"`
}
diff --git a/internal/gemini/gemini_planner.go b/internal/gemini/gemini_planner.go
index 58f7853..1874bee 100644
--- a/internal/gemini/gemini_planner.go
+++ b/internal/gemini/gemini_planner.go
@@ -183,7 +183,7 @@ func (p *geminiPlannerAgent) process(ctx context.Context, start *proto.AgentStar
ctx, cancel := context.WithTimeout(ctx, p.config.GeminiConfig.Timeout)
defer cancel()
- resp, err := p.client.Models.GenerateContent(ctx, p.config.GeminiConfig.Model, contents, &genai.GenerateContentConfig{
+ genCfg := &genai.GenerateContentConfig{
Tools: tools,
ToolConfig: &genai.ToolConfig{
FunctionCallingConfig: &genai.FunctionCallingConfig{
@@ -193,7 +193,14 @@ func (p *geminiPlannerAgent) process(ctx context.Context, start *proto.AgentStar
SystemInstruction: genai.Text(p.config.GeminiConfig.SystemPrompt)[0],
MaxOutputTokens: p.config.GeminiConfig.MaxTokens,
CandidateCount: 1,
- })
+ }
+ // Temperature is *float32 in genai: leave nil to inherit the model's
+ // default. We treat the zero value in our config the same way.
+ if t := p.config.GeminiConfig.Temperature; t > 0 {
+ genCfg.Temperature = &t
+ }
+
+ resp, err := p.client.Models.GenerateContent(ctx, p.config.GeminiConfig.Model, contents, genCfg)
if err != nil {
return "", false, fmt.Errorf("failed to generate in planner: %w", err)