Skip to content

armgit / ax

Public Imported from GitHub
0

Agent Executor (AX) is Google's open agentic orchestration runtime

Go

antigravity: reject unknown harness_config fields (#301)

Joyce Liua953396b6d2f
diff --git a/python/antigravity/harness_server.py b/python/antigravity/harness_server.py
index 898b0d9..4f03bba 100644
--- a/python/antigravity/harness_server.py
+++ b/python/antigravity/harness_server.py
@@ -41,11 +41,13 @@ from google.antigravity import Agent, AgentConfig, LocalAgentConfig
from google.antigravity.types import Text, Thought, ToolCall
-# AX owns these fields for resumption; a request must not set them.
+# Fields that come from outside harness_config and must not be set through it:
+# - conversation_id: taken from the runtime request (request.conversation_id).
+# - save_dir: derived at the server level from the configured state_dir.
# TODO: add validation for fields that are unsafe to set per execution
# (e.g. credentials, deployment routing) or that may only be set at
# conversation creation.
-_AX_MANAGED_CONFIG_FIELDS = frozenset({"conversation_id", "save_dir"})
+_NON_HARNESS_CONFIG_FIELDS = frozenset({"conversation_id", "save_dir"})
class HarnessConfigError(ValueError):
@@ -155,6 +157,27 @@ def _existing_sdk_conv_id(save_dir: str) -> str | None:
return dbs[0].stem if dbs else None
+def _reject_disallowed_fields(overrides: dict[str, object]) -> None:
+ """Best-effort validation of a request harness_config overlay's keys.
+
+ Rejects fields managed outside harness_config and unknown top-level
+ fields (typos that LocalAgentConfig's extra="ignore" would otherwise
+ silently drop).
+ Top-level only: nested-key and value/type validation is delegated to the
+ SDK's own LocalAgentConfig validation when the config is constructed.
+ """
+ managed = sorted(set(overrides) & _NON_HARNESS_CONFIG_FIELDS)
+ if managed:
+ raise HarnessConfigError(
+ f"field(s) managed outside harness_config cannot be set: {', '.join(managed)}"
+ )
+ unknown = sorted(set(overrides) - set(LocalAgentConfig.model_fields))
+ if unknown:
+ raise HarnessConfigError(
+ f"unknown config field(s): {', '.join(unknown)}"
+ )
+
+
class AntigravityHarnessServiceServicer(ax_pb2_grpc.HarnessServiceServicer):
"""Implements the ax.HarnessService protocol over gRPC."""
@@ -175,21 +198,14 @@ class AntigravityHarnessServiceServicer(ax_pb2_grpc.HarnessServiceServicer):
raise HarnessConfigError(f"expected UTF-8 JSON: {exc}") from exc
if not isinstance(overrides, dict):
raise HarnessConfigError("top-level JSON value must be an object")
- managed = sorted(set(overrides) & _AX_MANAGED_CONFIG_FIELDS)
- if managed:
- raise HarnessConfigError(
- f"AX-managed field(s) cannot be set: {', '.join(managed)}"
- )
- # TODO: reject fields the SDK doesn't know. Pydantic defaults to
- # extra="ignore", so a field-name typo is silently dropped instead
- # of erroring; check against LocalAgentConfig.model_fields and raise.
+ _reject_disallowed_fields(overrides)
else:
overrides = {}
- # AX-managed persistence values go on last so a request can never
- # redirect trajectory storage. Per-AX-conv save_dir under the configured
- # state_dir base; resume by the SDK's own conv_id if a trajectory
- # already exists there. SDK auto-creates the directory.
+ # Persistence values managed outside harness_config go on last so a
+ # request can never redirect trajectory storage. Per-AX-conv save_dir
+ # under the configured state_dir base; resume by the SDK's own conv_id
+ # if a trajectory already exists there. SDK auto-creates the directory.
overrides["save_dir"] = str(self._state_dir / conversation_id)
if sdk_conv_id := _existing_sdk_conv_id(overrides["save_dir"]):
overrides["conversation_id"] = sdk_conv_id
diff --git a/python/antigravity/harness_server_test.py b/python/antigravity/harness_server_test.py
index cacce50..ab7af27 100644
--- a/python/antigravity/harness_server_test.py
+++ b/python/antigravity/harness_server_test.py
@@ -568,12 +568,14 @@ def test_harness_config_overlay_applies_multiple_fields(mock_config, tmp_path):
(b"{", "expected UTF-8 JSON"),
(b"\xff", "expected UTF-8 JSON"),
(json.dumps([]).encode(), "top-level JSON value must be an object"),
- (json.dumps({"save_dir": "/tmp/other"}).encode(), "AX-managed field"),
- (json.dumps({"conversation_id": "other"}).encode(), "AX-managed field"),
+ (json.dumps({"save_dir": "/tmp/other"}).encode(), "managed outside harness_config"),
+ (json.dumps({"conversation_id": "other"}).encode(), "managed outside harness_config"),
(
json.dumps({"capabilities": {"enabled_tools": ["not-a-tool"]}}).encode(),
"validation error",
),
+ (json.dumps({"system_instruction": "typo"}).encode(), "unknown config field"),
+ (json.dumps({"model": "m", "frobnicate": True}).encode(), "unknown config field"),
])
def test_harness_config_rejects(mock_config, tmp_path, raw_config, error):
servicer = AntigravityHarnessServiceServicer(mock_config, tmp_path)
@@ -602,3 +604,17 @@ def test_run_turn_invalid_harness_config_maps_to_invalid_argument(mock_config, t
assert "Invalid harness_config" in responses[0].end.error.description
asyncio.run(_run())
+
+
+def test_harness_config_unknown_field_names_are_reported(mock_config, tmp_path):
+ # The error lists the offending field(s), sorted, so a typo is actionable;
+ # any unknown field rejects the whole overlay (no silent drop) and valid
+ # fields in the same request are not flagged.
+ servicer = AntigravityHarnessServiceServicer(mock_config, tmp_path)
+ raw = json.dumps({"zzz_bad": 1, "aaa_bad": 2, "system_instructions": "ok"}).encode()
+ with pytest.raises(HarnessConfigError) as excinfo:
+ servicer._build_config_for("conv-1", raw)
+ msg = str(excinfo.value)
+ assert "unknown config field(s): aaa_bad, zzz_bad" in msg
+ assert "system_instructions" not in msg
+