Skip to content

armgit / ax

Public Imported from GitHub
0

Agent Executor (AX) is Google's open agentic orchestration runtime

Go

impl: structured logging in controller and substrate harness (#70)

anj-sb3932e09a483
diff --git a/internal/controller2/controller.go b/internal/controller2/controller.go
index 2790bd8..91e20d6 100644
--- a/internal/controller2/controller.go
+++ b/internal/controller2/controller.go
@@ -19,7 +19,7 @@ package controller2
import (
"context"
"fmt"
- "log"
+ "log/slog"
"github.com/google/ax/internal/controller/executor"
"github.com/google/ax/internal/harness/harnesstest"
@@ -76,7 +76,11 @@ func (d *Controller) Exec(ctx context.Context, req *proto.ExecRequest, handler E
h, err := d.registry.Harness(req.AgentId)
if err != nil {
// Fallback to test harness
- log.Printf("WARNING: harness %s not found in registry, falling back to test harness: %v", req.AgentId, err)
+ slog.WarnContext(ctx, "Harness not found in registry, falling back to test harness",
+ slog.String("agent_id", req.AgentId),
+ slog.String("conversation_id", req.ConversationId),
+ slog.Any("error", err),
+ )
h = harnesstest.New()
}
exec, err := h.Start(ctx, req.ConversationId)
@@ -128,7 +132,10 @@ func (a *harnessHandler) OnMessage(ctx context.Context, execID string, msg *prot
}
// TODO(anj): The harness should send the full input sent to get this particular response.
if _, err := a.eventLog.Append(ctx, event); err != nil {
- log.Printf("WARNING: failed to log streamed message: %v", err)
+ slog.WarnContext(ctx, "Failed to log streamed message to event log",
+ slog.String("conversation_id", a.conversationID),
+ slog.Any("error", err),
+ )
}
if a.execHandler == nil {
@@ -147,7 +154,10 @@ func (a *harnessHandler) OnComplete(ctx context.Context, execID string) error {
State: proto.State_STATE_COMPLETED,
}
if _, err := a.eventLog.Append(ctx, event); err != nil {
- log.Printf("WARNING: failed to log completion event: %v", err)
+ slog.WarnContext(ctx, "Failed to log completion event to event log",
+ slog.String("conversation_id", a.conversationID),
+ slog.Any("error", err),
+ )
}
return nil
}
diff --git a/internal/harness/substrate.go b/internal/harness/substrate.go
index fe61f40..6ca7bee 100644
--- a/internal/harness/substrate.go
+++ b/internal/harness/substrate.go
@@ -20,7 +20,7 @@ import (
"errors"
"fmt"
"io"
- "log"
+ "log/slog"
"sync"
"time"
@@ -245,11 +245,17 @@ func (e *substrateExecution) Close(ctx context.Context) error {
}
// Suspend actor to return resource to standard standby pool
- log.Printf("Suspending SubstrATE actor for conversation %s (execution %s)", e.conversationID, e.execID)
+ slog.InfoContext(ctx, "Suspending SubstrATE actor",
+ slog.String("conversation_id", e.conversationID),
+ slog.String("exec_id", e.execID),
+ )
suspendCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
if _, err := e.harness.ateClient.SuspendActor(suspendCtx, e.conversationID); err != nil {
- log.Printf("Failed to suspend actor %s: %v", e.conversationID, err)
+ slog.ErrorContext(ctx, "Failed to suspend SubstrATE actor",
+ slog.String("conversation_id", e.conversationID),
+ slog.Any("error", err),
+ )
}
return nil