Skip to content

armgit / ax

Public Imported from GitHub
0

Agent Executor (AX) is Google's open agentic orchestration runtime

Go

feat: implement graceful shutdown for server (#42)

JoyceLiuda40ee3c95ca
diff --git a/cmd/gar/serve.go b/cmd/gar/serve.go
index b5bd941..f467ed3 100644
--- a/cmd/gar/serve.go
+++ b/cmd/gar/serve.go
@@ -82,7 +82,7 @@ func runServe(cmd *cobra.Command, args []string) error {
go func() {
<-sigChan
log.Println("\nReceived interrupt, shutting down...")
- os.Exit(0)
+ srv.GracefulStop()
}()
log.Printf("Starting GAR server at %s...\n", cfg.Server.Address)
diff --git a/internal/server/server.go b/internal/server/server.go
index 3f6f765..dc389e4 100644
--- a/internal/server/server.go
+++ b/internal/server/server.go
@@ -35,6 +35,7 @@ type Server struct {
proto.UnimplementedGARServiceServer
controller *controller.Controller
+ grpcServer *grpc.Server
}
// New creates a new controller server.
@@ -143,12 +144,20 @@ func (s *Server) Serve(address string, opts ...grpc.ServerOption) error {
return fmt.Errorf("failed to listen: %w", err)
}
- grpcServer := grpc.NewServer(opts...)
- proto.RegisterGARServiceServer(grpcServer, s)
+ s.grpcServer = grpc.NewServer(opts...)
+ proto.RegisterGARServiceServer(s.grpcServer, s)
- if err := grpcServer.Serve(lis); err != nil {
+ if err := s.grpcServer.Serve(lis); err != nil {
return fmt.Errorf("failed to serve: %w", err)
}
return nil
}
+
+// GracefulStop stops the gRPC server gracefully.
+func (s *Server) GracefulStop() {
+ if s.grpcServer != nil {
+ s.grpcServer.GracefulStop()
+ }
+}
+