Skip to content

armgit / ax

Public Imported from GitHub
0

Agent Executor (AX) is Google's open agentic orchestration runtime

Go

Remove ununsed internal_only field (#197)

Jaana Doganf39e1f23b498
diff --git a/cmd/ax/dashboard.go b/cmd/ax/dashboard.go
index fd9651c..e518f74 100644
--- a/cmd/ax/dashboard.go
+++ b/cmd/ax/dashboard.go
@@ -75,7 +75,7 @@ func runDashboard(cmd *cobra.Command, args []string) error {
dbPath := cfg.EventLog.SQLiteConfig.Filename
slog.InfoContext(ctx, "Opening event log database", slog.String("path", dbPath))
-
+
if err := os.MkdirAll(filepath.Dir(dbPath), 0755); err != nil {
return fmt.Errorf("failed to create database directory: %w", err)
}
@@ -435,10 +435,6 @@ func buildExecTraces(execIDs []string, events []*proto.ConversationEvent) []Exec
func extractMsgs(protoContents []*proto.Message) []Content {
var results []Content
for _, c := range protoContents {
- // Skip messages flagged as internal-only.
- if c.GetInternalOnly() {
- continue
- }
content := Content{Role: c.Role}
msgContent := c.GetContent()
if msgContent == nil {
diff --git a/proto/ax.pb.go b/proto/ax.pb.go
index 9a3dbf1..2f002b4 100644
--- a/proto/ax.pb.go
+++ b/proto/ax.pb.go
@@ -147,13 +147,9 @@ func (CancelReason) EnumDescriptor() ([]byte, []int) {
// Message is a message in the history.
type Message struct {
- state protoimpl.MessageState `protogen:"open.v1"`
- Role string `protobuf:"bytes,1,opt,name=role,proto3" json:"role,omitempty"` // user, assistant, or model
- Content *Content `protobuf:"bytes,2,opt,name=content,proto3" json:"content,omitempty"` // content of the message
- // If true, the message is stored only in the execution log
- // (for resumption) but not in the conversation history,
- // and not emitted to the client or any agent.
- InternalOnly bool `protobuf:"varint,3,opt,name=internal_only,json=internalOnly,proto3" json:"internal_only,omitempty"`
+ state protoimpl.MessageState `protogen:"open.v1"`
+ Role string `protobuf:"bytes,1,opt,name=role,proto3" json:"role,omitempty"` // user, assistant, or model
+ Content *Content `protobuf:"bytes,2,opt,name=content,proto3" json:"content,omitempty"` // content of the message
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
@@ -202,13 +198,6 @@ func (x *Message) GetContent() *Content {
return nil
}
-func (x *Message) GetInternalOnly() bool {
- if x != nil {
- return x.InternalOnly
- }
- return false
-}
-
// A conversation is the historical session that consist of
// a number of execution. A conversation cannot be continued
// before the last execution is completed or failed.
@@ -992,11 +981,10 @@ var File_proto_ax_proto protoreflect.FileDescriptor
const file_proto_ax_proto_rawDesc = "" +
"\n" +
- "\x0eproto/ax.proto\x12\x02ax\x1a\x1cgoogle/protobuf/struct.proto\x1a\x13proto/content.proto\"i\n" +
+ "\x0eproto/ax.proto\x12\x02ax\x1a\x1cgoogle/protobuf/struct.proto\x1a\x13proto/content.proto\"D\n" +
"\aMessage\x12\x12\n" +
"\x04role\x18\x01 \x01(\tR\x04role\x12%\n" +
- "\acontent\x18\x02 \x01(\v2\v.ax.ContentR\acontent\x12#\n" +
- "\rinternal_only\x18\x03 \x01(\bR\finternalOnly\"\x90\x02\n" +
+ "\acontent\x18\x02 \x01(\v2\v.ax.ContentR\acontent\"\x90\x02\n" +
"\x11ConversationEvent\x12'\n" +
"\x0fconversation_id\x18\x01 \x01(\tR\x0econversationId\x12\x10\n" +
"\x03seq\x18\x02 \x01(\x05R\x03seq\x12\x17\n" +
diff --git a/proto/ax.proto b/proto/ax.proto
index f5ce83a..451eea3 100644
--- a/proto/ax.proto
+++ b/proto/ax.proto
@@ -28,10 +28,6 @@ option go_package = "github.com/google/ax/proto";
message Message {
string role = 1; // user, assistant, or model
Content content = 2; // content of the message
- // If true, the message is stored only in the execution log
- // (for resumption) but not in the conversation history,
- // and not emitted to the client or any agent.
- bool internal_only = 3;
}
// A conversation is the historical session that consist of