Skip to content

A lightweight yet powerful audio-to-MIDI converter with pitch bend detection

add docstring and rename sonify_samplerate

Tan Hao Hao0d0e2bb3a6a7
diff --git a/basic_pitch/inference.py b/basic_pitch/inference.py
index 37749dc..8c50d16 100644
--- a/basic_pitch/inference.py
+++ b/basic_pitch/inference.py
@@ -344,7 +344,7 @@ def predict_and_save(
model_path: Union[pathlib.Path, str] = ICASSP_2022_MODEL_PATH,
onset_threshold: float = 0.5,
frame_threshold: float = 0.3,
- sonify_midi_sr: int = 44100,
+ sonification_samplerate: int = 44100,
minimum_note_length: float = 58,
minimum_frequency: Optional[float] = None,
maximum_frequency: Optional[float] = None,
@@ -364,6 +364,7 @@ def predict_and_save(
model_path: Path to load the Keras saved model from. Can be local or on GCS.
onset_threshold: Minimum energy required for an onset to be considered present.
frame_threshold: Minimum energy requirement for a frame to be considered present.
+ sonification_samplerate: Sample rate for rendering audio from MIDI.
minimum_note_length: The minimum allowed note length in frames.
minimum_freq: Minimum allowed output frequency, in Hz. If None, all frequencies are used.
maximum_freq: Maximum allowed output frequency, in Hz. If None, all frequencies are used.
@@ -408,7 +409,7 @@ def predict_and_save(
if sonify_midi:
midi_sonify_path = build_output_path(audio_path, output_directory, OutputExtensions.MIDI_SONIFICATION)
try:
- infer.sonify_midi(midi_data, midi_sonify_path, sr=sonify_midi_sr)
+ infer.sonify_midi(midi_data, midi_sonify_path, sr=sonification_samplerate)
file_saved_confirmation(OutputExtensions.MIDI_SONIFICATION.name, midi_sonify_path)
except Exception:
failed_to_save(OutputExtensions.MIDI_SONIFICATION.name, midi_sonify_path)
diff --git a/basic_pitch/note_creation.py b/basic_pitch/note_creation.py
index 6b5caa6..11a046f 100644
--- a/basic_pitch/note_creation.py
+++ b/basic_pitch/note_creation.py
@@ -113,6 +113,7 @@ def sonify_midi(midi: pretty_midi.PrettyMIDI, save_path: Union[pathlib.Path, str
Args:
midi: A pretty_midi.PrettyMIDI object that will be sonified.
save_path: Where to save the sonified midi.
+ sr: Sample rate for rendering audio from midi.
"""
y = midi.synthesize(sr)
wavfile.write(save_path, sr, y)