Skip to content

armgit / bento

Public Imported from GitHub
0

Bento, the office suite that fits in a file

Autoplay off means the clip does not play (#343)

nyblnet1ffcbd396825
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 330cdaf7..ea51a860 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -244,6 +244,18 @@ jobs:
# file carrying a script tag.
run: node scripts/test-preview.ts
+ - name: Media autoplay rig
+ # An author set a clip's Autoplay to Off and it played anyway, every
+ # show, since media shipped in v0.9.16. render.ts wrote
+ # data-autoplay="" when off — PRESENT but empty — and Reveal decides
+ # autoplay with hasAttribute(), so it played what our own value-based
+ # selector correctly ignored. The property pinned here is that an
+ # autoplay-off element carries NO such attribute, because its presence
+ # is read by code we do not own. Measured on rendered DOM: the
+ # difference between assigning '' and not assigning is invisible to a
+ # grep. Self-skips without Chrome.
+ run: node scripts/test-media-autoplay.ts
+
- name: Return-gate rig
# The web demo always starts fresh, so someone who saved from
# bento.page and came back saw a blank starter and read it as lost
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 85568e10..0cf45eb4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,17 @@ pre-1.0.
## [Unreleased]
+- **Fix: audio and video played in a show even with Autoplay switched off.**
+ Set a clip's *Autoplay* to Off and it still started the moment its slide came
+ up — every time, in a saved file, on any browser. The only way to stop it was
+ to remove the clip.
+
+ The flag was written as an empty attribute rather than left off, and the
+ slideshow engine treats an attribute that is *present* as a yes, whatever it
+ says. Bento's own check read the value and was right; it simply never got
+ asked. Present since audio and video arrived.
+
+
## [1.0.18] — 2026-08-15
- **Security: offline mode did not block everything it promised.** The switch
diff --git a/scripts/test-media-autoplay.ts b/scripts/test-media-autoplay.ts
new file mode 100644
index 00000000..c5f47114
--- /dev/null
+++ b/scripts/test-media-autoplay.ts
@@ -0,0 +1,146 @@
+#!/usr/bin/env node
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2026 The Bento authors
+// Media autoplay rig.
+//
+// node scripts/test-media-autoplay.ts
+//
+// WHAT THIS PROVES. An author sets a clip's Autoplay to Off and it played
+// anyway, every time its slide came up in a show (reported 2026-08-22, present
+// since media shipped in v0.9.16).
+//
+// Two innocent halves. render.ts wrote the flag as
+//
+// dataset.autoplay = el.autoplay ? '1' : ''
+//
+// which emits data-autoplay="" — the attribute PRESENT but empty. Our own
+// present.ts reads the VALUE and was never wrong:
+//
+// querySelectorAll('video[data-autoplay="1"], audio[data-autoplay="1"]')
+//
+// but Reveal decides first, and it decides on PRESENCE:
+//
+// hasAttribute('data-autoplay') || closest('.slide-background')
+//
+// So the property worth pinning is NOT "our selector ignores an empty value" —
+// that was always true and the bug happened anyway. It is that **an
+// autoplay-off element carries no such attribute at all**, because the
+// attribute's presence is read by code we do not own and cannot change.
+//
+// It therefore has to be measured on rendered DOM rather than read off the
+// source: the difference between assigning '' and not assigning is invisible
+// in a grep and decisive in a browser. The probe is bundled against the repo's
+// own render.ts, so this is the shipping path, not a re-implementation.
+//
+// Self-skips where there is no Chrome, so it never blocks a machine that
+// cannot run it — the same bargain scripts/test-sanitize.ts makes.
+
+import { execFileSync, spawnSync } from 'node:child_process'
+import fs from 'node:fs'
+import os from 'node:os'
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+
+const root = path.join(path.dirname(fileURLToPath(import.meta.url)), '..')
+const repoFile = (p: string) => path.join(root, p)
+
+let failures = 0
+let checks = 0
+const ok = (cond: boolean, msg: string) => {
+ checks++
+ if (!cond) { failures++; console.log(` FAIL ${msg}`) } else console.log(` ok ${msg}`)
+}
+
+const CHROME = [
+ process.env.BENTO_CHROME,
+ '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
+ '/Applications/Chromium.app/Contents/MacOS/Chromium',
+ '/usr/bin/google-chrome',
+ '/usr/bin/google-chrome-stable',
+ '/usr/bin/chromium',
+ '/usr/bin/chromium-browser',
+].find((p): p is string => !!p && fs.existsSync(p))
+ ?? (spawnSync('which', ['google-chrome']).status === 0 ? 'google-chrome' : undefined)
+
+// The probe. No backticks or ${ so it survives the template literal below.
+const probeSource = (renderPath: string, modelPath: string) => `
+import { renderElement } from ${JSON.stringify(renderPath)}
+import { newDoc, defaultMedia } from ${JSON.stringify(modelPath)}
+
+const doc = newDoc()
+const out: string[] = []
+
+function attrOf(kind: 'audio' | 'video', autoplay: boolean): string {
+ const el = defaultMedia(kind, 'data:audio/mpeg;base64,AAAA', { autoplay })
+ const node = renderElement(el as any, doc, { liveMedia: true } as any)
+ document.body.appendChild(node)
+ const media = node.querySelector(kind)
+ if (!media) return 'NO-ELEMENT'
+ // hasAttribute is EXACTLY what Reveal asks. Anything else would test a
+ // different question than the one that broke.
+ return media.hasAttribute('data-autoplay')
+ ? 'present:' + JSON.stringify(media.getAttribute('data-autoplay'))
+ : 'absent'
+}
+
+out.push('audio-off=' + attrOf('audio', false))
+out.push('audio-on=' + attrOf('audio', true))
+out.push('video-off=' + attrOf('video', false))
+out.push('video-on=' + attrOf('video', true))
+
+const marker = document.createElement('div')
+marker.id = 'bento-results'
+marker.textContent = out.join(' | ')
+document.body.appendChild(marker)
+`
+
+if (!CHROME) {
+ console.log(' skip no Chrome found — set BENTO_CHROME to run the rendered-DOM checks')
+ console.log('\n0/0 checks passed (skipped)')
+ process.exit(0)
+}
+
+const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'bento-autoplay-'))
+const entry = path.join(tmp, 'probe.ts')
+fs.writeFileSync(entry, probeSource(repoFile('slides/src/render.ts'), repoFile('slides/src/model.ts')))
+execFileSync(repoFile('slides/node_modules/.bin/esbuild'), [
+ entry, '--bundle', '--format=iife', '--outfile=' + path.join(tmp, 'probe.js'),
+], { stdio: 'pipe' })
+const bundle = fs.readFileSync(path.join(tmp, 'probe.js'), 'utf8')
+
+// Inlined as a CLASSIC script and loaded from file://: a module script would be
+// blocked by the file:// origin rules, and inlining removes the need for a
+// server at all (this rig, unlike the sanitizer's, never navigates).
+// Built by concatenation — never a literal script-close in a source file.
+const page = '<!doctype html><meta charset="utf-8"><title>bento autoplay probe</title><body>'
+ + '<scr' + 'ipt>' + bundle + '</scr' + 'ipt></body>'
+const pagePath = path.join(tmp, 'probe.html')
+fs.writeFileSync(pagePath, page)
+
+const dom = execFileSync(CHROME, [
+ '--headless', '--disable-gpu', '--no-sandbox', '--dump-dom',
+ '--allow-file-access-from-files', 'file://' + pagePath,
+], { encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] })
+
+const m = dom.match(/<div id="bento-results">([^<]*)<\/div>/)
+ok(!!m, 'the probe ran and reported (if this fails, nothing below means anything)')
+const results = Object.fromEntries((m?.[1] ?? '').split(' | ').map((p) => p.split('=') as [string, string]))
+
+ok(results['audio-off'] === 'absent',
+ `audio with Autoplay OFF carries NO data-autoplay at all (got ${results['audio-off']})`)
+ok(results['video-off'] === 'absent',
+ `video with Autoplay OFF carries NO data-autoplay at all (got ${results['video-off']})`)
+ok(results['audio-on'] === 'present:"1"',
+ `audio with Autoplay ON still carries data-autoplay="1" (got ${results['audio-on']})`)
+ok(results['video-on'] === 'present:"1"',
+ `video with Autoplay ON still carries data-autoplay="1" (got ${results['video-on']})`)
+
+// The regression, stated as Reveal would see it. An empty string is present,
+// which is the whole bug: a check written as "is it not '1'" would have passed
+// on the broken build.
+ok(results['audio-off'] !== 'present:""' && results['video-off'] !== 'present:""',
+ 'and specifically not the empty attribute Reveal treats as "yes"')
+
+fs.rmSync(tmp, { recursive: true, force: true })
+console.log(`\n${checks - failures}/${checks} checks passed`)
+if (failures) process.exit(1)
diff --git a/slides/src/render.ts b/slides/src/render.ts
index 4f881728..426c8671 100644
--- a/slides/src/render.ts
+++ b/slides/src/render.ts
@@ -1070,7 +1070,12 @@ export function renderElement(el: SlideElement, doc: BentoDoc, opts: RenderOpts
audio.controls = el.controls !== false
audio.loop = !!el.loop
audio.preload = 'metadata'
- audio.dataset.autoplay = el.autoplay ? '1' : ''
+ // OMITTED, not emptied, when autoplay is off. Reveal decides autoplay
+ // with hasAttribute('data-autoplay') — presence, not value — so
+ // data-autoplay="" made it play a clip the author had switched OFF
+ // (reported 2026-08-22). Our own startMediaIn reads [data-autoplay="1"]
+ // and was never the problem; Reveal simply gets there first.
+ if (el.autoplay) audio.dataset.autoplay = '1'
audio.style.cssText = 'width:100%;display:block' + inert
const wrap = document.createElement('div')
wrap.style.cssText = 'width:100%;height:100%;display:flex;align-items:center;justify-content:center'
@@ -1092,7 +1097,7 @@ export function renderElement(el: SlideElement, doc: BentoDoc, opts: RenderOpts
video.muted = el.muted !== false
video.playsInline = true
video.preload = 'metadata'
- video.dataset.autoplay = el.autoplay ? '1' : ''
+ if (el.autoplay) video.dataset.autoplay = '1' // presence is the flag — see the audio case
video.style.cssText = `width:100%;height:100%;object-fit:${el.fit ?? 'contain'};border-radius:${radius}px;display:block;background:#0b0f14` + inert
if (!el.src) {
const ph = document.createElement('div')