Skip to content

armgit / bento

Public Imported from GitHub
0

Bento, the office suite that fits in a file

slides: chrome to the D1–D8 rulings — menu descriptions, dialog titles, help shortcuts, focus ring (#631)

nyblnetb88508c6e2f6
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 559ebca4..a2067c33 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -2055,6 +2055,11 @@ jobs:
# primary in both themes, and N language rebuilds leaving one set of
# window/document listeners and bar observers.
run: node scripts/test-slides-topbar-browser.mjs
+ - name: Chrome rulings in Chromium
+ # D2 menu descriptions (readable both themes, ARIA-wired, scroll on a
+ # short window), D4 dialog titles, D8 help shortcuts, the compact Save
+ # caret, phone menu rows, the designed focus ring, dark menu shadow.
+ run: node scripts/test-slides-chrome-rulings-browser.mjs
spaces-save-browser:
runs-on: ubuntu-latest
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e6e61fc9..6b1f00d6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,17 @@ pre-1.0.
## [Unreleased]
+- **Screen readers announce what each Save-as and Share command does.** The
+ menus keep one-line rows with the description on hover, and the same text
+ is now read out as the command's description; the Save-as list scrolls when
+ a short window cannot hold it. The Share menu's actions are plain rows like
+ Save as, rather than a stack of boxed buttons. Dialog
+ titles are a little smaller (17px), keyboard shortcuts in the help sheet are
+ set in the interface font and line up on the right, and keyboard focus
+ draws a clear amber ring. Also fixed: the Save caret's ▾ vanished at
+ medium window widths, rows in the phone ⋯ menu were centred, and menus in
+ the dark theme cast a navy shadow that did not show.
+
- **Save is the top bar's primary button; the bar's other buttons line up.**
Save and its save-as caret are now filled with the text colour, like the
primary buttons in dialogs, in light and dark themes. The amber
diff --git a/scripts/test-slides-chrome-rulings-browser.mjs b/scripts/test-slides-chrome-rulings-browser.mjs
new file mode 100644
index 00000000..bf2aadc8
--- /dev/null
+++ b/scripts/test-slides-chrome-rulings-browser.mjs
@@ -0,0 +1,213 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2026 The Bento authors
+// Slides' chrome against the maintainer's D1–D8 rulings, measured in the packaged document.
+//
+// npm run build:single --prefix slides && node scripts/test-slides-chrome-rulings-browser.mjs
+//
+// WHAT THIS PROVES (seven items from spaces' bar-parity pass, #572):
+// 1. D2, as revised 2026-09-26 — Save-as and Share rows stay one line with
+// the description as the hover tooltip AND as a visually-hidden
+// aria-describedby node, and both menus fit the screen;
+// 2. D4 — dialog titles (help, Version history) are 17px/650, not the
+// browser's 19.5px/700 h2;
+// 3. D8 — help-sheet shortcuts are in the interface face, right-aligned;
+// 4. at the compact tier the Save caret keeps its ▾, and its name stays
+// "Save as…" (the glyph is aria-hidden);
+// 5. on a phone, rows in ⋯ read from the start edge, not centred;
+// 6. keyboard focus draws a designed ring (--accent-ink, 2px): outside on a
+// bar button, inside on a menu row, 3:1 on its surface in both themes;
+// 7. the dark theme's menu shadow is its own, not the light navy at 14%.
+const { chromium } = await import(process.env.PLAYWRIGHT_MODULE || 'playwright')
+
+let checks = 0
+let failures = 0
+function ok(cond, msg) {
+ checks++
+ if (!cond) { failures++; console.log(` FAIL ${msg}`) } else console.log(` ok ${msg}`)
+}
+// computed colours are rgb()/rgba(), except color-mix(), which computes to
+// color(srgb r g b) in 0–1
+const rgb = (s) => { const n = s.match(/[\d.]+/g).slice(0, 3).map(Number); return s.startsWith('color(') ? n.map((v) => v * 255) : n }
+const lum = ([r, g, b]) => { const c = (v) => { const x = v / 255; return x <= 0.03928 ? x / 12.92 : ((x + 0.055) / 1.055) ** 2.4 }; return 0.2126 * c(r) + 0.7152 * c(g) + 0.0722 * c(b) }
+const contrast = (a, b) => { const [x, y] = [lum(rgb(a)), lum(rgb(b))].sort((p, q) => q - p); return (x + 0.05) / (y + 0.05) }
+const THEMES = ['light', 'dark']
+
+const browser = await chromium.launch({ executablePath: process.env.CHROME_PATH, headless: true })
+try {
+ const p = await browser.newPage({ viewport: { width: 1440, height: 900 } })
+ const errors = []
+ p.on('pageerror', (e) => errors.push(e.message))
+ p.on('dialog', (d) => d.accept())
+ await p.route(/^https?:/, (r) => r.abort())
+ await p.goto(new URL('../slides/dist-single/Bento_Slides.bento.html', import.meta.url).href)
+ await p.waitForFunction(() => window.bento?.doc && document.querySelector('.ed-topbar .ed-split-caret'))
+ const theme = (th) => p.evaluate((t) => { document.documentElement.dataset.theme = t }, th)
+ const closeAll = () => p.evaluate(() => {
+ document.querySelectorAll('.ed-dropdown.open').forEach((d) => d.classList.remove('open'))
+ document.querySelectorAll('.ed-about-overlay').forEach((o) => o.remove())
+ })
+ const openSave = () => p.evaluate(() => document.querySelector('.ed-split-caret').click())
+
+ // --- 1. D2 descriptions ------------------------------------------------------
+ console.log('D2 (revised): Save-as rows are one line, the description a tooltip and an ARIA description\n')
+ await openSave()
+ const save = await p.evaluate(() => [...document.querySelectorAll('.ed-save-menu > .ed-btn')].map((b) => {
+ const id = b.getAttribute('aria-describedby'), d = id && document.getElementById(id)
+ const r = d?.getBoundingClientRect()
+ return { name: b.getAttribute('aria-label') ?? b.textContent.trim(), h: b.getBoundingClientRect().height, title: b.title,
+ desc: d?.textContent ?? '', hidden: !!(d && r.width <= 1 && r.height <= 1), inRow: !!(d && b.contains(d)), second: !!b.querySelector('.ed-mi-desc') }
+ }))
+ const described = save.filter((x) => x.desc)
+ ok(described.length >= 8, `${described.length} of ${save.length} Save-as rows carry a description (Export slides as images opens a dialog that explains itself)`)
+ ok(save.every((x) => Math.abs(x.h - 30) <= 0.5 && !x.second), `every row is one 30px line (${[...new Set(save.map((x) => x.h))].join('/')}px)`)
+ ok(described.every((x) => x.title === x.desc), 'the description is the row\'s hover tooltip (title)')
+ ok(described.every((x) => x.hidden && x.inRow), '…and the same text is the aria-describedby target, visually hidden inside the row')
+ // the name stays the name: the description is announced AS a description
+ const replaceRow = p.getByRole('button', { name: 'Replace from JSON…', exact: true })
+ ok(await replaceRow.count() === 1, 'a described row keeps its bare name ("Replace from JSON…"), not name+description')
+ const menuW = await p.evaluate(() => document.querySelector('.ed-save-menu').getBoundingClientRect().width)
+ ok(menuW <= 264.5 && menuW >= 240, `the list keeps spaces' width for it (${menuW}px, 240–264)`)
+ // on a short window (phone landscape) it must scroll, not run off the
+ // bottom with its last commands out of reach
+ await closeAll()
+ await p.setViewportSize({ width: 1280, height: 260 })
+ await openSave()
+ const fit = await p.evaluate(() => { const m = document.querySelector('.ed-save-menu'); const last = m.lastElementChild; last.scrollIntoView({ block: 'nearest' }); const r = last.getBoundingClientRect(); return { bottom: Math.round(m.getBoundingClientRect().bottom), lastBottom: Math.round(r.bottom), vh: innerHeight } })
+ ok(fit.bottom <= fit.vh && fit.lastBottom <= fit.vh, `at 260px tall the list ends on screen (${fit.bottom} ≤ ${fit.vh}) and its last row scrolls into reach`)
+ await closeAll()
+ await p.setViewportSize({ width: 1440, height: 900 })
+ await theme('light')
+ await p.setViewportSize({ width: 1440, height: 768 })
+ await p.evaluate(() => document.querySelector('.ed-btn-share').click())
+ const share = await p.evaluate(() => [...document.querySelectorAll('.ed-share-pop .ed-share-btn')].map((b) => {
+ const id = b.getAttribute('aria-describedby'), d = id && document.getElementById(id), r = d?.getBoundingClientRect()
+ return { title: b.title, desc: d?.textContent ?? '', hidden: !!(d && r.width <= 1 && r.height <= 1 && b.contains(d)), tall: b.getBoundingClientRect().height }
+ }))
+ const shared = share.filter((x) => x.desc)
+ ok(share.length >= 5 && shared.length === share.length, `Share's ${share.length} actions each carry a description`)
+ ok(shared.every((x) => x.title === x.desc && x.hidden), 'as the hover tooltip, and as a visually hidden aria-describedby target in the row')
+ ok(share.every((x) => x.tall <= 36), `every Share row is one line (${[...new Set(share.map((x) => Math.round(x.tall)))].join('/')}px tall)`)
+ // plain rows like Save as: nothing at rest, no ink-filled primary, and
+ // adjacent rows touch rather than stacking as separate chips
+ const look = await p.evaluate(() => {
+ const rows = [...document.querySelectorAll('.ed-share-pop > .ed-share-btn')]
+ const clear = (c) => c === 'rgba(0, 0, 0, 0)' || c === 'transparent'
+ const boxed = rows.filter((b) => { const c = getComputedStyle(b); return !clear(c.backgroundColor) || !clear(c.borderTopColor) }).length
+ const gaps = []
+ for (let i = 1; i < rows.length; i++) if (rows[i].previousElementSibling === rows[i - 1]) gaps.push(Math.round(rows[i].getBoundingClientRect().top - rows[i - 1].getBoundingClientRect().bottom))
+ return { boxed, primary: rows.filter((b) => b.classList.contains('ed-btn-primary')).length, gaps }
+ })
+ ok(look.boxed === 0 && look.primary === 0, `Share's actions are plain rows at rest — no fill, no frame, no primary (${look.boxed} boxed, ${look.primary} primary)`)
+ ok(look.gaps.length >= 4 && look.gaps.every((g) => g === 0), `adjacent Share rows touch, as in Save as (gaps ${look.gaps.join('/')})`)
+ const shareBottom = await p.evaluate(() => Math.round(document.querySelector('.ed-share-pop').getBoundingClientRect().bottom))
+ // your own People row: the name stays whole and the key fingerprint gives
+ // way (it was the other way round: "Guest (y…" beside a whole key). A
+ // mid-length name makes the row too narrow for both whatever the key is.
+ const me = await p.evaluate(() => {
+ try { localStorage.setItem('bento-author', 'Jordan Whitaker') } catch {}
+ const btn = document.querySelector('.ed-btn-share'); btn.click(); btn.click() // close + reopen = re-render
+ const who = document.querySelector('.ed-share-me .who'), where = document.querySelector('.ed-share-me .where'), row = document.querySelector('.ed-share-me')
+ const cut = (e) => e.scrollWidth > e.clientWidth + 1
+ return { who: who.textContent, whoCut: cut(who), keyCut: cut(where), over: row.scrollWidth > row.clientWidth + 1 }
+ })
+ ok(!me.whoCut && me.keyCut && !me.over, `your own People row keeps "${me.who}" whole and ellipses the key instead (name cut: ${me.whoCut}, key cut: ${me.keyCut})`)
+ ok(shareBottom <= 768, `the Share menu ends on a 768px laptop screen (bottom ${shareBottom})`)
+ await p.setViewportSize({ width: 1440, height: 900 })
+ await closeAll()
+ await theme('light')
+
+ // --- 2. D4 dialog titles ----------------------------------------------------
+ console.log('\nD4: dialog titles 17px/650\n')
+ const title = () => p.evaluate(() => { const h = document.querySelector('.ed-about-overlay h2'); const c = getComputedStyle(h); return `${c.fontSize}/${c.fontWeight}` })
+ await p.evaluate(() => document.querySelector('.ed-btn-help').click())
+ ok(await title() === '17px/650', `help sheet title ${await title()}`)
+
+ // --- 3. D8 shortcuts ----------------------------------------------------------
+ console.log('\nD8: help shortcuts in the interface face, right-aligned\n')
+ const k = await p.evaluate(() => {
+ const kbd = document.querySelector('.ed-help-row kbd'), row = kbd.parentElement
+ const col = parseFloat(getComputedStyle(row).gridTemplateColumns)
+ return { font: getComputedStyle(kbd).fontFamily, ui: getComputedStyle(document.body).fontFamily, right: kbd.getBoundingClientRect().right - row.getBoundingClientRect().left, col }
+ })
+ ok(k.font === k.ui && !/mono/i.test(k.font), `shortcut face = interface face (${k.font.split(',')[0]})`)
+ ok(Math.abs(k.right - k.col) < 1, `shortcut ends at its column's edge (${k.right.toFixed(1)} of ${k.col}px)`)
+ await closeAll()
+ await openSave()
+ await p.evaluate(() => [...document.querySelectorAll('.ed-save-menu .ed-btn')].find((b) => b.textContent.startsWith('Version history')).click())
+ await p.waitForSelector('.ed-version-box h2')
+ ok(await title() === '17px/650', `Version history title ${await title()}`)
+ await closeAll()
+
+ // --- 4. compact caret ---------------------------------------------------------
+ console.log('\ncompact tier: the Save caret keeps its ▾\n')
+ await p.setViewportSize({ width: 1100, height: 800 })
+ await p.waitForFunction(() => { const b = document.querySelector('.ed-topbar'); return b.classList.contains('ed-bar-compact') && !b.classList.contains('ed-bar-fold') })
+ const caret = await p.evaluate(() => { const s = document.querySelector('.ed-split-caret .ed-caret'); const r = s.getBoundingClientRect(); return { w: r.width, text: s.textContent, disp: getComputedStyle(s).display } })
+ ok(caret.disp !== 'none' && caret.w > 0 && caret.text === '▾', `▾ is drawn (${caret.disp}, ${caret.w.toFixed(1)}px)`)
+ // the glyph is decoration: the button's name stays its title, at every tier
+ ok(await p.getByRole('button', { name: 'Save as… — copy, new deck, password', exact: true }).count() === 1, 'the caret is still named "Save as… — copy, new deck, password", not "▾"')
+
+ // --- 5. phone rows --------------------------------------------------------------
+ console.log('\nphone: ⋯ rows read from the start edge\n')
+ await p.setViewportSize({ width: 390, height: 844 })
+ await p.waitForFunction(() => document.querySelector('.ed-topbar')?.classList.contains('ed-bar-fold'))
+ await p.evaluate(() => [...document.querySelectorAll('.ed-topbar .ed-phone-only > .ed-btn')].find((b) => b.textContent.includes('⋯')).click())
+ const rows = await p.evaluate(() => {
+ const menu = [...document.querySelectorAll('.ed-dropdown.open > .ed-menu')].pop()
+ return [...menu.querySelectorAll(':scope > .ed-btn')].filter((b) => b.getBoundingClientRect().width).map((b) => {
+ const kid = b.firstElementChild.getBoundingClientRect(), r = b.getBoundingClientRect()
+ return { name: b.textContent.trim().slice(0, 20), inset: kid.left - r.left, jc: getComputedStyle(b).justifyContent }
+ })
+ })
+ const centred = rows.filter((r) => r.jc === 'center' || r.inset > 20)
+ ok(rows.length >= 5 && centred.length === 0, `${rows.length} rows, all start-aligned${centred.length ? ' — centred: ' + centred.map((r) => `${r.name} (${r.inset.toFixed(0)}px)`).join(', ') : ''}`)
+ await closeAll()
+ await p.setViewportSize({ width: 1440, height: 900 })
+ await p.waitForFunction(() => !document.querySelector('.ed-topbar')?.classList.contains('ed-bar-fold'))
+
+ // --- 6. focus ring --------------------------------------------------------------
+ console.log('\nfocus: a designed ring, both themes\n')
+ const ring = () => p.evaluate(() => {
+ const a = document.activeElement, c = getComputedStyle(a)
+ const probe = document.createElement('div'); probe.style.color = 'var(--accent-ink)'; document.body.appendChild(probe)
+ const accentInk = getComputedStyle(probe).color; probe.remove()
+ let bgEl = a.closest('.ed-menu') ?? document.querySelector('.ed-topbar')
+ return { cls: a.className, style: c.outlineStyle, width: c.outlineWidth, color: c.outlineColor, offset: c.outlineOffset, accentInk, bg: getComputedStyle(bgEl).backgroundColor, visible: a.matches(':focus-visible') }
+ })
+ for (const th of THEMES) {
+ await theme(th)
+ await p.locator('.ed-title').click()
+ await p.keyboard.press('Shift+Tab') // back from the title to the logo / update chip
+ const bar = await ring()
+ ok(bar.visible && bar.style === 'solid' && bar.width === '2px' && bar.color === bar.accentInk && parseFloat(bar.offset) >= 2,
+ `${th}: a bar control shows a 2px --accent-ink ring outside it (${bar.cls}: ${bar.style} ${bar.width} ${bar.color} offset ${bar.offset})`)
+ const r1 = contrast(bar.color, bar.bg)
+ ok(r1 >= 3, `${th}: bar ring ${r1.toFixed(2)}:1 on the bar ≥ 3`)
+ await p.locator('.ed-split-caret').focus()
+ await p.keyboard.press('Enter')
+ await p.keyboard.press('Tab')
+ const row = await ring()
+ ok(row.visible && row.cls.includes('ed-btn') && row.style === 'solid' && parseFloat(row.offset) < 0,
+ `${th}: a menu row's ring sits inside it (offset ${row.offset})`)
+ const r2 = contrast(row.color, row.bg)
+ ok(r2 >= 3, `${th}: row ring ${r2.toFixed(2)}:1 on the menu ≥ 3`)
+ await closeAll()
+ }
+
+ // --- 7. dark menu shadow ----------------------------------------------------------
+ console.log('\nmenu shadow per theme\n')
+ const shadows = {}
+ for (const th of THEMES) {
+ await theme(th)
+ await openSave()
+ shadows[th] = await p.evaluate(() => getComputedStyle(document.querySelector('.ed-save-menu')).boxShadow)
+ await closeAll()
+ }
+ ok(/rgba\(20, 30, 45, 0\.14\)/.test(shadows.light), `light keeps navy at 14% (${shadows.light})`)
+ ok(shadows.dark !== shadows.light && /rgba\(0, 0, 0, 0\.5\)/.test(shadows.dark), `dark has its own, black at 50% (${shadows.dark})`)
+
+ ok(errors.length === 0, `no page errors${errors.length ? ': ' + errors.join('; ') : ''}`)
+} finally { await browser.close() }
+
+console.log(`\n${checks - failures}/${checks} checks passed`)
+process.exit(failures ? 1 : 0)
diff --git a/slides/src/editor/editor.ts b/slides/src/editor/editor.ts
index 4cc81012..e7f8f626 100644
--- a/slides/src/editor/editor.ts
+++ b/slides/src/editor/editor.ts
@@ -109,6 +109,30 @@ export function canWriteDeck(collab: { role?: string } | undefined): boolean {
return !collab || collab.role === undefined || collab.role === 'writer'
}
+/**
+ * A menu row's label and its description (maintainer ruling D2, as revised
+ * 2026-09-26: "all the extra text describing the entry can be mouseovers").
+ * The row stays ONE 30px line; the description is its hover tooltip (the
+ * native `title`) and, because a tooltip is not announced reliably and never
+ * appears on a phone, also its accessible DESCRIPTION via aria-describedby on
+ * a visually-hidden node. The name keeps an element of its own and is the
+ * row's accessible NAME. The hidden node sits inside the label span so the
+ * bar's compact tier, which hides and restores `.ed-btn > span`, carries it
+ * along. An empty description adds nothing.
+ */
+let menuDescSeq = 0
+function menuLabel(label: string, desc: string, row: HTMLElement): HTMLSpanElement {
+ if (!desc) return Object.assign(document.createElement('span'), { textContent: label })
+ const span = document.createElement('span')
+ const name = Object.assign(document.createElement('span'), { className: 'ed-mi-name', textContent: label })
+ const note = Object.assign(document.createElement('span'), { className: 'ed-sr-only', textContent: desc, id: `ed-mi-desc-${++menuDescSeq}` })
+ span.append(name, note)
+ row.title = desc
+ row.setAttribute('aria-label', label)
+ row.setAttribute('aria-describedby', note.id)
+ return span
+}
+
export class Editor {
private canvas!: SlideCanvas
private panel!: PropsPanel
@@ -467,7 +491,7 @@ export class Editor {
if ((e as AnimationEvent).animationName !== 'ed-runner-fade') return
pill.classList.remove('ed-hint-pulse')
})
- const caret = btn('<span class="ed-caret">▴</span>', '', () => pill.classList.toggle('open'),
+ const caret = btn('<span class="ed-caret" aria-hidden="true">▴</span>', '', () => pill.classList.toggle('open'),
t('More ways to present'))
caret.classList.add('ed-pill-caret')
const pmenu = div('ed-menu')
@@ -886,7 +910,7 @@ export class Editor {
private saveDropdown(): HTMLElement {
const wrap = div('ed-dropdown')
const menu = div('ed-menu ed-save-menu')
- const trigger = btn('<span class="ed-caret">▾</span>', '', () => {
+ const trigger = btn('<span class="ed-caret" aria-hidden="true">▾</span>', '', () => {
wrap.classList.toggle('open')
if (wrap.classList.contains('open')) rebuild()
}, t('Save as… — copy, new deck, password'))
@@ -923,8 +947,7 @@ export class Editor {
const b = document.createElement('button')
b.className = 'ed-btn'
if (icon) b.innerHTML = icon
- b.appendChild(Object.assign(document.createElement('span'), { textContent: label }))
- b.title = title
+ b.appendChild(menuLabel(label, title, b))
b.addEventListener('click', () => {
close()
onClick()
@@ -1349,12 +1372,13 @@ export class Editor {
panel.appendChild(e)
return e
}
- const action = (icon: string, label: string, primary: boolean, onClick: () => void, title = '') => {
+ // plain menu rows, as in Save as — the section heading and the icons mark
+ // them as commands; boxing each one only made the panel busier
+ const action = (icon: string, label: string, onClick: () => void, title = '') => {
const b = document.createElement('button')
- b.className = primary ? 'ed-btn ed-btn-primary ed-share-btn' : 'ed-btn ed-share-btn'
+ b.className = 'ed-btn ed-share-btn'
if (icon) b.innerHTML = icon
- b.appendChild(Object.assign(document.createElement('span'), { textContent: label }))
- if (title) b.title = title
+ b.appendChild(menuLabel(label, title, b))
b.addEventListener('click', onClick)
panel.appendChild(b)
return b
@@ -1511,19 +1535,19 @@ export class Editor {
const label = div('ed-share-label')
label.textContent = t('Share a copy')
panel.appendChild(label)
- action(ICONS.share, t('Invite to edit…'), true, () => void this.inviteToEdit(),
+ action(ICONS.share, t('Invite to edit…'), () => void this.inviteToEdit(),
t('Saves a copy to send. Whoever opens it edits this deck live with you (end-to-end encrypted); you stay the owner and can remove them from the People list.'))
- action(ICONS.eye, t('View-only copy…'), false, () => void this.saveReaderCopy(),
+ action(ICONS.eye, t('View-only copy…'), () => void this.saveReaderCopy(),
t('A live viewer: follows every edit as it happens but can never change the deck — the relay enforces it.'))
- action(ICONS.slideshow, t('Present-only file…'), false, () => void this.savePresentationPackage(),
+ action(ICONS.slideshow, t('Present-only file…'), () => void this.savePresentationPackage(),
t('A sealed hand-out that opens straight into the show — no editor, no live connection.'))
- action(ICONS.broadcast, t('Audience copy…'), false, () => void this.saveAudienceCopy(),
+ action(ICONS.broadcast, t('Audience copy…'), () => void this.saveAudienceCopy(),
t('A hand-out for a live show: opens into the presentation and follows your slides while you are live. Never carries your speaker notes or comments.'))
if (this.store.doc.collab?.audience) {
- action(ICONS.broadcast, t('Issue new tickets…'), false, () => void this.issueNewTickets(),
+ action(ICONS.broadcast, t('Issue new tickets…'), () => void this.issueNewTickets(),
t('Replaces the audience tickets: every audience copy saved so far stops working.'))
}
- action(ICONS.template, t('Template…'), false, () => void this.saveAsTemplate(),
+ action(ICONS.template, t('Template…'), () => void this.saveAsTemplate(),
t('A reusable starter: everyone who opens it gets their own fresh, independent deck.'))
} else {
note(t('This is a view-only copy — it follows the live session but can’t change the deck.'))
@@ -1533,17 +1557,17 @@ export class Editor {
if (canWrite) {
panel.appendChild(div('ed-share-sep'))
if (on) {
- action(ICONS.stop, t('Stop sharing'), false, () => {
+ action(ICONS.stop, t('Stop sharing'), () => {
if (!this.session) return
stopSharing(this.session, this.store)
this.wireOnlineStatus()
this.renderSharePanel()
}, t('Disconnect this deck from the live session. Copies keep their last state and can rejoin if you go live again.'))
} else {
- action(ICONS.live, t('Go live'), false, () => void this.goLive().then(() => this.renderSharePanel()),
+ action(ICONS.live, t('Go live'), () => void this.goLive().then(() => this.renderSharePanel()),
t('Connect to the live session without saving a new copy — copies you sent earlier will meet you there.'))
}
- action(ICONS.key, t('Reset access…'), false, async () => {
+ action(ICONS.key, t('Reset access…'), async () => {
if (!this.session) return
if (!confirm(t('Reset access? Every copy you’ve sent stops syncing; only copies saved after this can join.'))) return
await rotateKeys(this.session, this.store)
diff --git a/slides/src/styles.css b/slides/src/styles.css
index 8e2590bd..cbf87192 100644
--- a/slides/src/styles.css
+++ b/slides/src/styles.css
@@ -292,6 +292,10 @@ a.ed-btn { text-decoration: none; } /* the update block's "What's new" link is
z-index: 50;
min-width: 150px;
}
+/* The light shadow is navy at 14%, which on the dark chrome is a navy smudge
+ on navy and lifts nothing off the page. Dark gets black, deeper — the same
+ move --slide-shadow makes for the canvas. */
+:root[data-theme="dark"] .ed-menu { box-shadow: 0 8px 24px rgb(0 0 0 / 0.5); }
/* DIRECT child, not any descendant. Phone chrome demotes whole dropdown
widgets (Share, Language) into the ⋯ menu, so a descendant selector opened
their menus too — ⋯ came up with the entire language list already unrolled
@@ -740,6 +744,10 @@ a.ed-btn { text-decoration: none; } /* the update block's "What's new" link is
align-items: center;
justify-content: center;
}
+/* D4: a dialog title is 17px/650 (the kernel's .bkd-title). Before, this was
+ the browser's h2 — 1.5em of 13px = 19.5px at 700 — in help, Version history
+ and every other .ed-about card. */
+.ed-about h2 { font-size: 17px; font-weight: 650; }
.ed-about {
/* 440 rather than 360: release notes ride inline in the manifest now, and a
narrower box turned every bullet into two wrapped lines. The calc() keeps
@@ -1058,10 +1066,12 @@ a.ed-btn { text-decoration: none; } /* the update block's "What's new" link is
color: var(--muted); margin: 0 0 6px;
}
.ed-help-row { display: grid; grid-template-columns: 128px 1fr; gap: 12px; align-items: baseline; padding: 3px 0; font-size: 13px; }
+/* D8: shortcuts in the interface face, not monospace, right-aligned against
+ what they do — the column reads as a list of keys, as a menu's does */
.ed-help-row kbd {
- font: 600 12px ui-monospace, SFMono-Regular, Menlo, monospace;
+ font: inherit; font-size: 12px; font-weight: 600; font-variant-numeric: tabular-nums;
background: var(--chrome-2); border: 1px solid var(--line);
- border-radius: 5px; padding: 2px 6px; color: var(--ink); white-space: nowrap; justify-self: start;
+ border-radius: 5px; padding: 2px 6px; color: var(--ink); white-space: nowrap; justify-self: end;
}
.ed-help-tips { margin: 4px 0 0; padding-inline-start: 18px; font-size: 13px; line-height: 1.5; color: var(--ink); }
.ed-help-tips li { margin: 3px 0; }
@@ -1935,22 +1945,16 @@ body.ed-col-resizing { cursor: col-resize; user-select: none; }
color: #b8860b;
}
.ed-share-status.ok { color: #2e8b57; }
-.ed-share-btn {
- justify-content: center;
- font-size: 12.5px;
- padding: 6px 10px;
- white-space: normal;
- text-align: center;
- line-height: 1.35;
-}
-/* share actions read as BUTTONS at rest, not hover-reveal text */
-.ed-share-btn:not(.ed-btn-primary) {
- background: var(--chrome);
- border: 1px solid var(--line);
-}
-.ed-share-btn:not(.ed-btn-primary):hover { background: var(--chrome-2); }
-.ed-share-btn { width: 100%; justify-content: flex-start; text-align: start; }
+/* Share's actions are plain menu rows, the same as Save as: 12.5px, one line,
+ a hover fill and nothing at rest. They were boxed buttons (2026-07-20, so
+ they would not read as text among the panel's notes); the SHARE A COPY
+ heading and the icons do that now, and the boxes made the panel busier. */
+.ed-share-btn { width: 100%; justify-content: flex-start; text-align: start; font-size: 12.5px; }
.ed-share-btn svg { flex: none; }
+/* the panel's 7px gap spaces its sections (name, people, status); between two
+ action rows it would make a list of rows look like a stack of chips —
+ adjacent rows touch, as they do in every other menu */
+.ed-share-pop > .ed-share-btn + .ed-share-btn { margin-block-start: -7px; }
/* divider usable in any dropdown menu */
.ed-menu-sep { height: 1px; background: var(--line); margin: 3px 2px; }
@@ -2113,6 +2117,14 @@ body.ed-col-resizing { cursor: col-resize; user-select: none; }
}
.ed-share-me .who { font-weight: 600; }
.ed-share-me .where { margin-inline-start: auto; color: var(--muted); font-size: 11px; font-variant-numeric: tabular-nums; }
+/* Your own row: the NAME stays whole and the key gives way. The shared
+ .ed-share-peer rules below do the opposite (a peer's "on slide 3" is short;
+ their name is what can run long), which cut "Guest (you)" to "Guest (y…"
+ beside a 20-character key. The key is a fingerprint you compare by its
+ start, and its full form is in the row's tooltip. A very long name still
+ yields at 65%. Doubled class: the peer rules come later in the file. */
+.ed-share-peer.ed-share-me .who { flex: none; max-width: 65%; }
+.ed-share-peer.ed-share-me .where { flex: 1 1 0; min-width: 0; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; text-align: end; }
.ed-share-peer {
display: flex;
align-items: center;
@@ -2227,6 +2239,9 @@ body.ed-col-resizing { cursor: col-resize; user-select: none; }
.ed-title { flex: 0 1 220px; min-width: 48px; }
.ed-topbar.ed-bar-compact .ed-btn > span { display: none; } /* icons + tooltips take over */
.ed-topbar.ed-bar-compact .ed-btn.ed-btn-update > span { display: inline; } /* version chip is signal */
+/* the Save caret's ▾ is its only content, not a label — hiding it left an
+ empty 16px button */
+.ed-topbar.ed-bar-compact .ed-btn > span.ed-caret { display: inline; }
/* …but NEVER inside an open dropdown/menu — those items are text; hiding
their labels left icon-only mystery menus on phones. */
.ed-topbar.ed-bar-compact .ed-menu .ed-btn > span,
@@ -2333,7 +2348,9 @@ body.ed-col-resizing { cursor: col-resize; user-select: none; }
.ed-topbar .ed-btn { min-width: 44px; min-height: 44px; justify-content: center; }
/* the wordmark is a button too (About), and on a phone it is the mark alone */
.ed-topbar .ed-logo { min-width: 44px; min-height: 44px; justify-content: center; }
- .ed-topbar .ed-menu .ed-btn { min-width: 0; } /* menu rows are text, not targets */
+ /* menu rows are text, not targets — and read from the start edge; the
+ centring above is for the bar's icon buttons and used to leak in here */
+ .ed-topbar .ed-menu .ed-btn { min-width: 0; justify-content: flex-start; }
.ed-title { flex: 0 1 220px; }
.ed-phone-tools {
display: flex;
@@ -2436,6 +2453,29 @@ body.ed-col-resizing { cursor: col-resize; user-select: none; }
}
.ed-save-menu { min-width: 190px; }
.ed-save-menu .ed-btn { font-size: 12.5px; }
+/* D2 (revised 2026-09-26): Save as and Share keep one-line rows and put each
+ description in the tooltip, with the same text in a visually-hidden node for
+ aria-describedby (editor.ts menuLabel). The Save list keeps spaces' width
+ for the same list (240–264). */
+.ed-save-menu { width: min(264px, calc(100vw - 16px)); }
+/* A long list on a short window (phone landscape, a split screen) must not
+ run off the bottom with its last commands unreachable: it scrolls within
+ the space under the bar. Safe to make a scroll box (hard-won #10): nothing in
+ it floats. --ed-bar-bottom is published by editor.ts. */
+.ed-save-menu { max-height: calc(100dvh - var(--ed-bar-bottom, 56px) - 12px); overflow-y: auto; }
+/* present for assistive tech, absent for the eye */
+.ed-sr-only {
+ position: absolute; width: 1px; height: 1px; padding: 0; margin: -1px;
+ overflow: hidden; clip: rect(0 0 0 0); clip-path: inset(50%); white-space: nowrap; border: 0;
+}
+
+/* A designed keyboard ring, the kernel's (kernel/src/ui/menu.css .bkm-item):
+ --accent-ink, 2px. Bar and dialog buttons draw it OUTSIDE, on the surface
+ they sit on (inside, it would sit on Save's ink fill); rows in a menu draw
+ it INSIDE, where the list's own padding would clip it. :focus-visible, so
+ a pointer never sees it. */
+.ed-btn:focus-visible, .ed-logo:focus-visible { outline: 2px solid var(--accent-ink); outline-offset: 2px; }
+.ed-menu .ed-btn:focus-visible { outline-offset: -2px; }
/* when the adjacent panel is collapsed the chevron pins fully on-screen,
docked to the edge like a drawer pull */
.ed-sidebar.ed-collapsed + .ed-resizer .ed-panel-toggle {