Lightweight server monitoring with historical data, docker stats, and alerts.
agent: revert #2275 warning on certain SMART attributes (#2296, #2308, #2347)
henrygd18f7a4bbc09a
diff --git a/agent/smart.go b/agent/smart.goindex bcbdd91af..28a5ad81e 100644--- a/agent/smart.go+++ b/agent/smart.go@@ -931,9 +931,6 @@ func (sm *SmartManager) parseSmartForSata(output []byte, deviceType string) (booif parsed, ok := smart.ParseSmartRawValueString(attr.Raw.String); ok {rawValue = parsed}- if smartData.SmartStatus == "PASSED" && rawValue > 0 && (attr.ID == 5 || attr.ID == 197 || attr.ID == 198) {- smartData.SmartStatus = "WARNING"- }smartAttr := &smart.SmartAttribute{ID: attr.ID,Name: attr.Name,diff --git a/agent/smart_test.go b/agent/smart_test.goindex 4850368eb..f77d109a8 100644--- a/agent/smart_test.go+++ b/agent/smart_test.go@@ -7,7 +7,6 @@ import ("fmt""os""path/filepath"- "strconv""testing""github.com/henrygd/beszel/internal/entities/smart"@@ -90,27 +89,6 @@ func TestParseSmartForSata(t *testing.T) {}}-func TestParseSmartForSataWarnsForCriticalAttributes(t *testing.T) {- for _, attrID := range []int{5, 197, 198} {- t.Run("attribute "+strconv.Itoa(attrID), func(t *testing.T) {- jsonPayload := []byte(fmt.Sprintf(`{- "smartctl": {"exit_status": 0},- "device": {"name": "/dev/sda", "type": "sat"},- "model_name": "Example",- "serial_number": "WARNING%d",- "smart_status": {"passed": true},- "temperature": {"current": 30},- "ata_smart_attributes": {"table": [{"id": %d, "raw": {"value": 1, "string": "1"}}]}- }`, attrID, attrID))-- sm := &SmartManager{SmartDataMap: make(map[string]*smart.SmartData)}- hasData, _ := sm.parseSmartForSata(jsonPayload, "")- require.True(t, hasData)- assert.Equal(t, "WARNING", sm.SmartDataMap[fmt.Sprintf("WARNING%d", attrID)].SmartStatus)- })- }-}-func TestParseSmartForSataPreservesFailedAndUnknownStatus(t *testing.T) {for _, test := range []struct {name string