Skip to content

Lightweight server monitoring with historical data, docker stats, and alerts.

fix(site): move formatMicroseconds to the next unit when rounding reaches it (#2799)

kevinaec15f83284a
diff --git a/internal/site/src/lib/utils.ts b/internal/site/src/lib/utils.ts
index cc70b93bf..86d9433ad 100644
--- a/internal/site/src/lib/utils.ts
+++ b/internal/site/src/lib/utils.ts
@@ -223,15 +223,15 @@ export function formatMicroseconds(microseconds: number, fixedDigits = true): st
const digitFormatter = fixedDigits ? decimalString : toFixedFloat
- if (microseconds < 1_000_000) {
- const milliseconds = microseconds / 1000
- const digits = milliseconds >= 10 ? 1 : 2
- return `${digitFormatter(milliseconds, digits)}ms`
+ // Thresholds are where the printed value rounds up to the next unit or
+ // digit count (999.95ms -> 1.00s, 9.995ms -> 10.0ms, 9.995s -> 10.0s)
+ if (microseconds < 999_950) {
+ const digits = microseconds >= 9_995 ? 1 : 2
+ return `${digitFormatter(microseconds / 1000, digits)}ms`
}
- const seconds = microseconds / 1_000_000
- const digits = seconds >= 10 ? 1 : 2
- return `${digitFormatter(seconds, digits)}s`
+ const digits = microseconds >= 9_995_000 ? 1 : 2
+ return `${digitFormatter(microseconds / 1_000_000, digits)}s`
}
/** Get value from local or session storage */
diff --git a/internal/site/tests/utils.test.ts b/internal/site/tests/utils.test.ts
index d8fcbcbf4..0533c964f 100644
--- a/internal/site/tests/utils.test.ts
+++ b/internal/site/tests/utils.test.ts
@@ -19,6 +19,20 @@ describe("formatMicroseconds", () => {
expect(formatMicroseconds(12_000_000)).toBe("12.0s")
})
+ test("moves to the next unit when rounding reaches it", () => {
+ expect(formatMicroseconds(999_960)).toBe("1.00s")
+ expect(formatMicroseconds(999_999)).toBe("1.00s")
+ expect(formatMicroseconds(999_940)).toBe("999.9ms")
+ expect(formatMicroseconds(9_996)).toBe("10.0ms")
+ expect(formatMicroseconds(9_990)).toBe("9.99ms")
+ expect(formatMicroseconds(9_996_000)).toBe("10.0s")
+ expect(formatMicroseconds(999_999, false)).toBe("1s")
+ expect(formatMicroseconds(9_996, false)).toBe("10ms")
+ expect(formatMicroseconds(9_995)).toBe("10.0ms")
+ expect(formatMicroseconds(999_950)).toBe("1.00s")
+ expect(formatMicroseconds(9_995_000)).toBe("10.0s")
+ })
+
test("formats with fixedDigits = false (used for chart y-axis ticks)", () => {
expect(formatMicroseconds(500, false)).toBe("500μs")
expect(formatMicroseconds(500.5, false)).toBe("500.5μs")