Skip to content

Business intelligence made simple

Fixed bug with Slack notifications not sending - closes #246 closes #247

Andrew Kane4ae2d73d7143
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7c4f515b..112ac5ad 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,6 @@
## 2.2.0 [unreleased]
+- Fixed bug with Slack notifications not sending
- Dropped support for Rails 4.2
## 2.1.0
diff --git a/app/models/blazer/check.rb b/app/models/blazer/check.rb
index 194c3797..5f14ecad 100644
--- a/app/models/blazer/check.rb
+++ b/app/models/blazer/check.rb
@@ -67,8 +67,8 @@ module Blazer
end
# do not notify on creation, except when not passing
- if (state_was != "new" || state != "passing") && state != state_was && emails.present?
- Blazer::CheckMailer.state_change(self, state, state_was, result.rows.size, message, result.columns, result.rows.first(10).as_json, result.column_types, check_type).deliver_now
+ if (state_was != "new" || state != "passing") && state != state_was
+ Blazer::CheckMailer.state_change(self, state, state_was, result.rows.size, message, result.columns, result.rows.first(10).as_json, result.column_types, check_type).deliver_now if emails.present?
Blazer::SlackNotifier.state_change(self, state, state_was, result.rows.size, message, check_type)
end
save! if changed?