Business intelligence made simple
Added validation and fixed flash of unstylized content
Andrew Kane62d35ef15ec3
diff --git a/app/models/blazer/check.rb b/app/models/blazer/check.rbindex 94a80851..4c4d9a3d 100644--- a/app/models/blazer/check.rb+++ b/app/models/blazer/check.rb@@ -2,6 +2,8 @@ module Blazerclass Check < ActiveRecord::Basebelongs_to :blazer_query, class_name: "Blazer::Query"+ validates :blazer_query_id, presence: true+def update_state(rows, error)self.state =if errordiff --git a/app/views/blazer/checks/_form.html.erb b/app/views/blazer/checks/_form.html.erbindex ddcd733d..27e3864a 100644--- a/app/views/blazer/checks/_form.html.erb+++ b/app/views/blazer/checks/_form.html.erb@@ -1,8 +1,18 @@<p class="text-muted">Checks are designed to identify bad data. A check fails if there are any results.</p>++<% if @check.errors.any? %>+ <div class="alert alert-danger"><%= @check.errors.full_messages.first %></div>+<% end %>+<%= form_for @check do |f| %><div class="form-group"><%= f.label :blazer_query_id, "Query" %>- <%= f.select :blazer_query_id, Blazer::Query.order(:name).map { |q| [q.name, q.id] } %>+ <div class="hide">+ <%= f.select :blazer_query_id, Blazer::Query.order(:name).map { |q| [q.name, q.id] }, {include_blank: true} %>+ </div>+ <script>+ $("#check_blazer_query_id").selectize().parents(".hide").removeClass("hide");+ </script></div><div class="form-group"><%= f.label :emails %>@@ -16,8 +26,3 @@<%= f.submit "Save", class: "btn btn-success" %></p><% end %>--<script>- $("#check_blazer_query_id").selectize();- $("#check_schedule").selectize({"allowEmptyOption": true});-</script>