Skip to content

Business intelligence made simple

Fixed cohort analysis for MySQL - fixes #372

Andrew Kane657e57d8b545
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a3234f63..4e444003 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,7 @@
## 2.5.0 (unreleased)
- Added support for Slack OAuth tokens
+- Fixed cohort analysis for MySQL
## 2.4.8 (2021-12-07)
diff --git a/README.md b/README.md
index 46577ee8..7bec5b75 100644
--- a/README.md
+++ b/README.md
@@ -412,7 +412,7 @@ SELECT users.id AS user_id, orders.created_at AS conversion_time, users.created_
FROM users LEFT JOIN orders ON orders.user_id = users.id
```
-This feature requires PostgreSQL or MySQL.
+This feature requires PostgreSQL or MySQL 8.
## Anomaly Detection
diff --git a/lib/blazer/adapters/sql_adapter.rb b/lib/blazer/adapters/sql_adapter.rb
index f2d90a9e..0d34cbb5 100644
--- a/lib/blazer/adapters/sql_adapter.rb
+++ b/lib/blazer/adapters/sql_adapter.rb
@@ -146,7 +146,7 @@ module Blazer
date_sql = "CAST(DATE_FORMAT(#{time_sql}, '%Y-%m-01') AS DATE)"
date_params = [tzname]
end
- bucket_sql = "CAST(CEIL(TIMESTAMPDIFF(SECOND, cohorts.cohort_time, query.conversion_time) / ?) AS INTEGER)"
+ bucket_sql = "CAST(CEIL(TIMESTAMPDIFF(SECOND, cohorts.cohort_time, query.conversion_time) / ?) AS SIGNED)"
else
date_sql = "date_trunc(?, cohorts.cohort_time::timestamptz AT TIME ZONE ?)::date"
date_params = [period, tzname]