Skip to content

Business intelligence made simple

DRY email logic

Andrew Kane68d2bab8297b
diff --git a/app/models/blazer/check.rb b/app/models/blazer/check.rb
index 4c4d9a3d..2ca3f43e 100644
--- a/app/models/blazer/check.rb
+++ b/app/models/blazer/check.rb
@@ -4,6 +4,10 @@ module Blazer
validates :blazer_query_id, presence: true
+ def split_emails
+ emails.to_s.split(",").map(&:strip)
+ end
+
def update_state(rows, error)
self.state =
if error
diff --git a/app/views/blazer/checks/index.html.erb b/app/views/blazer/checks/index.html.erb
index 51962918..9016c8f2 100644
--- a/app/views/blazer/checks/index.html.erb
+++ b/app/views/blazer/checks/index.html.erb
@@ -26,7 +26,7 @@
</td>
<td>
<ul class="list-unstyled" style="margin-bottom: 0;">
- <% check.emails.to_s.split(",").each do |email| %>
+ <% check.split_emails.each do |email| %>
<li><%= email %></li>
<% end %>
</ul>
diff --git a/lib/blazer.rb b/lib/blazer.rb
index b293cb9c..1e285233 100644
--- a/lib/blazer.rb
+++ b/lib/blazer.rb
@@ -80,7 +80,7 @@ module Blazer
def self.send_failing_checks
emails = {}
Blazer::Check.includes(:blazer_query).where(state: %w[failing error]).find_each do |check|
- check.emails.to_s.split(",").map(&:strip).each do |email|
+ check.split_emails.each do |email|
(emails[email] ||= []) << check
end
end