Skip to content

Business intelligence made simple

Added show and hide functions [skip ci]

Andrew Kane9fc672922905
diff --git a/app/assets/javascripts/blazer/application.js b/app/assets/javascripts/blazer/application.js
index fef0532b..b5ca9da0 100644
--- a/app/assets/javascripts/blazer/application.js
+++ b/app/assets/javascripts/blazer/application.js
@@ -82,10 +82,18 @@ function preventBackspaceNav() {
preventBackspaceNav()
+function show(element) {
+ element.classList.remove("hide")
+}
+
+function hide(element) {
+ element.classList.add("hide")
+}
+
function toggle(element, found) {
if (found) {
- element.classList.remove("hide")
+ show(element)
} else {
- element.classList.add("hide")
+ hide(element)
}
}
diff --git a/app/views/blazer/checks/_form.html.erb b/app/views/blazer/checks/_form.html.erb
index f9ce6823..195a50d9 100644
--- a/app/views/blazer/checks/_form.html.erb
+++ b/app/views/blazer/checks/_form.html.erb
@@ -2,7 +2,7 @@
function selectize(id, options) {
const element = document.getElementById(id)
$(element).selectize(options)
- element.closest(".hide").classList.remove("hide")
+ show(element.closest(".hide"))
}
<% end %>
diff --git a/app/views/blazer/dashboards/_form.html.erb b/app/views/blazer/dashboards/_form.html.erb
index bcfec2d2..9c6f13a9 100644
--- a/app/views/blazer/dashboards/_form.html.erb
+++ b/app/views/blazer/dashboards/_form.html.erb
@@ -51,7 +51,7 @@
li.append(span, query.name, input)
queriesList.append(li)
- queriesGroup.classList.remove("hide")
+ show(queriesGroup)
}
for (const query of dashboardQueries) {
@@ -64,7 +64,7 @@
element.closest("li").remove()
if (queriesList.querySelectorAll("li").length == 0) {
- queriesGroup.classList.add("hide")
+ hide(queriesGroup)
}
}
})
@@ -91,8 +91,8 @@
}
})
- queryId.closest(".hide").classList.remove("hide")
- actions.classList.remove("hide")
+ show(queryId.closest(".hide"))
+ show(actions)
Sortable.create(queriesList)
<% end %>
diff --git a/app/views/blazer/queries/_form.html.erb b/app/views/blazer/queries/_form.html.erb
index a5df0053..decfa4c1 100644
--- a/app/views/blazer/queries/_form.html.erb
+++ b/app/views/blazer/queries/_form.html.erb
@@ -92,19 +92,19 @@
}
function startRunning() {
- runButton.classList.add("hide")
+ hide(runButton)
results.replaceChildren()
- results.classList.add("hide")
+ hide(results)
results.classList.remove("query-error")
- cancelButton.classList.remove("hide")
- loading.classList.remove("hide")
+ show(cancelButton)
+ show(loading)
}
function stopRunning() {
- cancelButton.classList.add("hide")
- loading.classList.add("hide")
- runButton.classList.remove("hide")
- results.classList.remove("hide")
+ hide(cancelButton)
+ hide(loading)
+ show(runButton)
+ show(results)
}
function run(e) {
@@ -217,5 +217,5 @@
showEditor()
- document.getElementById("app").classList.remove("hide")
+ show(document.getElementById("app"))
<% end %>
diff --git a/app/views/blazer/queries/home.html.erb b/app/views/blazer/queries/home.html.erb
index 7188c425..91fc1513 100644
--- a/app/views/blazer/queries/home.html.erb
+++ b/app/views/blazer/queries/home.html.erb
@@ -142,10 +142,10 @@
}
if (more) {
- loading.classList.remove("hide")
+ show(loading)
$.getJSON(Routes.queries_path(), function (data) {
- loading.classList.add("hide")
+ hide(loading)
const newItems = []
for (const query of data) {