Skip to content

Business intelligence made simple

Better types for SODA

Andrew Kanec2159f4ac4e8
diff --git a/lib/blazer/adapters/soda_adapter.rb b/lib/blazer/adapters/soda_adapter.rb
index 9b2dea7b..0604e0d3 100644
--- a/lib/blazer/adapters/soda_adapter.rb
+++ b/lib/blazer/adapters/soda_adapter.rb
@@ -50,14 +50,27 @@ module Blazer
# nothing to do for boolean
case column_types[column]
when "number"
- rows.each do |row|
- v = row[i].to_f
- row[i] = v == v.to_i ? v.to_i : v
+ # check if likely an integer column
+ if rows.all? { |r| r[i].to_i == r[i].to_f }
+ rows.each do |row|
+ row[i] = row[i].to_i
+ end
+ else
+ rows.each do |row|
+ row[i] = row[i].to_f
+ end
end
when "floating_timestamp"
- utc = ActiveSupport::TimeZone["Etc/UTC"]
- rows.each do |row|
- row[i] = utc.parse(row[i])
+ # check if likely a date column
+ if rows.all? { |r| r[i].end_with?("T00:00:00.000") }
+ rows.each do |row|
+ row[i] = Date.parse(row[i])
+ end
+ else
+ utc = ActiveSupport::TimeZone["Etc/UTC"]
+ rows.each do |row|
+ row[i] = utc.parse(row[i])
+ end
end
end
end