Skip to content

Business intelligence made simple

Improved check tests [skip ci]

Andrew Kanec9ae0908cb63
diff --git a/test/checks_test.rb b/test/checks_test.rb
index 6f2f2e1e..d83584e8 100644
--- a/test/checks_test.rb
+++ b/test/checks_test.rb
@@ -11,9 +11,39 @@ class ChecksTest < ActionDispatch::IntegrationTest
assert_response :success
end
- def test_run
+ def test_bad_data
query = create_query
- check = Blazer::Check.create!(query: query, schedule: "5 minutes", emails: "[email protected]", check_type: "bad_data")
+ check = create_check(query: query, check_type: "bad_data")
+
+ Blazer.run_checks(schedule: "5 minutes")
+ check.reload
+ assert_equal "failing", check.state
+
+ query.update!(statement: "SELECT 1 LIMIT 0")
+
+ Blazer.run_checks(schedule: "5 minutes")
+ check.reload
+ assert_equal "passing", check.state
+ end
+
+ def test_missing_data
+ query = create_query
+ check = create_check(query: query, check_type: "missing_data")
+
+ Blazer.run_checks(schedule: "5 minutes")
+ check.reload
+ assert_equal "passing", check.state
+
+ query.update!(statement: "SELECT 1 LIMIT 0")
+
+ Blazer.run_checks(schedule: "5 minutes")
+ check.reload
+ assert_equal "failing", check.state
+ end
+
+ def test_emails
+ query = create_query
+ check = create_check(query: query, check_type: "bad_data", emails: "[email protected]")
assert_emails 0 do
Blazer.send_failing_checks
@@ -27,4 +57,8 @@ class ChecksTest < ActionDispatch::IntegrationTest
Blazer.send_failing_checks
end
end
+
+ def create_check(**attributes)
+ Blazer::Check.create!(schedule: "5 minutes", **attributes)
+ end
end
diff --git a/test/test_helper.rb b/test/test_helper.rb
index a51885d0..c31a728d 100644
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -22,7 +22,7 @@ class ActionDispatch::IntegrationTest
assert_response :success
end
- def create_query
- Blazer::Query.create!(statement: "SELECT 1", data_source: "main", status: "active")
+ def create_query(statement: "SELECT 1")
+ Blazer::Query.create!(statement: statement, data_source: "main", status: "active")
end
end