Skip to content

Business intelligence made simple

Improved redirect tests

Andrew Kaned9be13798af5
diff --git a/test/checks_test.rb b/test/checks_test.rb
index 1019a3c8..bd293c5f 100644
--- a/test/checks_test.rb
+++ b/test/checks_test.rb
@@ -35,7 +35,7 @@ class ChecksTest < ActionDispatch::IntegrationTest
query = create_query
post blazer.checks_path(params: {check: {query_id: query.id, schedule: "5 minutes", check_type: "bad_data", emails: "[email protected]"}})
- assert_response :redirect
+ assert_redirected_to blazer.query_path(query)
end
def test_edit
@@ -51,7 +51,7 @@ class ChecksTest < ActionDispatch::IntegrationTest
check = create_check(query: query, check_type: "bad_data")
patch blazer.check_path(check, params: {check: {schedule: "1 hour"}})
- assert_response :redirect
+ assert_redirected_to blazer.query_path(query)
check.reload
assert_equal "1 hour", check.schedule
@@ -62,7 +62,7 @@ class ChecksTest < ActionDispatch::IntegrationTest
check = create_check(query: query, check_type: "bad_data")
delete blazer.check_path(check)
- assert_response :redirect
+ assert_redirected_to blazer.checks_path
assert_raises(ActiveRecord::RecordNotFound) do
check.reload
@@ -74,7 +74,7 @@ class ChecksTest < ActionDispatch::IntegrationTest
check = create_check(query: query, check_type: "bad_data")
get blazer.run_check_path(check)
- assert_response :redirect
+ assert_redirected_to blazer.query_path(query)
end
def test_bad_data
diff --git a/test/dashboards_test.rb b/test/dashboards_test.rb
index 426de4cf..200be165 100644
--- a/test/dashboards_test.rb
+++ b/test/dashboards_test.rb
@@ -20,14 +20,14 @@ class DashboardsTest < ActionDispatch::IntegrationTest
def test_destroy
dashboard = create_dashboard
delete blazer.dashboard_path(dashboard)
- assert_response :redirect
+ assert_redirected_to blazer.root_path
end
def test_refresh
dashboard = create_dashboard
dashboard.queries << create_query
post blazer.refresh_dashboard_path(dashboard)
- assert_response :redirect
+ assert_redirected_to blazer.dashboard_path(dashboard)
end
def create_dashboard
diff --git a/test/permissions_test.rb b/test/permissions_test.rb
index d1f34ff7..2bd0738f 100644
--- a/test/permissions_test.rb
+++ b/test/permissions_test.rb
@@ -34,7 +34,7 @@ class PermissionsTest < ActionDispatch::IntegrationTest
delete blazer.query_path(query)
# TODO error response
- assert_response :redirect
+ assert_redirected_to blazer.root_path
assert Blazer::Query.exists?(query.id)
end
end
@@ -44,10 +44,10 @@ class PermissionsTest < ActionDispatch::IntegrationTest
query = create_query(name: "Test", creator: user)
patch blazer.query_path(query), params: {query: {name: "* Test"}}
- assert_response :redirect
+ assert_redirected_to blazer.query_path(query)
patch blazer.query_path(query), params: {query: {name: "# Test"}}
- assert_response :redirect
+ assert_redirected_to blazer.query_path(query)
end
end
diff --git a/test/queries_test.rb b/test/queries_test.rb
index 1a5a31b9..52be2a43 100644
--- a/test/queries_test.rb
+++ b/test/queries_test.rb
@@ -13,9 +13,9 @@ class QueriesTest < ActionDispatch::IntegrationTest
def test_create
post blazer.queries_path, params: {query: {name: "Test", statement: "SELECT 1", data_source: "main"}}
- assert_response :redirect
-
query = Blazer::Query.last
+ assert_redirected_to blazer.query_path(query)
+
get blazer.query_path(query)
assert_response :success
@@ -36,7 +36,7 @@ class QueriesTest < ActionDispatch::IntegrationTest
def test_destroy
query = create_query
delete blazer.query_path(query)
- assert_response :redirect
+ assert_redirected_to blazer.root_path
end
def test_rollback
@@ -66,7 +66,7 @@ class QueriesTest < ActionDispatch::IntegrationTest
def test_refresh
query = create_query
post blazer.refresh_query_path(query)
- assert_response :redirect
+ assert_redirected_to blazer.query_path(query)
end
def test_variables_time
diff --git a/test/uploads_test.rb b/test/uploads_test.rb
index 50c5a6e5..50ab3ac6 100644
--- a/test/uploads_test.rb
+++ b/test/uploads_test.rb
@@ -21,9 +21,9 @@ class UploadsTest < ActionDispatch::IntegrationTest
def test_create
create_upload
- assert_response :redirect
-
upload = Blazer::Upload.last
+ assert_redirected_to blazer.upload_path(upload)
+
assert_equal "line_items", upload.table
assert_equal "Billing line items", upload.description
@@ -41,7 +41,8 @@ class UploadsTest < ActionDispatch::IntegrationTest
def test_create_duplicate_table
create_upload
- assert_response :redirect
+ upload = Blazer::Upload.last
+ assert_redirected_to blazer.upload_path(upload)
Blazer::Upload.delete_all
create_upload
@@ -51,11 +52,11 @@ class UploadsTest < ActionDispatch::IntegrationTest
def test_rename
create_upload
- assert_response :redirect
-
upload = Blazer::Upload.last
+ assert_redirected_to blazer.upload_path(upload)
+
patch blazer.upload_path(upload), params: {upload: {table: "items"}}
- assert_response :redirect
+ assert_redirected_to blazer.upload_path(upload)
tables = Blazer::UploadsConnection.connection.select_all("SELECT table_name FROM information_schema.tables WHERE table_schema = 'uploads'").rows.map(&:first)
assert_equal ["items"], tables