Skip to content

Business intelligence made simple

Fixed leading zeros in variables - fixes #497

Andrew Kaneea8ec1e89d66
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7ff46f0a..db2b6386 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 3.2.1 (unreleased)
+
+- Fixed leading zeros in variables
+
## 3.2.0 (2025-02-23)
- Added support for Trino
diff --git a/lib/blazer/statement.rb b/lib/blazer/statement.rb
index d23a9c16..ba22ec1c 100644
--- a/lib/blazer/statement.rb
+++ b/lib/blazer/statement.rb
@@ -34,7 +34,10 @@ module Blazer
unless value.is_a?(ActiveSupport::TimeWithZone)
if value.match?(/\A\d+\z/)
- value = value.to_i
+ # check no leading zeros (when not zero)
+ if value == value.to_i.to_s
+ value = value.to_i
+ end
elsif value.match?(/\A\d+\.\d+\z/)
value = value.to_f
end
diff --git a/test/adapters/postgresql_test.rb b/test/adapters/postgresql_test.rb
index ab68b47a..d4fcf758 100644
--- a/test/adapters/postgresql_test.rb
+++ b/test/adapters/postgresql_test.rb
@@ -23,6 +23,10 @@ class PostgresqlTest < ActionDispatch::IntegrationTest
assert_result [{"hello" => "1"}], "SELECT {var} AS hello", var: "1"
end
+ def test_leading_zeros
+ assert_result [{"hello" => "0123"}], "SELECT {var} AS hello", var: "0123"
+ end
+
def test_float
assert_result [{"hello" => "1.5"}], "SELECT {var} AS hello", var: "1.5"
end
diff --git a/test/queries_test.rb b/test/queries_test.rb
index 3981e176..890bfc08 100644
--- a/test/queries_test.rb
+++ b/test/queries_test.rb
@@ -96,6 +96,20 @@ class QueriesTest < ActionDispatch::IntegrationTest
assert_match %!"variables":{"id":"123"}!, response.body
end
+ def test_variables_zero
+ query = create_query(statement: "SELECT {id}")
+ get blazer.query_path(query), params: {id: "0"}
+ assert_response :success
+ assert_match "SELECT 0", response.body
+ end
+
+ def test_variables_leading_zeros
+ query = create_query(statement: "SELECT {id}")
+ get blazer.query_path(query), params: {id: "0123"}
+ assert_response :success
+ assert_match "SELECT &#39;0123&#39;", response.body
+ end
+
def test_smart_variables
query = create_query(statement: "SELECT {period}")
get blazer.query_path(query)