Business intelligence made simple
Fixed cohort period default
Andrew Kanef9945c360b54
diff --git a/app/controllers/blazer/base_controller.rb b/app/controllers/blazer/base_controller.rbindex 4b95a132..1b359544 100644--- a/app/controllers/blazer/base_controller.rb+++ b/app/controllers/blazer/base_controller.rb@@ -72,7 +72,8 @@ module Blazerdef add_cohort_analysis_vars@bind_vars << "cohort_period" unless @bind_vars.include?("cohort_period")@smart_vars["cohort_period"] = ["day", "week", "month"]- params[:cohort_period] ||= "week"+ # TODO create var_params method+ request.query_parameters["cohort_period"] ||= "week"enddef parse_smart_variables(var, data_source)diff --git a/test/cohort_analysis_test.rb b/test/cohort_analysis_test.rbindex 523b04d7..6540b8da 100644--- a/test/cohort_analysis_test.rb+++ b/test/cohort_analysis_test.rb@@ -12,4 +12,11 @@ class CohortAnalysisTest < ActionDispatch::IntegrationTestrun_query "SELECT 1 AS user_id, NOW() AS conversion_time /* cohort analysis */", query_id: 1, data_source: "mysql"assert_match "1 cohort", response.bodyend++ def test_cohort_period_default+ query = create_query(statement: "SELECT 1 AS user_id, NOW() AS conversion_time /* cohort analysis */")+ get blazer.query_path(query)+ assert_response :success+ assert_match %{selected="selected" value="week"}, response.body+ endend