BrainAPI is a knowledge graph–powered AI memory layer that transforms unstructured data into structured knowledge, enabling intelligent search, recommendations, and contextual memory for AI agents and applications.
Python ai-agentsai-memoryknowledge-graphknowledge-managementknowledge-representationreccomendation-system
Drop leftover Postgres databases when deleting a brain. (#94)
Christian143cd63cb651
diff --git a/src/lib/postgresql/_provisioning.py b/src/lib/postgresql/_provisioning.pyindex 6fbe5ca..a1e9dde 100644--- a/src/lib/postgresql/_provisioning.py+++ b/src/lib/postgresql/_provisioning.py@@ -111,6 +111,16 @@ class _PoolRegistry:else:logger.debug("Evicted LRU pool: %s", evicted_name)+ def close(self, dbname: str) -> None:+ with self._lock:+ pool = self._pools.pop(dbname, None)+ if pool is None:+ return+ try:+ pool.closeall()+ except Exception as exc:+ logger.debug("Failed to close pool %s: %s", dbname, exc)+_registry = _PoolRegistry()@@ -255,3 +265,34 @@ def clear_brain_database()conn.commit()return tables+++def drop_brain_database(brain_id: str) -> bool:+ dbname = brain_db_name(brain_id)+ _registry.close(dbname)+ _created_dbs.discard(dbname)+ conn = psycopg2.connect(+ host=config.postgresql.host,+ port=config.postgresql.port,+ user=config.postgresql.username,+ password=config.postgresql.password,+ dbname=_maintenance_dbname(),+ )+ try:+ conn.autocommit = True+ with conn.cursor() as cur:+ cur.execute("SELECT 1 FROM pg_database WHERE datname = %s", (dbname,))+ if cur.fetchone() is None:+ return False+ cur.execute(+ "SELECT pg_terminate_backend(pid) FROM pg_stat_activity "+ "WHERE datname = %s AND pid <> pg_backend_pid()",+ (dbname,),+ )+ cur.execute(+ sql.SQL("DROP DATABASE IF EXISTS {}").format(sql.Identifier(dbname))+ )+ logger.info("Dropped Postgres database: %s", dbname)+ return True+ finally:+ conn.close()diff --git a/src/lib/postgresql/data.py b/src/lib/postgresql/data.pyindex 8d76ffc..ccc35ed 100644--- a/src/lib/postgresql/data.py+++ b/src/lib/postgresql/data.py@@ -38,6 +38,7 @@ from ._provisioning import (get_brain_pool,get_system_pool,clear_brain_database,+ drop_brain_database,list_brain_database_names,)@@ -606,6 +607,7 @@ class PostgreSQLDataClient(DataClient):)deleted = cur.rowcount > 0conn.commit()+ drop_brain_database(brain_id)return deleteddef save_kg_changes(self, kg_changes: KGChanges, brain_id: str) -> KGChanges:diff --git a/tests/test_drop_brain_database.py b/tests/test_drop_brain_database.pynew file mode 100644index 0000000..dc04dba--- /dev/null+++ b/tests/test_drop_brain_database.py@@ -0,0 +1,39 @@+from __future__ import annotations++from unittest.mock import MagicMock, patch++from src.lib.postgresql._naming import brain_db_name+from src.lib.postgresql._provisioning import drop_brain_database+++def test_drop_brain_database_terminates_sessions_then_drops():+ cursor = MagicMock()+ cursor.fetchone.return_value = (1,)+ conn = MagicMock()+ conn.cursor.return_value.__enter__.return_value = cursor+ with (+ patch("src.lib.postgresql._provisioning.psycopg2.connect", return_value=conn) as connect,+ patch("src.lib.postgresql._provisioning._registry.close") as close_pool,+ ):+ assert drop_brain_database("demo") is True++ close_pool.assert_called_once_with(brain_db_name("demo"))+ connect.assert_called_once()+ assert conn.autocommit is True+ statements = [call.args[0] for call in cursor.execute.call_args_list]+ assert any("pg_database" in str(statement) for statement in statements)+ assert any("pg_terminate_backend" in str(statement) for statement in statements)+ assert any("DROP DATABASE" in str(statement) for statement in statements)+ conn.close.assert_called_once()+++def test_drop_brain_database_is_idempotent_when_missing():+ cursor = MagicMock()+ cursor.fetchone.return_value = None+ conn = MagicMock()+ conn.cursor.return_value.__enter__.return_value = cursor+ with patch("src.lib.postgresql._provisioning.psycopg2.connect", return_value=conn):+ assert drop_brain_database("demo") is False++ statements = [call.args[0] for call in cursor.execute.call_args_list]+ assert not any("DROP DATABASE" in str(statement) for statement in statements)