Skip to content

BrainAPI is a knowledge graph–powered AI memory layer that transforms unstructured data into structured knowledge, enabling intelligent search, recommendations, and contextual memory for AI agents and applications.

Merge branch 'development' into cursor/codebase-architecture-quality-8861

Christian6abfec1b82a9
diff --cc tests/test_architecture_refactors.py
index 6fcaccf,1930643..e96ff10
--- a/tests/test_architecture_refactors.py
+++ b/tests/test_architecture_refactors.py
@@@ -38,11 -41,47 +41,50 @@@ from src.adapters.embeddings import
)
from src.adapters.graph import GraphAdapter
from src.constants.embeddings import Vector
+from src.constants.data import Observation, TextChunk
from src.core.agents.core.runtime_agent_factory import RuntimeAgentFactory
+
+
+ class _StubEmbeddingsAdapter:
+ def embed_text(self, *_args, **_kwargs):
+ return Vector(id="stub", embeddings=[], metadata={})
+
+
+ class _StubVectorStoreAdapter:
+ def search_vectors(self, *_args, **_kwargs):
+ return []
+
+
+ class _StubGraphAdapter:
+ def get_by_uuids(self, *_args, **_kwargs):
+ return []
+
+ def get_neighbors(self, *_args, **_kwargs):
+ return {}
+
+
+ class _StubDataAdapter:
+ def get_observations_list(self, *_args, **_kwargs):
+ return []
+
+
+ _stub_input_agents = types.ModuleType("src.services.input.agents")
+ _stub_input_agents.embeddings_adapter = _StubEmbeddingsAdapter()
+ sys.modules.setdefault("src.services.input.agents", _stub_input_agents)
+
+ _stub_kg_main = types.ModuleType("src.services.kg_agent.main")
+ _stub_kg_main.graph_adapter = _StubGraphAdapter()
+ _stub_kg_main.vector_store_adapter = _StubVectorStoreAdapter()
+ _stub_kg_main.embeddings_adapter = _StubEmbeddingsAdapter()
+ sys.modules.setdefault("src.services.kg_agent.main", _stub_kg_main)
+
+ _stub_data_main = types.ModuleType("src.services.data.main")
+ _stub_data_main.data_adapter = _StubDataAdapter()
+ sys.modules.setdefault("src.services.data.main", _stub_data_main)
+
from src.services.api.controllers.entities import get_entity_status
+from src.services.api.controllers.retrieve import retrieve_data
+from src.utils.vector_search import VectorSearchFacade
def raise_embedding_error(*args, **kwargs):
diff --cc tests/test_static_hardening_refactors.py
index fdac5d0,f0e9b19..c5a0d68
--- a/tests/test_static_hardening_refactors.py
+++ b/tests/test_static_hardening_refactors.py
@@@ -119,73 -119,16 +119,85 @@@ class EntityStatusHardeningTests(unitte
self.assertIn("continue", source)
+class VectorSearchFacadeArchitectureTests(unittest.TestCase):
+ def test_vector_search_facade_file_exists_with_store_helpers(self):
+ source = read_source("src/utils/vector_search.py")
+ self.assertIn("class VectorSearchFacade", source)
+ self.assertIn("def search_nodes(", source)
+ self.assertIn("def search_triplets(", source)
+ self.assertIn("def search_relationships(", source)
+ self.assertIn("def search_data(", source)
+ self.assertIn("store=store", source)
+ self.assertIn("brain_id=brain_id", source)
+
+ def test_retrieve_data_uses_facade_methods_not_positional_calls(self):
+ source = read_source("src/services/api/controllers/retrieve.py")
+ self.assertIn("vector_search = VectorSearchFacade(vector_store_adapter)", source)
+ self.assertIn("vector_search.search_data(", source)
+ self.assertIn("vector_search.search_triplets(", source)
+ self.assertIn("k=limit", source)
+ self.assertNotIn(
+ 'vector_store_adapter.search_vectors(\n text_embeddings.embeddings, "data", brain_id, limit',
+ source,
+ )
+ self.assertNotIn(
+ 'vector_store_adapter.search_vectors(\n text_embeddings.embeddings, "triplets", brain_id, limit',
+ source,
+ )
+
+ def test_key_modules_use_facade_or_keyword_safe_search(self):
+ expected_snippets = {
+ "src/services/api/controllers/entities.py": [
+ "VectorSearchFacade",
+ "vector_search.search_nodes(",
+ ],
+ "src/services/api/controllers/kg.py": [
+ "VectorSearchFacade",
+ "vector_search.search_nodes(",
+ ],
+ "src/services/mcp/main.py": [
+ "VectorSearchFacade",
+ "vector_search.search_nodes(",
+ ],
+ "src/core/search/entity_context.py": [
+ "VectorSearchFacade",
+ "vector_search.search_nodes(",
+ ],
+ "src/core/search/entity_info.py": [
+ "VectorSearchFacade",
+ "vector_search.search_nodes(",
+ ],
+ "src/core/search/entity_sibilings.py": [
+ "VectorSearchFacade",
+ "vector_search.search_nodes(",
+ ],
+ "src/core/agents/tools/kg_agent/KGAgentSearchGraphTool.py": [
+ 'store="triplets"',
+ 'store="nodes"',
+ "brain_id=self.brain_id",
+ ],
+ "src/core/agents/tools/kg_agent/KGAgentAddTripletsTool.py": [
+ 'store="nodes"',
+ "brain_id=self.brain_id",
+ "k=5",
+ ],
+ }
+ for relative_path, snippets in expected_snippets.items():
+ source = read_source(relative_path)
+ for snippet in snippets:
+ self.assertIn(snippet, source)
++
++
+ class JanitorToolDeduplicationTests(unittest.TestCase):
+ def test_janitor_tools_init_exports_single_graph_read_tool(self):
+ source = read_source("src/core/agents/tools/janitor_agent/__init__.py")
+ self.assertIn("JanitorAgentExecuteGraphReadOperationTool", source)
+ self.assertNotIn("JanitorAgentExecuteGraphOperationTool", source)
+
+ def test_janitor_agent_imports_single_graph_read_tool(self):
+ source = read_source("src/core/agents/janitor_agent.py")
+ self.assertIn("JanitorAgentExecuteGraphReadOperationTool", source)
+ self.assertNotIn("JanitorAgentExecuteGraphOperationTool", source)
if __name__ == "__main__":