Skip to content

BrainAPI is a knowledge graph–powered AI memory layer that transforms unstructured data into structured knowledge, enabling intelligent search, recommendations, and contextual memory for AI agents and applications.

fix(synergies): corerabbit suggestions

Christian9ae1d9e745d9
diff --git a/src/core/agents/tools/kg_agent/KGAgentRemoveRelationshipTool.py b/src/core/agents/tools/kg_agent/KGAgentRemoveRelationshipTool.py
index 049c728..f826345 100644
--- a/src/core/agents/tools/kg_agent/KGAgentRemoveRelationshipTool.py
+++ b/src/core/agents/tools/kg_agent/KGAgentRemoveRelationshipTool.py
@@ -149,6 +149,22 @@ class KGAgentRemoveRelationshipTool(BaseTool):
print(
f"[DEBUG (kg_agent_remove_relationship)]: Removing relationship: {_rel_uuid} - {_tail} - {_head} - {_relationship_name}"
)
+ if _relationship_name:
+ if not _tail or not _head:
+ return (
+ "Error: when removing by relationship name, both tail and head nodes must be provided and non-empty; "
+ "one or both are missing. Aborting to prevent invalid or broad deletions."
+ )
+ if isinstance(_tail, dict) and len(_tail) == 0:
+ return (
+ "Error: tail node cannot be empty when relationship name is provided. "
+ "Provide tail uuid or name and labels."
+ )
+ if isinstance(_head, dict) and len(_head) == 0:
+ return (
+ "Error: head node cannot be empty when relationship name is provided. "
+ "Provide head uuid or name and labels."
+ )
try:
removed_relationships = self.kg.remove_relationships(
relationships=[
@@ -176,7 +192,11 @@ class KGAgentRemoveRelationshipTool(BaseTool):
return f"Error removing relationship: {e}"
if len(removed_relationships) > 0:
- v_ids = [r.properties.get("v_id") for _, r, _ in removed_relationships if r.properties.get("v_id")]
+ v_ids = [
+ r.properties.get("v_id")
+ for _, r, _ in removed_relationships
+ if r.properties.get("v_id")
+ ]
if len(v_ids) > 0:
self.vector_store.remove_vectors(
v_ids, store="relationships", brain_id=self.brain_id
diff --git a/src/core/search/entity_sibilings.py b/src/core/search/entity_sibilings.py
index 813f79f..7a1593c 100644
--- a/src/core/search/entity_sibilings.py
+++ b/src/core/search/entity_sibilings.py
@@ -298,11 +298,11 @@ class EntitySinergyRetriever:
brain_id=self.brain_id,
)
if not target_node_vs:
- return None, [], []
+ return None, [], [], []
target_node_id = target_node_vs[0].metadata.get("uuid")
target_node = graph_adapter.get_by_uuid(target_node_id, brain_id=self.brain_id)
if not target_node:
- return None, [], []
+ return None, [], [], []
_neighbors = graph_adapter.get_neighbors(
[target_node_id], brain_id=self.brain_id
@@ -330,6 +330,7 @@ class EntitySinergyRetriever:
all_seed_nodes.extend(seed_nodes_for_neighbor)
for seed_node in seed_nodes_for_neighbor:
+ similar_seeds = []
if ppa or not do:
seed_vid = seed_node.properties.get("v_id")
if seed_vid:
diff --git a/src/lib/neo4j/client.py b/src/lib/neo4j/client.py
index 485fec1..e1a5c24 100644
--- a/src/lib/neo4j/client.py
+++ b/src/lib/neo4j/client.py
@@ -1064,7 +1064,9 @@ class Neo4jClient(GraphClient):
+ "])"
)
if node_uuids:
- filters.append(f"n['uuid'] IN [{','.join(node_uuids)}]")
+ filters.append(
+ f"n['uuid'] IN [{','.join(self._format_value(u) for u in node_uuids)}]"
+ )
if query_text:
filters.append(
f"(toLower(coalesce(n['name'], n['name'], '')) CONTAINS toLower({self._format_value(query_text)}))"
diff --git a/src/services/api/controllers/entities.py b/src/services/api/controllers/entities.py
index 1eaa4c8..55668a4 100644
--- a/src/services/api/controllers/entities.py
+++ b/src/services/api/controllers/entities.py
@@ -101,6 +101,11 @@ async def get_entity_sibilings(
target_node, synergies, seed_nodes, potential_anchors = (
entity_sibilings.retrieve_sibilings(target, polarity, do, pa, ppa)
)
+ if target_node is None:
+ return JSONResponse(
+ status_code=404,
+ content={"detail": "No entity found matching the target."},
+ )
return JSONResponse(
content={
"target_node": target_node.model_dump(mode="json"),