Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

Fix _generate_recent_events_summary to get_browser_state_summary

Magnus Müller0ead2043278f
diff --git a/tests/ci/test_browser_event_TypeTextEvent3.py b/tests/ci/test_browser_event_TypeTextEvent3.py
deleted file mode 100644
index 8f245933e..000000000
--- a/tests/ci/test_browser_event_TypeTextEvent3.py
+++ /dev/null
@@ -1,73 +0,0 @@
-from browser_use import BrowserProfile, BrowserSession
-
-
-async def test_input_text_fallback_for_non_standard_elements(httpserver):
- """Test that input text works on elements that don't support fill() by using type() as fallback."""
-
- # Create a test page with various input elements
- httpserver.expect_request('/').respond_with_data("""
- <html>
- <body>
- <!-- Standard input - should work with fill() -->
- <input id="standard-input" type="text" placeholder="Standard input">
-
- <!-- Contenteditable div - should NOT work with fill(), needs fallback -->
- <div id="contenteditable" contenteditable="true" style="border: 1px solid #ccc; padding: 5px;">
- Click here to edit
- </div>
-
- <!-- Custom element that might not support fill() -->
- <custom-element id="custom" tabindex="0" style="border: 1px solid #ccc; padding: 5px;">
- Custom element
- </custom-element>
- </body>
- </html>
- """)
-
- async with BrowserSession(browser_profile=BrowserProfile(user_data_dir=None, headless=True)) as session:
- page = await session.get_current_page()
- await page.goto(httpserver.url_for('/'))
-
- # Get the DOM state
- state = await session.get_browser_state_with_recovery()
-
- # Find elements by their text/attributes
- standard_input_index = None
- contenteditable_index = None
- custom_element_index = None
-
- for index, element in state.selector_map.items():
- if element.attributes.get('id') == 'standard-input':
- standard_input_index = index
- elif element.attributes.get('id') == 'contenteditable':
- contenteditable_index = index
- elif element.attributes.get('id') == 'custom':
- custom_element_index = index
-
- # Test standard input (should work normally)
- if standard_input_index is not None:
- element = state.selector_map[standard_input_index]
- await session._input_text_element_node(element, 'Test text for input')
-
- # Verify the text was entered
- value = await page.locator('#standard-input').input_value()
- assert value == 'Test text for input'
-
- # Test contenteditable div (should use fallback)
- if contenteditable_index is not None:
- element = state.selector_map[contenteditable_index]
- await session._input_text_element_node(element, 'Test text for contenteditable')
-
- # Verify the text was entered
- text = await page.locator('#contenteditable').text_content()
- assert 'Test text for contenteditable' in (text or '')
-
- # Test custom element (might use fallback)
- if custom_element_index is not None:
- element = state.selector_map[custom_element_index]
- # This might fail for truly custom elements, but should at least not crash
- try:
- await session._input_text_element_node(element, 'Test text for custom')
- except Exception:
- # It's okay if custom elements fail, as long as standard ones work
- pass
diff --git a/tests/ci/test_browser_session_element_cache.py b/tests/ci/test_browser_session_element_cache.py
index b70e858d9..6657529ab 100644
--- a/tests/ci/test_browser_session_element_cache.py
+++ b/tests/ci/test_browser_session_element_cache.py
@@ -94,7 +94,7 @@ async def test_assumption_1_dom_processing_works(browser_session, httpserver):
# Verify DOM processing works
assert len(state.selector_map) > 0, 'DOM processing should find elements'
- assert 0 in state.selector_map, 'Element index 0 should exist'
+ assert 0 in state.dom_state.selector_map, 'Element index 0 should exist'
@pytest.mark.asyncio
diff --git a/tests/ci/test_browser_session_recent_events.py b/tests/ci/test_browser_session_recent_events.py
index fdbffb878..344dcbf32 100644
--- a/tests/ci/test_browser_session_recent_events.py
+++ b/tests/ci/test_browser_session_recent_events.py
@@ -412,7 +412,9 @@ class TestEventHistoryInfrastructure:
await event.event_result(raise_if_any=True, raise_if_none=False)
# Test the NEW method _generate_recent_events_summary
- recent_events_json = browser_session._generate_recent_events_summary(max_events=5)
+ recent_events_json = await browser_session.get_browser_state_summary(include_recent_events=True)
+ recent_events_json = recent_events_json.recent_events
+ assert recent_events_json is not None
# Should return valid JSON
assert recent_events_json != '[]', 'Should have events'
diff --git a/tests/ci/test_browser_session_start.py b/tests/ci/test_browser_session_start.py
index 90a9ef2f0..b139b2abe 100644
--- a/tests/ci/test_browser_session_start.py
+++ b/tests/ci/test_browser_session_start.py
@@ -506,14 +506,16 @@ class TestBrowserSessionEventSystem:
assert len(started_events) >= 1
assert started_events[0].cdp_url is not None
- async def test_event_history_tracking(self, browser_session):
+ async def test_event_history_tracking(self, browser_session: BrowserSession):
"""Test that event history is properly tracked."""
# Start and stop browser to generate events
await browser_session.start()
await browser_session.stop()
# Check event history generation
- recent_events_json = browser_session._generate_recent_events_summary(max_events=5)
+ recent_events_json = await browser_session.get_browser_state_summary(include_recent_events=True)
+ recent_events_json = recent_events_json.recent_events
+ assert recent_events_json is not None
assert recent_events_json != '[]'
# Parse and validate the JSON
diff --git a/tests/ci/test_browser_session_storage_state.py b/tests/ci/test_browser_session_storage_state.py
index 61a1cb2d5..d955fe14c 100644
--- a/tests/ci/test_browser_session_storage_state.py
+++ b/tests/ci/test_browser_session_storage_state.py
@@ -16,7 +16,7 @@ from pathlib import Path
import pytest
from pytest_httpserver import HTTPServer
-from browser_use.browser.events import SaveStorageStateEvent
+from browser_use.browser.events import NavigateToUrlEvent, SaveStorageStateEvent
from browser_use.browser.profile import BrowserProfile
from browser_use.browser.session import BrowserSession
@@ -250,7 +250,9 @@ class TestStorageStateEventSystem:
await browser_session.start()
# Navigate to set cookies
- await browser_session.navigate(httpserver.url_for('/cookie-test'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/cookie-test')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Dispatch SaveStorageStateEvent directly
save_event = browser_session.event_bus.dispatch(SaveStorageStateEvent())
diff --git a/tests/ci/test_browser_session_tab_management.py b/tests/ci/test_browser_session_tab_management.py
index 97b4638af..e006c5733 100644
--- a/tests/ci/test_browser_session_tab_management.py
+++ b/tests/ci/test_browser_session_tab_management.py
@@ -8,6 +8,7 @@ from pytest_httpserver import HTTPServer
load_dotenv()
from browser_use.agent.views import ActionModel
+from browser_use.browser.events import NavigateToUrlEvent
from browser_use.browser.profile import BrowserProfile
from browser_use.browser.session import BrowserSession
from browser_use.tools.service import Tools
@@ -60,7 +61,9 @@ async def browser_session(base_url):
await browser_session.start()
# Create an initial tab using the navigate method which is more reliable
- await browser_session.navigate(f'{base_url}/page1', new_tab=True)
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page1', new_tab=True))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Wait for navigation to complete
await asyncio.sleep(1)
@@ -141,7 +144,7 @@ class TestTabManagement:
assert current_tab is not None
assert current_tab.url == 'about:blank'
- async def test_agent_changes_tab(self, browser_session, base_url):
+ async def test_agent_changes_tab(self, browser_session: BrowserSession, base_url):
"""Test that page changes and page remains the same when a new tab is opened."""
initial_tab = await self._reset_tab_state(browser_session, base_url)
@@ -181,7 +184,9 @@ class TestTabManagement:
assert browser_session.page.url == new_tab.url == f'{base_url}/page2'
# test agent navigation updates agent focus
- await browser_session.navigate(f'{base_url}/page3')
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page3'))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
assert browser_session.page.url == f'{base_url}/page3' # agent should now be on the new tab
async def test_switch_tab(self, browser_session, base_url):
@@ -189,7 +194,9 @@ class TestTabManagement:
# open a new tab for the agent to start on
first_tab = await self._reset_tab_state(browser_session, base_url)
- await browser_session.navigate(f'{base_url}/page1')
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page1'))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
assert first_tab.url == f'{base_url}/page1'
# open a new tab that the agent will switch to automatically
@@ -239,7 +246,9 @@ class TestTabManagement:
"""Test that closing a tab updates references correctly."""
initial_tab = await self._reset_tab_state(browser_session, base_url)
- await browser_session.navigate(f'{base_url}/page1')
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page1'))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# After navigation, browser_session.page should be the correct reference
assert browser_session.page.url == f'{base_url}/page1'
# The initial_tab (which was about:blank) should now show the new URL too
diff --git a/tests/ci/test_browser_watchdog_dom_service_ignore_empty_pages.py b/tests/ci/test_browser_watchdog_dom_service_ignore_empty_pages.py
deleted file mode 100644
index c81bd8a5c..000000000
--- a/tests/ci/test_browser_watchdog_dom_service_ignore_empty_pages.py
+++ /dev/null
@@ -1,85 +0,0 @@
-"""Test DomService behavior with chrome:// URLs and new tab pages."""
-
-import pytest
-
-from browser_use.browser.profile import BrowserProfile
-from browser_use.browser.session import BrowserSession
-from browser_use.dom.service import DomService
-
-
-class TestDomServiceChromeURLs:
- """Test that DomService returns empty DOM for chrome:// URLs and new tabs."""
-
- @pytest.fixture
- async def browser_session(self):
- """Create a browser session for testing."""
- profile = BrowserProfile(headless=True, user_data_dir=None, keep_alive=False)
- session = BrowserSession(browser_profile=profile)
- await session.start()
- yield session
- await session.kill()
-
- async def test_about_blank_returns_empty_dom(self, browser_session):
- """Test that about:blank returns an empty DOM."""
- page = await browser_session.get_current_page()
- await page.goto('about:blank')
-
- dom_service = DomService(page)
- dom_state = await dom_service.get_clickable_elements()
-
- # Verify empty DOM is returned
- assert dom_state.element_tree.tag_name == 'body'
- assert dom_state.element_tree.xpath == ''
- assert dom_state.element_tree.attributes == {}
- assert dom_state.element_tree.children == []
- assert dom_state.element_tree.is_visible is False
- assert dom_state.selector_map == {}
-
- async def test_chrome_new_tab_page_returns_empty_dom(self, browser_session):
- """Test that chrome://new-tab-page returns an empty DOM."""
- page = await browser_session.get_current_page()
- await page.goto('chrome://new-tab-page')
-
- dom_service = DomService(page)
- dom_state = await dom_service.get_clickable_elements()
-
- # Verify empty DOM
- assert dom_state.element_tree.tag_name == 'body'
- assert len(dom_state.element_tree.children) == 0
- assert dom_state.selector_map == {}
-
- async def test_chrome_version_returns_empty_dom(self, browser_session):
- """Test that chrome://version returns an empty DOM."""
- page = await browser_session.get_current_page()
- await page.goto('chrome://version')
-
- dom_service = DomService(page)
- dom_state = await dom_service.get_clickable_elements()
-
- # Verify empty DOM
- assert dom_state.element_tree.tag_name == 'body'
- assert len(dom_state.element_tree.children) == 0
- assert dom_state.selector_map == {}
-
- async def test_regular_url_returns_populated_dom(self, browser_session, httpserver):
- """Test that regular URLs still return a populated DOM."""
- # Set up test HTML
- httpserver.expect_request('/').respond_with_data("""
- <html>
- <body>
- <h1>Test Page</h1>
- <button id="test-button">Click me</button>
- <a href="#link">Test Link</a>
- </body>
- </html>
- """)
-
- page = await browser_session.get_current_page()
- await page.goto(httpserver.url_for('/'))
-
- dom_service = DomService(page)
- dom_state = await dom_service.get_clickable_elements()
-
- # Verify DOM is populated (either root is not body, or body has children)
- has_content = dom_state.element_tree.tag_name != 'body' or len(dom_state.element_tree.children) > 0
- assert has_content, f'Expected populated DOM but got empty tree with tag {dom_state.element_tree.tag_name}'
diff --git a/tests/ci/test_browser_watchdog_downloads.py b/tests/ci/test_browser_watchdog_downloads.py
index 426da3359..c423f7971 100644
--- a/tests/ci/test_browser_watchdog_downloads.py
+++ b/tests/ci/test_browser_watchdog_downloads.py
@@ -333,7 +333,7 @@ async def test_downloads_watchdog_detection_timing(comprehensive_download_test_s
# Find the button element
button_node = None
- for elem in state.selector_map.values():
+ for elem in state.dom_state.selector_map.values():
if elem.tag_name == 'button' and elem.attributes.get('id') == 'test-button':
button_node = elem
break
@@ -387,7 +387,7 @@ async def test_downloads_watchdog_detection_timing(comprehensive_download_test_s
# Find the button element again
button_node = None
- for elem in state.selector_map.values():
+ for elem in state.dom_state.selector_map.values():
if elem.tag_name == 'button' and elem.attributes.get('id') == 'test-button':
button_node = elem
break
@@ -449,7 +449,7 @@ async def test_downloads_watchdog_actual_download_detection(comprehensive_downlo
# Find the download link element
download_node = None
- for elem in state.selector_map.values():
+ for elem in state.dom_state.selector_map.values():
if elem.tag_name == 'a' and 'download' in elem.attributes:
download_node = elem
break
diff --git a/tests/ci/test_browser_watchdog_screenshots.py b/tests/ci/test_browser_watchdog_screenshots.py
index 039764930..d741d532c 100644
--- a/tests/ci/test_browser_watchdog_screenshots.py
+++ b/tests/ci/test_browser_watchdog_screenshots.py
@@ -9,6 +9,7 @@ import time
import pytest
from browser_use.browser import BrowserProfile, BrowserSession
+from browser_use.browser.events import NavigateToUrlEvent, ScreenshotEvent
class TestHeadlessScreenshots:
@@ -45,10 +46,14 @@ class TestHeadlessScreenshots:
)
# Navigate to test page
- await browser_session.navigate(httpserver.url_for('/'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Take screenshot
- screenshot_b64 = await browser_session.take_screenshot()
+ screenshot_event = browser_session.event_bus.dispatch(ScreenshotEvent())
+ await screenshot_event
+ screenshot_b64 = await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
# Verify screenshot was captured
assert screenshot_b64 is not None
@@ -64,7 +69,9 @@ class TestHeadlessScreenshots:
assert len(screenshot_bytes) > 5000, f'Screenshot too small: {len(screenshot_bytes)} bytes'
# Test full page screenshot
- full_page_screenshot = await browser_session.take_screenshot(full_page=True)
+ screenshot_event = browser_session.event_bus.dispatch(ScreenshotEvent(full_page=True))
+ await screenshot_event
+ full_page_screenshot = await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
assert full_page_screenshot is not None
full_page_bytes = base64.b64decode(full_page_screenshot)
assert full_page_bytes.startswith(b'\x89PNG\r\n\x1a\n')
@@ -92,7 +99,9 @@ class TestHeadlessScreenshots:
'<html><body><h1>State Summary Test</h1></body></html>',
content_type='text/html',
)
- await browser_session.navigate(httpserver.url_for('/'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Get state summary
state = await browser_session.get_browser_state_summary(cache_clickable_elements_hashes=False)
@@ -142,7 +151,9 @@ class TestHeadlessScreenshots:
assert state.url == 'about:blank' or state.url.startswith('chrome://'), f'Expected empty page but got {state.url}'
# Now navigate to a real page and verify screenshot works
- await browser_session.navigate(httpserver.url_for('/test'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/test')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Get state with screenshot
state = await browser_session.get_browser_state_summary(cache_clickable_elements_hashes=False)
@@ -353,19 +364,25 @@ class TestHeadlessScreenshots:
)
# Navigate to test page
- await browser_session.navigate(httpserver.url_for('/scrollable'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/scrollable')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
page = browser_session.page
assert page is not None
# Test 1: Screenshot at top of page (should work)
- screenshot_top = await browser_session.take_screenshot()
+ screenshot_event = browser_session.event_bus.dispatch(ScreenshotEvent())
+ await screenshot_event
+ screenshot_top = await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
assert screenshot_top is not None
assert len(base64.b64decode(screenshot_top)) > 5000
# Test 2: Screenshot at middle of page
await page.evaluate('window.scrollTo(0, document.body.scrollHeight / 2)')
await asyncio.sleep(0.1) # Wait for scroll
- screenshot_middle = await browser_session.take_screenshot()
+ screenshot_event = browser_session.event_bus.dispatch(ScreenshotEvent())
+ await screenshot_event
+ screenshot_middle = await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
assert screenshot_middle is not None
assert len(base64.b64decode(screenshot_middle)) > 5000
@@ -374,14 +391,18 @@ class TestHeadlessScreenshots:
await asyncio.sleep(0.1) # Wait for scroll
# This should not raise "Clipped area is either empty or outside the resulting image" error
- screenshot_bottom = await browser_session.take_screenshot()
+ screenshot_event = browser_session.event_bus.dispatch(ScreenshotEvent())
+ await screenshot_event
+ screenshot_bottom = await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
assert screenshot_bottom is not None
assert len(base64.b64decode(screenshot_bottom)) > 5000
# Test 4: Screenshot when scrolled beyond page bottom (edge case)
await page.evaluate('window.scrollTo(0, document.body.scrollHeight + 1000)')
await asyncio.sleep(0.1)
- screenshot_beyond = await browser_session.take_screenshot()
+ screenshot_event = browser_session.event_bus.dispatch(ScreenshotEvent())
+ await screenshot_event
+ screenshot_beyond = await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
assert screenshot_beyond is not None
assert len(base64.b64decode(screenshot_beyond)) > 5000
@@ -409,7 +430,9 @@ class TestScreenshotEventSystem:
'<html><body><h1>Screenshot Event Test</h1></body></html>',
content_type='text/html',
)
- await browser_session.navigate(httpserver.url_for('/event-test'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/event-test')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Test the NEW event-driven path: direct event dispatching
event = browser_session.event_bus.dispatch(ScreenshotEvent(full_page=False))
diff --git a/tests/old/test_clicks.py b/tests/old/test_clicks.py
index e665198c0..4908cf0ab 100644
--- a/tests/old/test_clicks.py
+++ b/tests/old/test_clicks.py
@@ -64,9 +64,9 @@ async def test_highlight_elements():
# Find and print duplicate XPaths
xpath_counts = {}
- if not state.selector_map:
+ if not state.dom_state.selector_map:
continue
- for selector in state.selector_map.values():
+ for selector in state.dom_state.selector_map.values():
xpath = selector.xpath
if xpath in xpath_counts:
xpath_counts[xpath] += 1
@@ -85,7 +85,7 @@ async def test_highlight_elements():
await time_execution_sync('remove_highlight_elements')(browser_session.remove_highlights)()
- node_element = state.selector_map[int(action)]
+ node_element = state.dom_state.selector_map[int(action)]
# check if index of selector map are the same as index of items in dom_items