Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
Address PR review feedback for record start/stop
Saurav Panda132756dabbb8
diff --git a/browser_use/browser/watchdogs/recording_watchdog.py b/browser_use/browser/watchdogs/recording_watchdog.pyindex 424b633b2..db33edaba 100644--- a/browser_use/browser/watchdogs/recording_watchdog.py+++ b/browser_use/browser/watchdogs/recording_watchdog.py@@ -38,7 +38,12 @@ class RecordingWatchdog(BaseWatchdog):video_format = getattr(profile, 'record_video_format', 'mp4').strip('.')output_path = Path(profile.record_video_dir) / f'{uuid7str()}.{video_format}'- await self.start_recording(output_path, size=profile.record_video_size, framerate=profile.record_video_framerate)+ try:+ await self.start_recording(output_path, size=profile.record_video_size, framerate=profile.record_video_framerate)+ except RuntimeError as e:+ # Preserve prior graceful degradation: a session configured with record_video_dir+ # should not fail startup when video deps are missing or viewport detection fails.+ self.logger.warning(f'Skipping video recording: {e}')async def start_recording(self,diff --git a/browser_use/skill_cli/commands/browser.py b/browser_use/skill_cli/commands/browser.pyindex 5c824e893..a0ac69a24 100644--- a/browser_use/skill_cli/commands/browser.py+++ b/browser_use/skill_cli/commands/browser.py@@ -779,6 +779,7 @@ async def handle(action: str, session: SessionInfo, params: dict[str, Any]) -> ARecordingWatchdog.model_rebuild()watchdog = RecordingWatchdog(event_bus=bs.event_bus, browser_session=bs)+ watchdog.attach_to_session()bs._recording_watchdog = watchdogrecord_command = params.get('record_command')diff --git a/browser_use/skill_cli/daemon.py b/browser_use/skill_cli/daemon.pyindex 95c8da5a0..2b2026a88 100644--- a/browser_use/skill_cli/daemon.py+++ b/browser_use/skill_cli/daemon.py@@ -448,14 +448,26 @@ class Daemon:self._server.close()if self._session:+ # Finalize any in-progress video recording before tearing down the browser,+ # otherwise the MP4 is truncated since the ffmpeg writer is never closed.+ bs = self._session.browser_session+ watchdog = getattr(bs, '_recording_watchdog', None)+ if watchdog is not None and getattr(watchdog, 'is_recording', False):+ try:+ saved = await asyncio.wait_for(watchdog.stop_recording(), timeout=5.0)+ if saved:+ logger.info(f'Finalized in-progress recording: {saved}')+ except Exception as e:+ logger.warning(f'Error finalizing recording during shutdown: {e}')+try:# Only kill the browser if the daemon launched it.# For external connections (--connect, --cdp-url, cloud), just disconnect.# Timeout ensures daemon exits even if CDP calls hang on a dead connectionif self.cdp_url or self.use_cloud:- await asyncio.wait_for(self._session.browser_session.stop(), timeout=10.0)+ await asyncio.wait_for(bs.stop(), timeout=10.0)else:- await asyncio.wait_for(self._session.browser_session.kill(), timeout=10.0)+ await asyncio.wait_for(bs.kill(), timeout=10.0)except TimeoutError:logger.warning('Browser cleanup timed out after 10s, forcing exit')except Exception as e:diff --git a/tests/ci/test_action_record.py b/tests/ci/test_action_record.pyindex 1611fd8a1..57d97a638 100644--- a/tests/ci/test_action_record.py+++ b/tests/ci/test_action_record.py@@ -109,6 +109,28 @@ async def test_stop_without_start_returns_none(browser_session: BrowserSession):assert await watchdog.stop_recording() is None+async def test_on_browser_connected_degrades_gracefully_when_recording_fails(+ browser_session: BrowserSession, tmp_path: Path, monkeypatch+):+ """If start_recording() raises (e.g. missing [video] deps), profile-driven recording+ must degrade to a warning instead of breaking BrowserSession startup (see PR #4710 review)."""+ from browser_use.browser.events import BrowserConnectedEvent+ from browser_use.browser.watchdogs import recording_watchdog as rw_mod++ watchdog = browser_session._recording_watchdog+ assert watchdog is not None++ async def fake_start_recording(self: Any, *_args: Any, **_kwargs: Any) -> Path:+ raise RuntimeError('simulated missing video deps')++ monkeypatch.setattr(rw_mod.RecordingWatchdog, 'start_recording', fake_start_recording)+ browser_session.browser_profile.record_video_dir = tmp_path++ # Must not raise — watchdog should catch the RuntimeError and just log a warning.+ await watchdog.on_BrowserConnectedEvent(BrowserConnectedEvent(cdp_url=browser_session.cdp_url or ''))+ assert not watchdog.is_recording++async def test_profile_record_video_dir_still_works(page_url: str, tmp_path: Path):"""The existing event-driven flow (profile.record_video_dir) must keep working."""session = BrowserSession(