Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
Scope DOM clickability cache by CDP session
MagMueller167f0c94d5f7
diff --git a/browser_use/dom/serializer/serializer.py b/browser_use/dom/serializer/serializer.pyindex 4374dc43c..9eca9c297 100644--- a/browser_use/dom/serializer/serializer.py+++ b/browser_use/dom/serializer/serializer.py@@ -72,7 +72,7 @@ class DOMTreeSerializer:# Add timing trackingself.timing_info: dict[str, float] = {}# Cache for clickable element detection to avoid redundant calls- self._clickable_cache: dict[int, bool] = {}+ self._clickable_cache: dict[tuple[str | None, int], bool] = {}# Bounding box filtering configurationself.enable_bbox_filtering = enable_bbox_filteringself.containment_threshold = containment_threshold or self.DEFAULT_CONTAINMENT_THRESHOLD@@ -417,7 +417,10 @@ class DOMTreeSerializer:def _is_interactive_cached(self, node: EnhancedDOMTreeNode) -> bool:"""Cached version of clickable element detection to avoid redundant calls."""- if node.node_id not in self._clickable_cache:+ # CDP node IDs are scoped to a session and can be reused by unrelated+ # elements in cross-origin iframe targets.+ cache_key = (str(node.session_id) if node.session_id is not None else None, node.node_id)+ if cache_key not in self._clickable_cache:import timestart_time = time.time()@@ -428,9 +431,9 @@ class DOMTreeSerializer:self.timing_info['clickable_detection_time'] = 0self.timing_info['clickable_detection_time'] += end_time - start_time- self._clickable_cache[node.node_id] = result+ self._clickable_cache[cache_key] = result- return self._clickable_cache[node.node_id]+ return self._clickable_cache[cache_key]def _create_simplified_tree(self, node: EnhancedDOMTreeNode, depth: int = 0) -> SimplifiedNode | None:"""Step 1: Create a simplified tree with enhanced element detection."""diff --git a/tests/ci/browser/test_dom_serializer_session_identity.py b/tests/ci/browser/test_dom_serializer_session_identity.pynew file mode 100644index 000000000..3d23decfb--- /dev/null+++ b/tests/ci/browser/test_dom_serializer_session_identity.py@@ -0,0 +1,61 @@+"""Regression coverage for CDP node identity across iframe sessions."""++from browser_use.dom.serializer.serializer import DOMTreeSerializer+from browser_use.dom.views import DOMRect, EnhancedDOMTreeNode, EnhancedSnapshotNode, NodeType+++def _node(tag_name: str, *, node_id: int, backend_node_id: int, session_id: str) -> EnhancedDOMTreeNode:+ return EnhancedDOMTreeNode(+ node_id=node_id,+ backend_node_id=backend_node_id,+ node_type=NodeType.ELEMENT_NODE,+ node_name=tag_name.upper(),+ node_value='',+ attributes={},+ is_scrollable=False,+ is_visible=True,+ absolute_position=DOMRect(x=0, y=0, width=100, height=30),+ target_id=f'target-{session_id}',+ frame_id=None,+ session_id=session_id,+ content_document=None,+ shadow_root_type=None,+ shadow_roots=None,+ parent_node=None,+ children_nodes=[],+ ax_node=None,+ snapshot_node=EnhancedSnapshotNode(+ is_clickable=None,+ cursor_style='auto',+ bounds=DOMRect(x=0, y=0, width=100, height=30),+ clientRects=DOMRect(x=0, y=0, width=100, height=30),+ scrollRects=None,+ computed_styles={+ 'display': 'block',+ 'visibility': 'visible',+ 'opacity': '1',+ 'background-color': 'rgba(0, 0, 0, 0)',+ },+ paint_order=None,+ stacking_contexts=None,+ ),+ )+++def test_clickability_cache_scopes_node_ids_to_cdp_session():+ """A main-page node must not poison an iframe input with the same CDP node ID."""+ non_interactive = _node('div', node_id=7, backend_node_id=20, session_id='main')+ iframe_input = _node('input', node_id=7, backend_node_id=21, session_id='iframe')+ root = _node('html', node_id=100, backend_node_id=100, session_id='main')+ root.children_nodes = [non_interactive, iframe_input]+ non_interactive.parent_node = root+ iframe_input.parent_node = root++ serialized_state = DOMTreeSerializer(+ root,+ enable_bbox_filtering=False,+ paint_order_filtering=False,+ ).serialize_accessible_elements()[0]++ assert list(serialized_state.selector_map.values()) == [iframe_input]+ assert '[21]<input' in serialized_state.llm_representation()