Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
Fix reconnect drop handling during reconnect
Shantanav2c3162069e5a
diff --git a/browser_use/browser/session.py b/browser_use/browser/session.pyindex baef63f48..c0c7f755e 100644--- a/browser_use/browser/session.py+++ b/browser_use/browser/session.py@@ -590,6 +590,7 @@ class BrowserSession(BaseModel):_reconnect_event: asyncio.Event = PrivateAttr(default_factory=asyncio.Event)_reconnect_lock: asyncio.Lock = PrivateAttr(default_factory=asyncio.Lock)_reconnect_task: asyncio.Task | None = PrivateAttr(default=None)+ _reconnect_pending: bool = PrivateAttr(default=False)_intentional_stop: bool = PrivateAttr(default=False)_logger: Any = PrivateAttr(default=None)@@ -634,6 +635,7 @@ class BrowserSession(BaseModel):if self._reconnect_task and not self._reconnect_task.done():self._reconnect_task.cancel()self._reconnect_task = None+ self._reconnect_pending = Falseself._reconnecting = Falseself._reconnect_event.set() # unblock any waiters@@ -2291,9 +2293,18 @@ class BrowserSession(BaseModel):))finally:+ reconnect_pending = self._reconnect_pending+ self._reconnect_pending = Falseself._reconnecting = Falseself._reconnect_event.set() # wake up all waiters regardless of outcome+ if reconnect_pending and not self._intentional_stop and self.cdp_url:+ try:+ loop = asyncio.get_running_loop()+ self._reconnect_task = loop.create_task(self._auto_reconnect())+ except RuntimeError:+ self.logger.error('🔌 No event loop available for pending auto-reconnect')+def _attach_ws_drop_callback(self) -> None:"""Attach a done callback to the CDPClient's message handler task to detect WS drops."""if not self._cdp_client_root or not hasattr(self._cdp_client_root, '_message_handler_task'):@@ -2304,8 +2315,11 @@ class BrowserSession(BaseModel):returndef _on_message_handler_done(fut: asyncio.Future) -> None:- # Guard: skip if intentionally stopped, already reconnecting, or no cdp_url- if self._intentional_stop or self._reconnecting or not self.cdp_url:+ # Guard: skip if intentionally stopped or no cdp_url+ if self._intentional_stop or not self.cdp_url:+ return+ if self._reconnecting:+ self._reconnect_pending = Truereturn# The message handler task exiting means the WS connection droppeddiff --git a/tests/ci/test_browser_session.py b/tests/ci/test_browser_session.pynew file mode 100644index 000000000..e07c81a3f--- /dev/null+++ b/tests/ci/test_browser_session.py@@ -0,0 +1,23 @@+import asyncio++from browser_use.browser.profile import BrowserProfile+from browser_use.browser.session import BrowserSession+++class MessageHandlerClient:+ def __init__(self, task: asyncio.Task) -> None:+ self._message_handler_task = task+++async def test_ws_drop_during_reconnect_is_recorded_for_retry() -> None:+ session = BrowserSession(browser_profile=BrowserProfile(headless=True, user_data_dir=None, cdp_url='ws://127.0.0.1:9222'))++ session._reconnecting = True+ connection_closed = asyncio.get_running_loop().create_future()+ task = asyncio.ensure_future(connection_closed)+ session._cdp_client_root = MessageHandlerClient(task) # type: ignore[assignment]+ session._attach_ws_drop_callback()+ connection_closed.set_exception(ConnectionResetError('ws dropped again'))+ await asyncio.sleep(0)+ connection_closed.exception()+ assert session._reconnect_pending