Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
more scroll tests
Nick Sweeting34c3ba6c96b5
diff --git a/tests/ci/test_ScrollEvent.py b/tests/ci/test_ScrollEvent.pyindex fc9b52ed9..bd57751eb 100644--- a/tests/ci/test_ScrollEvent.py+++ b/tests/ci/test_ScrollEvent.py@@ -139,16 +139,16 @@ class TestScrollActions:async def test_scroll_with_cross_origin_disabled(self, browser_session, base_url):"""Test that scroll works when cross_origin_iframes is disabled."""from browser_use.browser.events import ScrollEvent-+# Navigate to a pageawait browser_session._cdp_navigate(f'{base_url}/scrollable')await asyncio.sleep(0.5)-+# Test simple scroll - should not hangevent = browser_session.event_bus.dispatch(ScrollEvent(direction='down', amount=500))result = await asyncio.wait_for(event, timeout=3.0)assert result is not None-+# Test scroll upevent = browser_session.event_bus.dispatch(ScrollEvent(direction='up', amount=200))result = await asyncio.wait_for(event, timeout=3.0)@@ -157,7 +157,7 @@ class TestScrollActions:async def test_scroll_event_directly(self, browser_session):"""Test ScrollEvent directly through the event bus."""from browser_use.browser.events import ScrollEvent-+# Test scroll on about:blank (should work)event = browser_session.event_bus.dispatch(ScrollEvent(direction='down', amount=100))result = await asyncio.wait_for(event, timeout=2.0)@@ -165,20 +165,259 @@ class TestScrollActions:assert event_result is not Noneassert event_result.get('success') is True- async def test_scroll_without_hanging(self, browser_session):- """Test that scrolling doesn't hang with cross_origin_iframes=False."""+ async def test_scroll_non_scrollable_page(self, browser_session, base_url, http_server):+ """Test scrolling a page that's only 100px tall (not scrollable)."""from browser_use.browser.events import ScrollEvent-- # Simple test on about:blank - should not hang- event = browser_session.event_bus.dispatch(ScrollEvent(direction='down', amount=100))- result = await asyncio.wait_for(event, timeout=2.0)++ # Add a non-scrollable page (content fits in viewport)+ http_server.expect_request('/non-scrollable').respond_with_data(+ """+ <!DOCTYPE html>+ <html>+ <head>+ <title>Non-Scrollable Page</title>+ <style>+ body { margin: 0; padding: 10px; height: 80px; overflow: hidden; }+ .content { height: 60px; background: #f0f0f0; }+ </style>+ </head>+ <body>+ <div class="content">This page is too small to scroll</div>+ </body>+ </html>+ """,+ content_type='text/html',+ )++ # Navigate to non-scrollable page+ await browser_session._cdp_navigate(f'{base_url}/non-scrollable')+ await asyncio.sleep(0.5)++ # Get initial scroll position+ cdp_session = await browser_session.get_or_create_cdp_session()+ initial_scroll = await browser_session.cdp_client.send.Runtime.evaluate(+ params={'expression': 'window.pageYOffset', 'returnByValue': True},+ session_id=cdp_session.session_id,+ )+ initial_y = initial_scroll.get('result', {}).get('value', 0)++ # Try to scroll down - should succeed but not actually move+ event = browser_session.event_bus.dispatch(ScrollEvent(direction='down', amount=500))+ result = await asyncio.wait_for(event, timeout=3.0)event_result = await result.event_result()assert event_result is not Noneassert event_result.get('success') is True-- # Test scroll up- event = browser_session.event_bus.dispatch(ScrollEvent(direction='up', amount=50))- result = await asyncio.wait_for(event, timeout=2.0)++ # Check scroll position didn't change (page isn't scrollable)+ final_scroll = await browser_session.cdp_client.send.Runtime.evaluate(+ params={'expression': 'window.pageYOffset', 'returnByValue': True},+ session_id=cdp_session.session_id,+ )+ final_y = final_scroll.get('result', {}).get('value', 0)+ assert final_y == initial_y, f'Scroll position changed on non-scrollable page: {initial_y} -> {final_y}'++ async def test_scroll_very_long_page(self, browser_session, base_url, http_server):+ """Test scrolling a very long page (over 10,000px) by 8,000px."""+ from browser_use.browser.events import ScrollEvent++ # Add a very long page+ http_server.expect_request('/very-long').respond_with_data(+ """+ <!DOCTYPE html>+ <html>+ <head>+ <title>Very Long Page</title>+ <style>+ body { margin: 0; padding: 20px; }+ .content { height: 12000px; background: linear-gradient(to bottom, #f0f0f0, #333); }+ .marker { padding: 20px; background: #007bff; color: white; margin: 2000px 0; }+ </style>+ </head>+ <body>+ <h1 id="top">Very Long Page - Top</h1>+ <div class="content">+ <div class="marker" id="marker1">Marker 1 at 2000px</div>+ <div class="marker" id="marker2">Marker 2 at 4000px</div>+ <div class="marker" id="marker3">Marker 3 at 6000px</div>+ <div class="marker" id="marker4">Marker 4 at 8000px</div>+ <div class="marker" id="marker5">Marker 5 at 10000px</div>+ </div>+ <h1 id="bottom">Very Long Page - Bottom</h1>+ </body>+ </html>+ """,+ content_type='text/html',+ )++ # Navigate to very long page+ await browser_session._cdp_navigate(f'{base_url}/very-long')+ await asyncio.sleep(0.5)++ # Get initial scroll position+ cdp_session = await browser_session.get_or_create_cdp_session()+ initial_scroll = await browser_session.cdp_client.send.Runtime.evaluate(+ params={'expression': 'window.pageYOffset', 'returnByValue': True},+ session_id=cdp_session.session_id,+ )+ initial_y = initial_scroll.get('result', {}).get('value', 0)+ assert initial_y == 0, f'Page should start at top, but pageYOffset is {initial_y}'++ # Scroll down by 8000px+ event = browser_session.event_bus.dispatch(ScrollEvent(direction='down', amount=8000))+ result = await asyncio.wait_for(event, timeout=3.0)event_result = await result.event_result()assert event_result is not None- assert event_result.get('success') is True\ No newline at end of file+ assert event_result.get('success') is True++ # Wait a bit for scroll to take effect+ await asyncio.sleep(0.5)++ # Check scroll position moved significantly+ final_scroll = await browser_session.cdp_client.send.Runtime.evaluate(+ params={'expression': 'window.pageYOffset', 'returnByValue': True},+ session_id=cdp_session.session_id,+ )+ final_y = final_scroll.get('result', {}).get('value', 0)++ # Get page height to understand constraints+ page_height = await browser_session.cdp_client.send.Runtime.evaluate(+ params={'expression': 'document.body.scrollHeight', 'returnByValue': True},+ session_id=cdp_session.session_id,+ )+ scroll_height = page_height.get('result', {}).get('value', 0)++ # Should have scrolled down significantly (might not be exactly 8000 due to viewport constraints)+ assert final_y > 5000, f'Expected to scroll significantly (page height: {scroll_height}px), but only at {final_y}px'++ # Verify we can see marker 4 which is at 8000px+ marker4_visible = await browser_session.cdp_client.send.Runtime.evaluate(+ params={+ 'expression': """+ (() => {+ const marker = document.getElementById('marker4');+ const rect = marker.getBoundingClientRect();+ return rect.top >= 0 && rect.top <= window.innerHeight;+ })()+ """,+ 'returnByValue': True,+ },+ session_id=cdp_session.session_id,+ )+ assert marker4_visible.get('result', {}).get('value', False), 'Marker 4 should be visible after scrolling 8000px'++ async def test_scroll_iframe_content(self, browser_session, base_url, http_server):+ """Test scrolling inside a same-origin iframe."""+ from browser_use.browser.events import ScrollEvent++ # Add iframe content page+ http_server.expect_request('/iframe-content').respond_with_data(+ """+ <!DOCTYPE html>+ <html>+ <head>+ <style>+ body { margin: 0; padding: 10px; }+ .content { height: 2000px; background: linear-gradient(to bottom, #e0e0e0, #666); }+ </style>+ </head>+ <body>+ <h2 id="iframe-top">Iframe Content - Top</h2>+ <div class="content">+ <div style="margin-top: 900px;">Middle of iframe content</div>+ <div style="margin-top: 900px;">Bottom of iframe content</div>+ </div>+ </body>+ </html>+ """,+ content_type='text/html',+ )++ # Add main page with iframe+ http_server.expect_request('/page-with-iframe').respond_with_data(+ f"""+ <!DOCTYPE html>+ <html>+ <head>+ <title>Page with Iframe</title>+ <style>+ body {{ margin: 0; padding: 20px; }}+ #main-content {{ height: 200px; background: #f0f0f0; }}+ #scrollable-iframe {{+ width: 100%;+ height: 400px;+ border: 2px solid #333;+ }}+ </style>+ </head>+ <body>+ <div id="main-content">+ <h1>Main Page Content</h1>+ <p>This is the main page with an embedded iframe below.</p>+ </div>+ <iframe id="scrollable-iframe" src="{base_url}/iframe-content"></iframe>+ <div style="height: 200px; background: #e0e0e0;">+ <p>Content after iframe</p>+ </div>+ </body>+ </html>+ """,+ content_type='text/html',+ )++ # Navigate to page with iframe+ await browser_session._cdp_navigate(f'{base_url}/page-with-iframe')+ await asyncio.sleep(1.0) # Give iframe time to load++ # Get initial scroll position of main page and iframe+ cdp_session = await browser_session.get_or_create_cdp_session()++ # Check main page scroll+ main_scroll = await browser_session.cdp_client.send.Runtime.evaluate(+ params={'expression': 'window.pageYOffset', 'returnByValue': True},+ session_id=cdp_session.session_id,+ )+ main_y = main_scroll.get('result', {}).get('value', 0)++ # Check iframe scroll (should start at 0)+ iframe_initial = await browser_session.cdp_client.send.Runtime.evaluate(+ params={+ 'expression': """+ (() => {+ const iframe = document.getElementById('scrollable-iframe');+ if (iframe && iframe.contentWindow) {+ return iframe.contentWindow.pageYOffset || 0;+ }+ return -1;+ })()+ """,+ 'returnByValue': True,+ },+ session_id=cdp_session.session_id,+ )+ iframe_y = iframe_initial.get('result', {}).get('value', -1)+ assert iframe_y == 0, f'Iframe should start at top, but pageYOffset is {iframe_y}'++ # Scroll the main page first to bring iframe into view+ event = browser_session.event_bus.dispatch(ScrollEvent(direction='down', amount=100))+ await asyncio.wait_for(event, timeout=3.0)++ # Now try to scroll inside the iframe+ # Note: This would require finding the iframe element and scrolling it specifically+ # For now, we just verify the iframe exists and is scrollable+ iframe_scrollable = await browser_session.cdp_client.send.Runtime.evaluate(+ params={+ 'expression': """+ (() => {+ const iframe = document.getElementById('scrollable-iframe');+ if (iframe && iframe.contentDocument) {+ const iframeBody = iframe.contentDocument.body;+ return iframeBody.scrollHeight > iframe.clientHeight;+ }+ return false;+ })()+ """,+ 'returnByValue': True,+ },+ session_id=cdp_session.session_id,+ )+ assert iframe_scrollable.get('result', {}).get('value', False), 'Iframe should be scrollable'