Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

added FRAME to everywhere where we have IFRAME

Gregor Žunič3d8e00f0b02e
diff --git a/browser_use/dom/serializer/clickable_elements.py b/browser_use/dom/serializer/clickable_elements.py
index 807bbcc01..e1d514629 100644
--- a/browser_use/dom/serializer/clickable_elements.py
+++ b/browser_use/dom/serializer/clickable_elements.py
@@ -20,7 +20,7 @@ class ClickableElementDetector:
# IFRAME elements should be interactive if they're large enough to potentially need scrolling
# Small iframes (< 100px width or height) are unlikely to have scrollable content
- if node.tag_name and node.tag_name.upper() == 'IFRAME':
+ if node.tag_name and node.tag_name.upper() == 'IFRAME' or node.tag_name.upper() == 'FRAME':
if node.snapshot_node and node.snapshot_node.bounds:
width = node.snapshot_node.bounds.width
height = node.snapshot_node.bounds.height
diff --git a/browser_use/dom/serializer/serializer.py b/browser_use/dom/serializer/serializer.py
index d660a648b..ec74e0702 100644
--- a/browser_use/dom/serializer/serializer.py
+++ b/browser_use/dom/serializer/serializer.py
@@ -435,7 +435,12 @@ class DOMTreeSerializer:
# Add element with interactive_index if clickable, scrollable, or iframe
is_any_scrollable = node.original_node.is_actually_scrollable or node.original_node.is_scrollable
should_show_scroll = node.original_node.should_show_scroll_info
- if node.interactive_index is not None or is_any_scrollable or node.original_node.tag_name.upper() == 'IFRAME':
+ if (
+ node.interactive_index is not None
+ or is_any_scrollable
+ or node.original_node.tag_name.upper() == 'IFRAME'
+ or node.original_node.tag_name.upper() == 'FRAME'
+ ):
next_depth += 1
# Build attributes string
@@ -453,6 +458,9 @@ class DOMTreeSerializer:
elif node.original_node.tag_name.upper() == 'IFRAME':
# Iframe element (not interactive)
line = f'{depth_str}|IFRAME|<{node.original_node.tag_name}'
+ elif node.original_node.tag_name.upper() == 'FRAME':
+ # Frame element (not interactive)
+ line = f'{depth_str}|FRAME|<{node.original_node.tag_name}'
else:
line = f'{depth_str}<{node.original_node.tag_name}'
diff --git a/browser_use/dom/service.py b/browser_use/dom/service.py
index 9076ece75..155c2d498 100644
--- a/browser_use/dom/service.py
+++ b/browser_use/dom/service.py
@@ -187,7 +187,7 @@ class DomService:
for frame in reversed(html_frames):
if (
frame.node_type == NodeType.ELEMENT_NODE
- and frame.node_name.upper() == 'IFRAME'
+ and (frame.node_name.upper() == 'IFRAME' or frame.node_name.upper() == 'FRAME')
and frame.snapshot_node
and frame.snapshot_node.bounds
):
@@ -561,7 +561,11 @@ class DomService:
)
# Calculate new iframe offset for content documents, accounting for iframe scroll
- if node['nodeName'].upper() == 'IFRAME' and snapshot_data and snapshot_data.bounds:
+ if (
+ (node['nodeName'].upper() == 'IFRAME' or node['nodeName'].upper() == 'FRAME')
+ and snapshot_data
+ and snapshot_data.bounds
+ ):
if snapshot_data.bounds:
updated_html_frames.append(dom_tree_node)