Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

fix(storage_state): typing + format cleanup

Laith Weinberger4b81a4212d67
diff --git a/browser_use/browser/session.py b/browser_use/browser/session.py
index 14d21a6d7..59272ad3e 100644
--- a/browser_use/browser/session.py
+++ b/browser_use/browser/session.py
@@ -657,7 +657,6 @@ class BrowserSession(BaseModel):
assert self.cdp_client is not None
# Notify that browser is connected (single place)
-
# Ensure BrowserConnected handlers (storage_state restore) complete before
# start() returns so cookies/storage are applied before navigation.
await self.event_bus.dispatch(BrowserConnectedEvent(cdp_url=self.cdp_url))
diff --git a/browser_use/browser/watchdogs/storage_state_watchdog.py b/browser_use/browser/watchdogs/storage_state_watchdog.py
index 4f6e3e391..44e328f0f 100644
--- a/browser_use/browser/watchdogs/storage_state_watchdog.py
+++ b/browser_use/browser/watchdogs/storage_state_watchdog.py
@@ -251,16 +251,16 @@ class StorageStateWatchdog(BaseWatchdog):
if 'cookies' in storage and storage['cookies']:
# Playwright exports session cookies with expires=0/-1. CDP treats expires=0 as expired.
# Normalize session cookies by omitting expires
- normalized_cookies: list[dict[str, Any]] = []
+ normalized_cookies: list[Cookie] = []
for cookie in storage['cookies']:
if not isinstance(cookie, dict):
- normalized_cookies.append(cookie)
+ normalized_cookies.append(cookie) # type: ignore[arg-type]
continue
c = dict(cookie)
expires = c.get('expires')
if expires in (0, 0.0, -1, -1.0):
c.pop('expires', None)
- normalized_cookies.append(c)
+ normalized_cookies.append(Cookie(**c))
await self.browser_session._cdp_set_cookies(normalized_cookies)
self._last_cookie_state = storage['cookies'].copy()
@@ -277,16 +277,14 @@ class StorageStateWatchdog(BaseWatchdog):
if origin.get('localStorage'):
lines = []
for item in origin['localStorage']:
- lines.append(
- f"window.localStorage.setItem({json.dumps(item['name'])}, {json.dumps(item['value'])});"
- )
+ lines.append(f'window.localStorage.setItem({json.dumps(item["name"])}, {json.dumps(item["value"])});')
script = (
- "(function(){\n"
- f" if (window.location && window.location.origin !== {json.dumps(origin_value)}) return;\n"
- " try {\n"
- f" {' '.join(lines)}\n"
- " } catch (e) {}\n"
- "})();"
+ '(function(){\n'
+ f' if (window.location && window.location.origin !== {json.dumps(origin_value)}) return;\n'
+ ' try {\n'
+ f' {" ".join(lines)}\n'
+ ' } catch (e) {}\n'
+ '})();'
)
await self.browser_session._cdp_add_init_script(script)
@@ -294,15 +292,15 @@ class StorageStateWatchdog(BaseWatchdog):
lines = []
for item in origin['sessionStorage']:
lines.append(
- f"window.sessionStorage.setItem({json.dumps(item['name'])}, {json.dumps(item['value'])});"
+ f'window.sessionStorage.setItem({json.dumps(item["name"])}, {json.dumps(item["value"])});'
)
script = (
- "(function(){\n"
- f" if (window.location && window.location.origin !== {json.dumps(origin_value)}) return;\n"
- " try {\n"
- f" {' '.join(lines)}\n"
- " } catch (e) {}\n"
- "})();"
+ '(function(){\n'
+ f' if (window.location && window.location.origin !== {json.dumps(origin_value)}) return;\n'
+ ' try {\n'
+ f' {" ".join(lines)}\n'
+ ' } catch (e) {}\n'
+ '})();'
)
await self.browser_session._cdp_add_init_script(script)
self.logger.debug(