Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
fix(agent): give each MessageManager its own state (mutable default arg)
abhay-codes0750e2dd184dd0
diff --git a/browser_use/agent/message_manager/service.py b/browser_use/agent/message_manager/service.pyindex 6c7cae11a..669cbfe23 100644--- a/browser_use/agent/message_manager/service.py+++ b/browser_use/agent/message_manager/service.py@@ -109,7 +109,7 @@ class MessageManager:task: str,system_message: SystemMessage,file_system: FileSystem,- state: MessageManagerState = MessageManagerState(),+ state: MessageManagerState | None = None,use_thinking: bool = True,include_attributes: list[str] | None = None,sensitive_data: dict[str, str | dict[str, str]] | None = None,@@ -122,7 +122,10 @@ class MessageManager:max_clickable_elements_length: int = 40000,):self.task = task- self.state = state+ # A fresh state per instance: a mutable default (MessageManagerState()) would be+ # evaluated once at definition time and shared across every MessageManager created+ # without an explicit state, cross-contaminating their history.+ self.state = state if state is not None else MessageManagerState()self.system_prompt = system_messageself.file_system = file_systemself.sensitive_data_description = ''diff --git a/tests/ci/test_message_manager_state_isolation.py b/tests/ci/test_message_manager_state_isolation.pynew file mode 100644index 000000000..1d827faf7--- /dev/null+++ b/tests/ci/test_message_manager_state_isolation.py@@ -0,0 +1,52 @@+"""Regression test for MessageManager state isolation.++MessageManager.__init__ used a mutable default argument `state=MessageManagerState()`,+which is evaluated once at definition time and therefore shared by every MessageManager+created without an explicit state. History (`agent_history_items`, etc.) then leaked+across otherwise-independent instances.+"""++import tempfile++from browser_use.agent.message_manager.service import MessageManager+from browser_use.agent.views import MessageManagerState+from browser_use.filesystem.file_system import FileSystem+from browser_use.llm import SystemMessage+++def _make_manager(task: str) -> MessageManager:+ return MessageManager(+ task=task,+ system_message=SystemMessage(content='system'),+ file_system=FileSystem(tempfile.mkdtemp()),+ )+++def test_managers_get_independent_state():+ mm1 = _make_manager('task one')+ mm2 = _make_manager('task two')++ assert mm1.state is not mm2.state+ assert mm1.state.agent_history_items is not mm2.state.agent_history_items+++def test_mutating_one_manager_does_not_affect_another():+ mm1 = _make_manager('task one')+ mm2 = _make_manager('task two')++ mm1.add_new_task('do X only in agent 1')++ leaked = any('do X only in agent 1' in (item.system_message or '') for item in mm2.state.agent_history_items)+ assert not leaked+ assert '<follow_up_user_request>' not in mm2.task+++def test_explicit_state_is_used_as_is():+ shared = MessageManagerState()+ mm = MessageManager(+ task='task',+ system_message=SystemMessage(content='system'),+ file_system=FileSystem(tempfile.mkdtemp()),+ state=shared,+ )+ assert mm.state is shared